Skip to content

Minor bump for firestore #5309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Minor bump for firestore #5309

merged 1 commit into from
Sep 8, 2023

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Sep 8, 2023

Per b/299650417,

This bumps firebase-firestore by a minor version, as should've been done by the deprecation of a public method in #5256.

@daymxn daymxn requested a review from rlazo September 8, 2023 18:44
@daymxn daymxn self-assigned this Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.63% (c3b8210) to 44.62% (348f216) by -0.02%.

    FilenameBase (c3b8210)Merge (348f216)Diff
    LruGarbageCollector.java97.27%93.64%-3.64%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/No4NV84Se4.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Unit Test Results

   164 files  +   164     164 suites  +164   2m 19s ⏱️ + 2m 19s
1 205 tests +1 205  1 189 ✔️ +1 189  16 💤 +16  0 ±0 
2 410 runs  +2 410  2 378 ✔️ +2 378  32 💤 +32  0 ±0 

Results for commit 160de4f. ± Comparison against base commit c3b8210.

@rlazo rlazo requested a review from tom-andersen September 8, 2023 18:56
@google-oss-bot
Copy link
Contributor

@daymxn daymxn merged commit 87c1f02 into master Sep 8, 2023
@daymxn daymxn deleted the daymon-minor-bump-firestore branch September 8, 2023 19:17
@firebase firebase locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants