Skip to content

fix functions #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2019
Merged

fix functions #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa3935
fix functions
VinayGuthal Jun 14, 2019
c4d4caf
update minsdk version
VinayGuthal Jun 14, 2019
f2ba371
remove idea
VinayGuthal Jun 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions firebase-functions/firebase-functions.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ android {
compileSdkVersion project.targetSdkVersion
defaultConfig {
targetSdkVersion project.targetSdkVersion
minSdkVersion project.minSdkVersion
minSdkVersion 16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a breaking change? Do we want to make it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was supposed to be done at io.. But this didnt go through. https://github.com/FirebasePrivate/firebase-android-sdk/pull/303 for more details

versionName version
multiDexEnabled true
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand All @@ -53,7 +53,7 @@ dependencies {
implementation 'com.google.android.gms:play-services-basement:16.2.0'
implementation 'com.google.android.gms:play-services-base:16.1.0'
implementation 'com.google.android.gms:play-services-tasks:16.0.1'
implementation ('com.google.firebase:firebase-iid:17.0.3') {
implementation ('com.google.firebase:firebase-iid:18.0.0') {
exclude group: 'com.google.firebase', module: 'firebase-common'
}
implementation ('com.google.firebase:firebase-auth-interop:17.0.0') {
Expand Down
2 changes: 1 addition & 1 deletion firebase-functions/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
version=16.3.1
version=17.0.0
latestReleasedVersion=16.3.0
android.enableUnitTestBinaryResources=true
2 changes: 1 addition & 1 deletion firebase-functions/ktx/ktx.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ firebaseLibrary {
android {
compileSdkVersion project.targetSdkVersion
defaultConfig {
minSdkVersion project.minSdkVersion
minSdkVersion 16
multiDexEnabled true
targetSdkVersion project.targetSdkVersion
versionName version
Expand Down
2 changes: 1 addition & 1 deletion firebase-functions/ktx/src/androidTest/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.google.firebase.functions.ktx">
<!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
<!--<uses-sdk android:minSdkVersion="15" android:targetSdkVersion="23" />-->
<!--<uses-sdk android:minSdkVersion="16" android:targetSdkVersion="23" />-->
<uses-permission android:name="android.permission.INTERNET"/>
<application
android:usesCleartextTraffic="true">
Expand Down
2 changes: 1 addition & 1 deletion firebase-functions/ktx/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.google.firebase.functions.ktx">
<!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
<!--<uses-sdk android:minSdkVersion="14"/>-->
<!--<uses-sdk android:minSdkVersion="16"/>-->
<application>
<service android:name="com.google.firebase.components.ComponentDiscoveryService" android:exported="false">
<meta-data android:name="com.google.firebase.components:com.google.firebase.functions.ktx.FirebaseFunctionsKtxRegistrar"
Expand Down
2 changes: 1 addition & 1 deletion firebase-functions/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
xmlns:tools="http://schemas.android.com/tools"
package="com.google.firebase.functions">
<!--Although the *SdkVersion is captured in gradle build files, this is required for non gradle builds-->
<!--<uses-sdk android:minSdkVersion="14" />-->
<!--<uses-sdk android:minSdkVersion="16" />-->
<uses-permission android:name="android.permission.INTERNET" />
<application>
<service android:name="com.google.firebase.components.ComponentDiscoveryService" android:exported="false">
Expand Down