Skip to content

Update release commands in README files #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Aug 4, 2023

Per b/294577585,

This updates any references to our previous release commands to now represent the new process; including the removal of the barebones publishAll.

Additionally, this fixes the following:

  • b/294577524 -> Add a default name for releases when using commands
  • b/294578506 -> Add a link to our contributor documentation in our buildSrc README

@daymxn daymxn requested a review from davidmotson August 4, 2023 18:59
@daymxn daymxn self-assigned this Aug 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

buildSrc Test Results

33 tests   33 ✔️  1m 15s ⏱️
  7 suites    0 💤
  7 files      0

Results for commit 65f37c5.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (c10cd5b) to 50.16% (2a6ade8) by -0.01%.

    FilenameBase (c10cd5b)Merge (2a6ade8)Diff
    BooleanNode.java100.00%92.31%-7.69%
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    WebsocketConnection.java35.03%32.77%-2.26%
  • firebase-messaging

    Overall coverage changed from 84.18% (c10cd5b) to 84.14% (2a6ade8) by -0.04%.

    FilenameBase (c10cd5b)Merge (2a6ade8)Diff
    FirebaseMessaging.java73.13%73.57%+0.44%
    RequestDeduplicator.java90.00%80.00%-10.00%
  • firebase-storage

    Overall coverage changed from ? (c10cd5b) to 85.81% (2a6ade8) by ?.

    46 individual files with coverage change

    FilenameBase (c10cd5b)Merge (2a6ade8)Diff
    ActivityLifecycleListener.java?74.14%?
    AdaptiveStreamBuffer.java?84.62%?
    CancelException.java?100.00%?
    CancellableTask.java?100.00%?
    ControllableTask.java?100.00%?
    DeleteNetworkRequest.java?100.00%?
    DeleteStorageTask.java?100.00%?
    ExponentialBackoffSender.java?86.00%?
    FileDownloadTask.java?80.00%?
    FirebaseStorage.java?83.67%?
    FirebaseStorageComponent.java?100.00%?
    GetDownloadUrlTask.java?96.77%?
    GetMetadataNetworkRequest.java?100.00%?
    GetMetadataTask.java?85.19%?
    GetNetworkRequest.java?100.00%?
    HttpURLConnectionFactory.java?0.00%?
    HttpURLConnectionFactoryImpl.java?50.00%?
    ListNetworkRequest.java?100.00%?
    ListResult.java?100.00%?
    ListTask.java?85.71%?
    NetworkRequest.java?86.60%?
    OnPausedListener.java?0.00%?
    OnProgressListener.java?0.00%?
    ResumableNetworkRequest.java?100.00%?
    ResumableUploadByteRequest.java?90.91%?
    ResumableUploadCancelRequest.java?100.00%?
    ResumableUploadQueryRequest.java?100.00%?
    ResumableUploadStartRequest.java?95.24%?
    Slashes.java?88.24%?
    Sleeper.java?0.00%?
    SleeperImpl.java?100.00%?
    SmartHandler.java?92.31%?
    StorageException.java?65.45%?
    StorageMetadata.java?86.34%?
    StorageReference.java?89.94%?
    StorageReferenceUri.java?100.00%?
    StorageRegistrar.java?100.00%?
    StorageTask.java?83.69%?
    StorageTaskManager.java?100.00%?
    StorageTaskScheduler.java?95.45%?
    StreamDownloadTask.java?88.41%?
    TaskListenerImpl.java?100.00%?
    UpdateMetadataNetworkRequest.java?100.00%?
    UpdateMetadataTask.java?82.14%?
    UploadTask.java?81.85%?
    Util.java?73.24%?

  • firebase-firestore

    FilenameBase (c10cd5b)Merge (2a6ade8)Diff
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java94.44%97.22%+2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2t4fzxcqo2.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 4, 2023

Startup Time Report 1

The report is too large (122,624 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PeYZ3ZnAVQ/index.html

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Unit Test Results

   820 files  +  14     820 suites  +14   39m 9s ⏱️ + 2m 11s
4 995 tests ±    0  4 974 ✔️ +    1  21 💤 ±0  0  - 1 
9 899 runs  +112  9 857 ✔️ +113  42 💤 ±0  0  - 1 

Results for commit 65f37c5. ± Comparison against base commit 177c51f.

♻️ This comment has been updated with latest results.

@daymxn daymxn requested a review from rlazo August 9, 2023 17:52
@daymxn daymxn requested a review from rlazo August 11, 2023 20:08
@daymxn daymxn enabled auto-merge (squash) August 16, 2023 20:24
@daymxn daymxn disabled auto-merge August 16, 2023 20:24
@daymxn daymxn merged commit f2a0fa3 into master Aug 16, 2023
@daymxn daymxn deleted the daymon-update-readmes branch August 16, 2023 20:24
limsaehyun pushed a commit to limsaehyun/firebase-android-sdk that referenced this pull request Sep 5, 2023
Per [b/294577585](https://b.corp.google.com/issues/294577585),

This updates any references to our previous release commands to now
represent the new process; including the removal of the barebones
`publishAll`.

Additionally, this fixes the following:

- [b/294577524](https://b.corp.google.com/issues/294577524) -> Add a
default name for releases when using commands
- [b/294578506](https://b.corp.google.com/issues/294578506) -> Add a
link to our contributor documentation in our buildSrc README

NO_RELEASE_CHANGE
@firebase firebase locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants