Firestore: QueryTest.java: use a different Firestore instance instead of a WriteBatch #5184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of a WriteBatch to avoid affecting the local cache. This fixes the bug introduced by #5167 where WriteBatch affects the local cache (which I didn't realize).
Release note changesNo release note changes were detected. If you made changes that should be |
Coverage Report 1Affected Products
Test Logs |
Unit Test Results 162 files - 656 162 suites - 656 2m 22s ⏱️ - 35m 50s Results for commit f2d25c0. ± Comparison against base commit 2314e82. ♻️ This comment has been updated with latest results. |
Size Report 1Affected ProductsNo changes between base commit (2314e82) and merge commit (a95c793).Test Logs |
…ceInsteadOfWriteBatch
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
milaGGL
reviewed
Jul 24, 2023
firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
Show resolved
Hide resolved
dconeybe
deleted the
dconeybe/BloomFilterTestUseDifferentInstanceInsteadOfWriteBatch
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different Firestore instance instead of a
WriteBatchto avoid affecting the local cache inQueryTest.java.I had originally thought that
WriteBatchsidestepped the local cache, just like a transaction did; however, that turned out to be incorrect and using aWriteBatchnullified the test cases that were modified to use it. This is a follow-up to #5167.This PR was ported from firebase/firebase-js-sdk#7486.