Skip to content

Use actual version for androidx.core.test inside smoke-tests #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 20, 2023

It doesn't import the main build file, thus cannot find the variable.

It doesn't import the main build file, thus cannot find the variable.
@rlazo rlazo requested review from daymxn and emilypgoogle July 20, 2023 22:31
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

Unit Test Results

   818 files     818 suites   37m 3s ⏱️
4 956 tests 4 935 ✔️ 21 💤 0
9 821 runs  9 779 ✔️ 42 💤 0

Results for commit cdde446.

@google-oss-bot
Copy link
Contributor

@rlazo rlazo merged commit eafda53 into master Jul 20, 2023
@rlazo rlazo deleted the rl.smoke.test.fix branch July 20, 2023 23:17
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (dc08ef1) to 50.18% (7f5d63e) by -0.04%.

    FilenameBase (dc08ef1)Merge (7f5d63e)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
  • firebase-firestore

    Overall coverage changed from 44.41% (dc08ef1) to 44.34% (7f5d63e) by -0.07%.

    FilenameBase (dc08ef1)Merge (7f5d63e)Diff
    AsyncQueue.java78.61%70.65%-7.96%
    PatchMutation.java100.00%98.39%-1.61%
  • firebase-messaging

    Overall coverage changed from 84.21% (dc08ef1) to 84.10% (7f5d63e) by -0.11%.

    FilenameBase (dc08ef1)Merge (7f5d63e)Diff
    FirebaseMessaging.java73.57%73.13%-0.44%
    RequestDeduplicator.java90.00%80.00%-10.00%
  • firebase-perf

    Overall coverage changed from 71.20% (dc08ef1) to 71.19% (7f5d63e) by -0.02%.

    FilenameBase (dc08ef1)Merge (7f5d63e)Diff
    RateLimiter.java91.54%90.77%-0.77%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u2IOgRmuSv.html

@firebase firebase locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants