Skip to content

Firestore: Bloom filter minor code cleanup for consistency with web sdk #5177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

Firestore: Bloom filter minor code cleanup for consistency with web sdk #5177

merged 1 commit into from
Jul 20, 2023

Conversation

dconeybe
Copy link
Contributor

Port some small code changes from firebase/firebase-js-sdk#7474 to be consistent with the web sdk.

@dconeybe dconeybe self-assigned this Jul 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe dconeybe mentioned this pull request Jul 18, 2023
Merged
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.34% (837979c) to 44.33% (2f8b48e) by -0.01%.

    FilenameBase (837979c)Merge (2f8b48e)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LruGarbageCollector.java97.27%93.64%-3.64%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vT0QT07TOY.html

@github-actions
Copy link
Contributor

Unit Test Results

   162 files  +   162     162 suites  +162   2m 12s ⏱️ + 2m 12s
1 164 tests +1 164  1 148 ✔️ +1 148  16 💤 +16  0 ❌ ±0 
2 328 runs  +2 328  2 296 ✔️ +2 296  32 💤 +32  0 ❌ ±0 

Results for commit 5d9bfd1. ± Comparison against base commit 837979c.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (837979c)Merge (2f8b48e)Diff
    aar1.36 MB1.36 MB+119 B (+0.0%)
    apk (release)3.95 MB3.95 MB+96 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DQUlX0Cm1j.html

@dconeybe dconeybe marked this pull request as ready for review July 19, 2023 17:57
@dconeybe dconeybe requested a review from milaGGL July 19, 2023 17:57
milaGGL
milaGGL approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 965ac2f into master Jul 20, 2023
@dconeybe dconeybe deleted the dconeybe/BloomFilterMinorCleanup branch July 20, 2023 02:29
@firebase firebase locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore main-merge-ack no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL