Skip to content

Connect PostReleasePlugin with PublishingPlugin #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jul 14, 2023

Per b/274794264,

This connects the PostReleasePlugin plugin with releasing libraries, such that tasks like VersionBumpTask can be executed from the root directory- while only applying to releasing libraries.

@daymxn daymxn requested review from rlazo and davidmotson July 14, 2023 18:47
@daymxn daymxn self-assigned this Jul 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@daymxn daymxn enabled auto-merge (squash) July 14, 2023 18:47
@github-actions
Copy link
Contributor

buildSrc Test Results

28 tests   28 ✔️  1m 19s ⏱️
  6 suites    0 💤
  6 files      0

Results for commit d892ac9.

@github-actions
Copy link
Contributor

Unit Test Results

   818 files  +   656     818 suites  +656   38m 53s ⏱️ + 36m 48s
4 956 tests +3 792  4 935 ✔️ +3 787  21 💤 +  5  0 ±0 
9 821 runs  +7 493  9 779 ✔️ +7 483  42 💤 +10  0 ±0 

Results for commit d892ac9. ± Comparison against base commit c4b5a92.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,592 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NQq38xlvvQ/index.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (c4b5a92) to 50.19% (98c3bff) by +0.01%.

    FilenameBase (c4b5a92)Merge (98c3bff)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    QueryParams.java89.76%90.36%+0.60%
    WebsocketConnection.java32.77%35.03%+2.26%
  • firebase-firestore

    Overall coverage changed from 44.35% (c4b5a92) to 44.34% (98c3bff) by -0.00%.

    FilenameBase (c4b5a92)Merge (98c3bff)Diff
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from 84.14% (c4b5a92) to 84.33% (98c3bff) by +0.19%.

    FilenameBase (c4b5a92)Merge (98c3bff)Diff
    Metadata.java36.51%41.27%+4.76%
    RequestDeduplicator.java80.00%90.00%+10.00%
  • firebase-storage

    Overall coverage changed from 86.16% (c4b5a92) to 85.99% (98c3bff) by -0.17%.

    FilenameBase (c4b5a92)Merge (98c3bff)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    StreamDownloadTask.java88.89%88.41%-0.48%
    UploadTask.java83.17%83.50%+0.33%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vETYLcG9cL.html

@daymxn daymxn merged commit 392da5f into master Jul 14, 2023
@daymxn daymxn deleted the daymon-register-post-release-plugin-with-releasing-libs branch July 14, 2023 23:33
@firebase firebase locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants