Skip to content

Add missing list of valid backend values. #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add missing list of valid backend values. #5163

merged 1 commit into from
Jul 14, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Jul 14, 2023

No description provided.

@rlazo rlazo enabled auto-merge (squash) July 14, 2023 16:31
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-14 18:40:39.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-14 17:18:27.000000000 +0000
@@ -652,14 +652,14 @@
         <h3 class="api-name" id="getInstance()">getInstance</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getInstance()">getInstance</a>()</pre>
         <p>Returns the default <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the default <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>Returns the same instance for all invocations. If no instance exists, initializes a new instance.</p>
+        <p>Returns the same instance for all invocations. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
       </div>
       <div class="api-item"><a name="getInstance-com.google.firebase.FirebaseApp-"></a><a name="getinstance"></a>
         <h3 class="api-name" id="getInstance(com.google.firebase.FirebaseApp)">getInstance</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a>&nbsp;app)</pre>
         <p>Returns the default <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the provided <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>For a given <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>, invocation always returns the same instance. If no instance exists, initializes a new instance.</p>
+        <p>For a given <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>, invocation always returns the same instance. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -676,7 +676,7 @@
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a>&nbsp;app</code></td>
                 <td>
-                  <p>The <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
+                  <p>- The <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
                 </td>
               </tr>
             </tbody>
@@ -687,7 +687,7 @@
         <h3 class="api-name" id="getInstance(java.lang.String)">getInstance</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(java.lang.String)">getInstance</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;database)</pre>
         <p>Returns the <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the default <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>Returns the same instance for all invocations given the same database parameter. If no instance exists, initializes a new instance.</p>
+        <p>Returns the same instance for all invocations given the same database parameter. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -704,7 +704,7 @@
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;database</code></td>
                 <td>
-                  <p>The database ID.</p>
+                  <p>- The name of database.</p>
                 </td>
               </tr>
             </tbody>
@@ -715,7 +715,7 @@
         <h3 class="api-name" id="getInstance(com.google.firebase.FirebaseApp,java.lang.String)">getInstance</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(com.google.firebase.FirebaseApp,java.lang.String)">getInstance</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a>&nbsp;app,&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;database)</pre>
         <p>Returns the <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the provided <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>Returns the same instance for all invocations given the same <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> and database parameter. If no instance exists, initializes a new instance.</p>
+        <p>Returns the same instance for all invocations given the same <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> and database parameter. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -732,13 +732,13 @@
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a>&nbsp;app</code></td>
                 <td>
-                  <p>The <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
+                  <p>- The <code><a href="/docs/reference/android/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/android/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
                 </td>
               </tr>
               <tr>
                 <td><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;database</code></td>
                 <td>
-                  <p>The database ID.</p>
+                  <p>- The name of database.</p>
                 </td>
               </tr>
             </tbody>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-14 18:40:34.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/firestore/FirebaseFirestore.html	2023-07-14 17:18:26.000000000 +0000
@@ -652,14 +652,14 @@
         <h3 class="api-name" id="getInstance()">getInstance</h3>
         <pre class="api-signature no-pretty-print">java-static&nbsp;fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#getInstance()">getInstance</a>():&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></pre>
         <p>Returns the default <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the default <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>Returns the same instance for all invocations. If no instance exists, initializes a new instance.</p>
+        <p>Returns the same instance for all invocations. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
       </div>
       <div class="api-item"><a name="getInstance-com.google.firebase.FirebaseApp-"></a><a name="getinstance"></a>
         <h3 class="api-name" id="getInstance(com.google.firebase.FirebaseApp)">getInstance</h3>
         <pre class="api-signature no-pretty-print">java-static&nbsp;fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(com.google.firebase.FirebaseApp)">getInstance</a>(app:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a>):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></pre>
         <p>Returns the default <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the provided <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>For a given <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>, invocation always returns the same instance. If no instance exists, initializes a new instance.</p>
+        <p>For a given <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>, invocation always returns the same instance. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -676,7 +676,7 @@
               <tr>
                 <td><code>app:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code></td>
                 <td>
-                  <p>The <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
+                  <p>- The <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
                 </td>
               </tr>
             </tbody>
@@ -687,7 +687,7 @@
         <h3 class="api-name" id="getInstance(java.lang.String)">getInstance</h3>
         <pre class="api-signature no-pretty-print">java-static&nbsp;fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(java.lang.String)">getInstance</a>(database:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></pre>
         <p>Returns the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the default <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>Returns the same instance for all invocations given the same database parameter. If no instance exists, initializes a new instance.</p>
+        <p>Returns the same instance for all invocations given the same database parameter. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -704,7 +704,7 @@
               <tr>
                 <td><code>database:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></code></td>
                 <td>
-                  <p>The database ID.</p>
+                  <p>- The name of database.</p>
                 </td>
               </tr>
             </tbody>
@@ -715,7 +715,7 @@
         <h3 class="api-name" id="getInstance(com.google.firebase.FirebaseApp,java.lang.String)">getInstance</h3>
         <pre class="api-signature no-pretty-print">java-static&nbsp;fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html#getInstance(com.google.firebase.FirebaseApp,java.lang.String)">getInstance</a>(app:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a>,&nbsp;database:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></pre>
         <p>Returns the <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance for the provided <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code>. </p>
-        <p>Returns the same instance for all invocations given the same <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> and database parameter. If no instance exists, initializes a new instance.</p>
+        <p>Returns the same instance for all invocations given the same <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> and database parameter. If no instance exists, initializes a new instance with default settings.</p>
         <p>The <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance.</p>
         <div class="devsite-table-wrapper">
           <table class="responsive">
@@ -732,13 +732,13 @@
               <tr>
                 <td><code>app:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code></td>
                 <td>
-                  <p>The <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
+                  <p>- The <code><a href="/docs/reference/kotlin/com/google/firebase/FirebaseApp.html">FirebaseApp</a></code> instance that the returned <code><a href="/docs/reference/kotlin/com/google/firebase/firestore/FirebaseFirestore.html">FirebaseFirestore</a></code> instance is associated with.</p>
                 </td>
               </tr>
               <tr>
                 <td><code>database:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a></code></td>
                 <td>
-                  <p>The database ID.</p>
+                  <p>- The name of database.</p>
                 </td>
               </tr>
             </tbody>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@rlazo rlazo requested a review from daymxn July 14, 2023 16:32
@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

Unit Test Results

   162 files   -    656     162 suites   - 656   1m 55s ⏱️ - 35m 22s
1 164 tests  - 3 792  1 148 ✔️  - 3 787  16 💤  -   5  0 ±0 
2 328 runs   - 7 493  2 296 ✔️  - 7 483  32 💤  - 10  0 ±0 

Results for commit 1d15cc6. ± Comparison against base commit bb0ac26.

@rlazo rlazo merged commit c77027e into master Jul 14, 2023
@rlazo rlazo deleted the addcomment branch July 14, 2023 16:47
@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilebb0ac261eca105DiffSignificant (?)
    p10314 ±9 μs337 ±43 μs+22.1 μs (+7.0%)NO
    p25325 ±11 μs350 ±49 μs+25.5 μs (+7.9%)NO
    p50341 ±14 μs382 ±68 μs+40.8 μs (+12.0%)NO
    p75378 ±27 μs456 ±111 μs+77.8 μs (+20.6%)NO
    p90469 ±75 μs556 ±198 μs+87.2 μs (+18.6%)NO

    20 test runs in comparison
    CommitTest Runs
    bb0ac26
    • 2023-07-14_16:09:00.734918_FcPj
    • 2023-07-14_16:09:00.739703_POxC
    • 2023-07-14_16:09:00.739720_vyxz
    • 2023-07-14_16:09:00.739728_lXxc
    • 2023-07-14_16:09:00.739734_zGGC
    • 2023-07-14_16:09:00.739741_cXOq
    • 2023-07-14_16:09:00.739748_yhUk
    • 2023-07-14_16:09:00.739754_xqZh
    • 2023-07-14_16:09:00.739760_tpJm
    • 2023-07-14_16:09:00.739770_LrLL
    1eca105
    • 2023-07-14_16:54:03.177101_KGoC
    • 2023-07-14_16:54:03.185620_xgKT
    • 2023-07-14_16:54:03.185647_PwrO
    • 2023-07-14_16:54:03.185656_vTll
    • 2023-07-14_16:54:03.185662_VHjX
    • 2023-07-14_16:54:03.185670_NnBB
    • 2023-07-14_16:54:03.185677_uUKU
    • 2023-07-14_16:54:03.185683_PivY
    • 2023-07-14_16:54:03.185689_RPDi
    • 2023-07-14_16:54:03.185700_RITW
    redfin-30
    Percentilebb0ac261eca105DiffSignificant (?)
    p10597 ±25 μs614 ±29 μs+16.7 μs (+2.8%)NO
    p25615 ±29 μs631 ±35 μs+16.3 μs (+2.6%)NO
    p50641 ±36 μs658 ±42 μs+17.2 μs (+2.7%)NO
    p75680 ±49 μs697 ±53 μs+16.6 μs (+2.4%)NO
    p90766 ±158 μs761 ±89 μs-5.44 μs (-0.7%)NO

    20 test runs in comparison
    CommitTest Runs
    bb0ac26
    • 2023-07-14_16:09:00.734918_FcPj
    • 2023-07-14_16:09:00.739703_POxC
    • 2023-07-14_16:09:00.739720_vyxz
    • 2023-07-14_16:09:00.739728_lXxc
    • 2023-07-14_16:09:00.739734_zGGC
    • 2023-07-14_16:09:00.739741_cXOq
    • 2023-07-14_16:09:00.739748_yhUk
    • 2023-07-14_16:09:00.739754_xqZh
    • 2023-07-14_16:09:00.739760_tpJm
    • 2023-07-14_16:09:00.739770_LrLL
    1eca105
    • 2023-07-14_16:54:03.177101_KGoC
    • 2023-07-14_16:54:03.185620_xgKT
    • 2023-07-14_16:54:03.185647_PwrO
    • 2023-07-14_16:54:03.185656_vTll
    • 2023-07-14_16:54:03.185662_VHjX
    • 2023-07-14_16:54:03.185670_NnBB
    • 2023-07-14_16:54:03.185677_uUKU
    • 2023-07-14_16:54:03.185683_PivY
    • 2023-07-14_16:54:03.185689_RPDi
    • 2023-07-14_16:54:03.185700_RITW
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilebb0ac261eca105DiffSignificant (?)
    p10198 ±2 ms208 ±9 ms+10.3 ms (+5.2%)NO
    p25204 ±2 ms215 ±10 ms+10.9 ms (+5.3%)NO
    p50211 ±2 ms224 ±10 ms+12.9 ms (+6.1%)NO
    p75218 ±2 ms234 ±11 ms+16.0 ms (+7.4%)NO
    p90226 ±3 ms250 ±15 ms+23.9 ms (+10.6%)NO

    20 test runs in comparison
    CommitTest Runs
    bb0ac26
    • 2023-07-14_16:09:00.734918_FcPj
    • 2023-07-14_16:09:00.739703_POxC
    • 2023-07-14_16:09:00.739720_vyxz
    • 2023-07-14_16:09:00.739728_lXxc
    • 2023-07-14_16:09:00.739734_zGGC
    • 2023-07-14_16:09:00.739741_cXOq
    • 2023-07-14_16:09:00.739748_yhUk
    • 2023-07-14_16:09:00.739754_xqZh
    • 2023-07-14_16:09:00.739760_tpJm
    • 2023-07-14_16:09:00.739770_LrLL
    1eca105
    • 2023-07-14_16:54:03.177101_KGoC
    • 2023-07-14_16:54:03.185620_xgKT
    • 2023-07-14_16:54:03.185647_PwrO
    • 2023-07-14_16:54:03.185656_vTll
    • 2023-07-14_16:54:03.185662_VHjX
    • 2023-07-14_16:54:03.185670_NnBB
    • 2023-07-14_16:54:03.185677_uUKU
    • 2023-07-14_16:54:03.185683_PivY
    • 2023-07-14_16:54:03.185689_RPDi
    • 2023-07-14_16:54:03.185700_RITW
    redfin-30
    Percentilebb0ac261eca105DiffSignificant (?)
    p10244 ±3 ms267 ±3 ms+22.6 ms (+9.3%)YES
    p25250 ±3 ms274 ±4 ms+23.9 ms (+9.6%)YES
    p50256 ±3 ms282 ±4 ms+26.1 ms (+10.2%)YES
    p75266 ±4 ms292 ±6 ms+26.7 ms (+10.1%)YES
    p90275 ±6 ms307 ±7 ms+32.2 ms (+11.7%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    bb0ac26
    • 2023-07-14_16:09:00.734918_FcPj
    • 2023-07-14_16:09:00.739703_POxC
    • 2023-07-14_16:09:00.739720_vyxz
    • 2023-07-14_16:09:00.739728_lXxc
    • 2023-07-14_16:09:00.739734_zGGC
    • 2023-07-14_16:09:00.739741_cXOq
    • 2023-07-14_16:09:00.739748_yhUk
    • 2023-07-14_16:09:00.739754_xqZh
    • 2023-07-14_16:09:00.739760_tpJm
    • 2023-07-14_16:09:00.739770_LrLL
    1eca105
    • 2023-07-14_16:54:03.177101_KGoC
    • 2023-07-14_16:54:03.185620_xgKT
    • 2023-07-14_16:54:03.185647_PwrO
    • 2023-07-14_16:54:03.185656_vTll
    • 2023-07-14_16:54:03.185662_VHjX
    • 2023-07-14_16:54:03.185670_NnBB
    • 2023-07-14_16:54:03.185677_uUKU
    • 2023-07-14_16:54:03.185683_PivY
    • 2023-07-14_16:54:03.185689_RPDi
    • 2023-07-14_16:54:03.185700_RITW

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gVqTfKLkU0/index.html

@firebase firebase locked and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants