Skip to content

Update messaging versions #5152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2023
Merged

Update messaging versions #5152

merged 4 commits into from
Jul 10, 2023

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (2aef609)Merge (1cb9312)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)

  • firebase-messaging

    TypeBase (2aef609)Merge (1cb9312)Diff
    aar?142 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)

  • firebase-messaging-directboot

    TypeBase (2aef609)Merge (1cb9312)Diff
    aar?5.20 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0Kcnx5pa9E.html

@github-actions
Copy link
Contributor

Unit Test Results

  54 files   -     5    54 suites   - 5   6m 51s ⏱️ + 4m 53s
470 tests  - 512  470 ✔️  - 511  0 💤 ±0  0 ❌  - 1 
940 runs   -   64  940 ✔️  -   63  0 💤 ±0  0 ❌  - 1 

Results for commit db53259. ± Comparison against base commit 2aef609.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from ? (2aef609) to 84.06% (1cb9312) by ?.

    41 individual files with coverage change

    FilenameBase (2aef609)Merge (1cb9312)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?73.57%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.78%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?36.51%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?80.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?73.33%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?88.60%?
    TopicsSyncTask.java?49.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bXGkUfopIn.html

@gsakakihara gsakakihara self-requested a review July 10, 2023 16:09
@VinayGuthal VinayGuthal merged commit 91a1d3e into master Jul 10, 2023
@VinayGuthal VinayGuthal deleted the update_messaging_Versions branch July 10, 2023 16:13
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (1cb9312) and the base commit (2aef609) are not available.

No macrobenchmark data found for the base commit (2aef609). Analysis for the CI merge commit (1cb9312) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZE3y3rJHAI/index.html

VinayGuthal added a commit that referenced this pull request Jul 11, 2023
@VinayGuthal
Update messaging versions (#5152)
d54fb51 
* update versions

* update version

* update messaging versions
@firebase firebase locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gsakakihara gsakakihara gsakakihara approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinayGuthal @google-oss-bot @gsakakihara