update version #5144

VinayGuthal · 2023-07-06T19:26:41Z

No description provided.

github-actions · 2023-07-06T19:26:54Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2023-07-06T19:27:44Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

google-oss-bot · 2023-07-06T19:33:59Z

Coverage Report ¹

Affected Products

firebase-firestore
Overall coverage changed from 44.35% (bf8cb54) to 44.32% (2872966) by -0.02%.
Filename Base (bf8cb54) Merge (2872966) Diff
LruGarbageCollector.java 97.27% 93.64% -3.64%
PatchMutation.java 100.00% 98.39% -1.61%
SetMutation.java 97.22% 94.44% -2.78%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/NFlVlU2h5u.html

github-actions · 2023-07-06T19:35:30Z

Unit Test Results

  162 files +  108   162 suites +108 2m 3s ⏱️ - 4m 49s
1 164 tests +  694 1 148 ✔️ +  678 16 💤 +16 0 ❌ ±0
2 328 runs +1 388 2 296 ✔️ +1 356 32 💤 +32 0 ❌ ±0

Results for commit 9043144. ± Comparison against base commit bf8cb54.

This pull request removes 470 and adds 1164 tests. Note that renamed tests count towards both.

com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testBindsService_oAndTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNoWrappedIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testNullIntent
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_OTargetingO_highPriority
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_fallsBackToBindService
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[19]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[21]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[22]
com.google.firebase.iid.FirebaseInstanceIdWithFcmReceiverRoboTest ‑ testStartsService_notOButTargetingO[23]
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

google-oss-bot · 2023-07-06T19:39:17Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (bf8cb54) Merge (2872966) Diff
aar 1.36 MB 1.36 MB +9 B (+0.0%)
apk (release) 3.95 MB 3.95 MB +4 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/bm8O8rhj5h.html

google-oss-bot · 2023-07-06T20:08:11Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (bf8cb54) and the CI merge commit (2872966)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- bf8cb54: https://storage.googleapis.com/firebase-sdk-metric-reports/rEqvnXX2YF/index.html
- 2872966: https://storage.googleapis.com/firebase-sdk-metric-reports/UBnEjhBxqq/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`bf8cb54`	`2872966`	Diff	Significant (?)
p10	315 ±21 μs	324 ±14 μs	+9.78 μs (+3.1%)	NO
p25	327 ±27 μs	337 ±17 μs	+9.89 μs (+3.0%)	NO
p50	350 ±49 μs	368 ±41 μs	+18.7 μs (+5.3%)	NO
p75	382 ±72 μs	447 ±92 μs	+64.3 μs (+16.8%)	NO
p90	450 ±117 μs	548 ±117 μs	+97.8 μs (+21.7%)	NO

20 test runs in comparison

Commit	Test Runs
`bf8cb54`	2023-07-06_17:20:40.664081_eWEQ 2023-07-06_17:20:40.668411_mlIK 2023-07-06_17:20:40.668435_GUMY 2023-07-06_17:20:40.668445_CrbJ 2023-07-06_17:20:40.668452_wkLc 2023-07-06_17:20:40.668460_gcsa 2023-07-06_17:20:40.668467_lSkQ 2023-07-06_17:20:40.668474_kAnM 2023-07-06_17:20:40.668481_sRlB 2023-07-06_17:20:40.668489_nURq
`2872966`	2023-07-06_19:48:47.416761_YhXx 2023-07-06_19:48:47.421647_iVLI 2023-07-06_19:48:47.421668_HZIa 2023-07-06_19:48:47.421677_VVtP 2023-07-06_19:48:47.421684_WGBu 2023-07-06_19:48:47.421692_xcOO 2023-07-06_19:48:47.421698_Qrgs 2023-07-06_19:48:47.421705_cjts 2023-07-06_19:48:47.421711_MkXD 2023-07-06_19:48:47.421718_qMoO

redfin-30

Percentile	`bf8cb54`	`2872966`	Diff	Significant (?)
p10	595 ±27 μs	630 ±45 μs	+35.4 μs (+6.0%)	NO
p25	609 ±28 μs	646 ±49 μs	+37.0 μs (+6.1%)	NO
p50	633 ±33 μs	671 ±54 μs	+37.4 μs (+5.9%)	NO
p75	667 ±43 μs	707 ±63 μs	+39.5 μs (+5.9%)	NO
p90	710 ±67 μs	769 ±107 μs	+59.0 μs (+8.3%)	NO

20 test runs in comparison

Commit	Test Runs
`bf8cb54`	2023-07-06_17:20:40.664081_eWEQ 2023-07-06_17:20:40.668411_mlIK 2023-07-06_17:20:40.668435_GUMY 2023-07-06_17:20:40.668445_CrbJ 2023-07-06_17:20:40.668452_wkLc 2023-07-06_17:20:40.668460_gcsa 2023-07-06_17:20:40.668467_lSkQ 2023-07-06_17:20:40.668474_kAnM 2023-07-06_17:20:40.668481_sRlB 2023-07-06_17:20:40.668489_nURq
`2872966`	2023-07-06_19:48:47.416761_YhXx 2023-07-06_19:48:47.421647_iVLI 2023-07-06_19:48:47.421668_HZIa 2023-07-06_19:48:47.421677_VVtP 2023-07-06_19:48:47.421684_WGBu 2023-07-06_19:48:47.421692_xcOO 2023-07-06_19:48:47.421698_Qrgs 2023-07-06_19:48:47.421705_cjts 2023-07-06_19:48:47.421711_MkXD 2023-07-06_19:48:47.421718_qMoO

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`bf8cb54`	`2872966`	Diff	Significant (?)
p10	200 ±4 ms	203 ±4 ms	+2.75 ms (+1.4%)	NO
p25	206 ±5 ms	209 ±3 ms	+3.35 ms (+1.6%)	NO
p50	213 ±5 ms	218 ±3 ms	+4.18 ms (+2.0%)	NO
p75	221 ±4 ms	228 ±3 ms	+7.10 ms (+3.2%)	NO
p90	229 ±5 ms	240 ±7 ms	+11.0 ms (+4.8%)	NO

20 test runs in comparison

Commit	Test Runs
`bf8cb54`	2023-07-06_17:20:40.664081_eWEQ 2023-07-06_17:20:40.668411_mlIK 2023-07-06_17:20:40.668435_GUMY 2023-07-06_17:20:40.668445_CrbJ 2023-07-06_17:20:40.668452_wkLc 2023-07-06_17:20:40.668460_gcsa 2023-07-06_17:20:40.668467_lSkQ 2023-07-06_17:20:40.668474_kAnM 2023-07-06_17:20:40.668481_sRlB 2023-07-06_17:20:40.668489_nURq
`2872966`	2023-07-06_19:48:47.416761_YhXx 2023-07-06_19:48:47.421647_iVLI 2023-07-06_19:48:47.421668_HZIa 2023-07-06_19:48:47.421677_VVtP 2023-07-06_19:48:47.421684_WGBu 2023-07-06_19:48:47.421692_xcOO 2023-07-06_19:48:47.421698_Qrgs 2023-07-06_19:48:47.421705_cjts 2023-07-06_19:48:47.421711_MkXD 2023-07-06_19:48:47.421718_qMoO

redfin-30

Percentile	`bf8cb54`	`2872966`	Diff	Significant (?)
p10	243 ±3 ms	266 ±6 ms	+22.4 ms (+9.2%)	MAYBE
p25	250 ±3 ms	272 ±7 ms	+22.5 ms (+9.0%)	MAYBE
p50	257 ±4 ms	280 ±7 ms	+23.4 ms (+9.1%)	MAYBE
p75	266 ±5 ms	290 ±7 ms	+24.3 ms (+9.2%)	MAYBE
p90	277 ±6 ms	302 ±8 ms	+25.4 ms (+9.2%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`bf8cb54`	2023-07-06_17:20:40.664081_eWEQ 2023-07-06_17:20:40.668411_mlIK 2023-07-06_17:20:40.668435_GUMY 2023-07-06_17:20:40.668445_CrbJ 2023-07-06_17:20:40.668452_wkLc 2023-07-06_17:20:40.668460_gcsa 2023-07-06_17:20:40.668467_lSkQ 2023-07-06_17:20:40.668474_kAnM 2023-07-06_17:20:40.668481_sRlB 2023-07-06_17:20:40.668489_nURq
`2872966`	2023-07-06_19:48:47.416761_YhXx 2023-07-06_19:48:47.421647_iVLI 2023-07-06_19:48:47.421668_HZIa 2023-07-06_19:48:47.421677_VVtP 2023-07-06_19:48:47.421684_WGBu 2023-07-06_19:48:47.421692_xcOO 2023-07-06_19:48:47.421698_Qrgs 2023-07-06_19:48:47.421705_cjts 2023-07-06_19:48:47.421711_MkXD 2023-07-06_19:48:47.421718_qMoO

https://storage.googleapis.com/firebase-sdk-metric-reports/3MXwZ8NVCP/index.html

update version

9043144

VinayGuthal requested a review from wu-hui July 6, 2023 19:26

google-oss-bot added the size/XS label Jul 6, 2023

wu-hui approved these changes Jul 6, 2023

View reviewed changes

wu-hui merged commit 593f4cd into master Jul 6, 2023

wu-hui deleted the firestore_version_update branch July 6, 2023 19:49

VinayGuthal added a commit that referenced this pull request Jul 6, 2023

update version (#5144)

dd370cb

firebase locked and limited conversation to collaborators Aug 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

update version #5144

update version #5144

Uh oh!

VinayGuthal commented Jul 6, 2023

Uh oh!

github-actions bot commented Jul 6, 2023 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 6, 2023

Uh oh!

google-oss-bot commented Jul 6, 2023

`firebase-firestore`

Uh oh!

github-actions bot commented Jul 6, 2023

Uh oh!

google-oss-bot commented Jul 6, 2023

`firebase-firestore`

Uh oh!

google-oss-bot commented Jul 6, 2023

`fire-fst`

`timeToInitialDisplay`

Uh oh!

Uh oh!

update version #5144

update version #5144

Uh oh!

Conversation

VinayGuthal commented Jul 6, 2023

Uh oh!

github-actions bot commented Jul 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 PRs merging into main branch

Uh oh!

google-oss-bot commented Jul 6, 2023

Uh oh!

google-oss-bot commented Jul 6, 2023

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented Jul 6, 2023

Unit Test Results

Uh oh!

google-oss-bot commented Jul 6, 2023

Size Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

google-oss-bot commented Jul 6, 2023

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

Uh oh!

Uh oh!

github-actions bot commented Jul 6, 2023 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

Size Report ¹

`firebase-firestore`

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`