Skip to content

Change send deprecation link to hyperlinked text. #5140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

gsakakihara
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/messaging/FirebaseMessaging.html	2023-07-06 16:07:50.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/messaging/FirebaseMessaging.html	2023-07-06 16:03:08.000000000 +0000
@@ -278,7 +278,7 @@
         <h3 class="api-name" id="send(com.google.firebase.messaging.RemoteMessage)">send</h3>
         <pre class="api-signature no-pretty-print">public&nbsp;void&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/messaging/FirebaseMessaging.html#send(com.google.firebase.messaging.RemoteMessage)">send</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/messaging/RemoteMessage.html">RemoteMessage</a>&nbsp;message)</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
-          <p>FCM upstream is deprecated and will be decommissioned in June 2024. More details can be found in <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">https://firebase.google.com/support/faq#fcm-23-deprecation</a></p>
+          <p>FCM upstream is deprecated and will be decommissioned in June 2024. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Sends <code>message</code> upstream to your app server. </p>
         <p>When there is an active connection the message will be sent immediately, otherwise the message will be queued up to the time to live (TTL) set in the message.</p>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/messaging/FirebaseMessaging.html	2023-07-06 16:07:50.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/messaging/FirebaseMessaging.html	2023-07-06 16:03:08.000000000 +0000
@@ -278,7 +278,7 @@
         <h3 class="api-name" id="send(com.google.firebase.messaging.RemoteMessage)">send</h3>
         <pre class="api-signature no-pretty-print">fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/messaging/FirebaseMessaging.html#send(com.google.firebase.messaging.RemoteMessage)">send</a></del></span>(message:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/messaging/RemoteMessage.html">RemoteMessage</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
-          <p>FCM upstream is deprecated and will be decommissioned in June 2024. More details can be found in <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">https://firebase.google.com/support/faq#fcm-23-deprecation</a></p>
+          <p>FCM upstream is deprecated and will be decommissioned in June 2024. Learn more in the <a href="https://firebase.google.com/support/faq#fcm-23-deprecation">FAQ about FCM features deprecated in June 2023</a>.</p>
         </aside>
         <p>Sends <code>message</code> upstream to your app server. </p>
         <p>When there is an active connection the message will be sent immediately, otherwise the message will be queued up to the time to live (TTL) set in the message.</p>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from ? (52ca562) to 84.18% (f4c3c31) by ?.

    41 individual files with coverage change

    FilenameBase (52ca562)Merge (f4c3c31)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?73.13%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.38%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?41.27%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?73.33%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?88.60%?
    TopicsSyncTask.java?49.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mq6tyKf4qP.html

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Unit Test Results

  54 files   -    108    54 suites   - 108   6m 55s ⏱️ + 4m 32s
470 tests  -    694  470 ✔️  -    678  0 💤  - 16  0 ±0 
940 runs   - 1 388  940 ✔️  - 1 356  0 💤  - 32  0 ±0 

Results for commit bd8d0e4. ± Comparison against base commit 52ca562.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (52ca562)Merge (f4c3c31)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.66 kB? (?)
  • firebase-messaging

    TypeBase (52ca562)Merge (f4c3c31)Diff
    aar?142 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5zUCRG5zzS.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fcm

    DeviceStatisticsDistributions
    oriole-32
    Percentile52ca562f4c3c31DiffSignificant (?)
    p101.13 ±1 ms1.01 ±0.6 ms-115 μs (-10.2%)NO
    p251.20 ±1 ms1.06 ±0.7 ms-137 μs (-11.4%)NO
    p501.34 ±2 ms1.19 ±0.7 ms-148 μs (-11.0%)NO
    p751.61 ±2 ms1.41 ±0.8 ms-201 μs (-12.5%)NO
    p901.96 ±2 ms1.75 ±1 ms-211 μs (-10.8%)NO

    20 test runs in comparison
    CommitTest Runs
    52ca562
    • 2023-07-06_15:58:33.434899_Tjrs
    • 2023-07-06_15:58:33.437661_zIJk
    • 2023-07-06_15:58:33.437673_cRhv
    • 2023-07-06_15:58:33.437679_ecox
    • 2023-07-06_15:58:33.437684_ENCk
    • 2023-07-06_15:58:33.437690_zchx
    • 2023-07-06_15:58:33.437698_djhD
    • 2023-07-06_15:58:33.437704_ekcG
    • 2023-07-06_15:58:33.437709_Jeyx
    • 2023-07-06_15:58:33.437714_khbm
    f4c3c31
    • 2023-07-06_16:14:01.865046_BRCm
    • 2023-07-06_16:14:01.868904_uoTz
    • 2023-07-06_16:14:01.868940_LjgY
    • 2023-07-06_16:14:01.868951_uaGZ
    • 2023-07-06_16:14:01.868959_eQRG
    • 2023-07-06_16:14:01.868966_QkCA
    • 2023-07-06_16:14:01.868980_AmrY
    • 2023-07-06_16:14:01.868987_PnYC
    • 2023-07-06_16:14:01.868993_TfYV
    • 2023-07-06_16:14:01.869000_sTns
    redfin-30
    Percentile52ca562f4c3c31DiffSignificant (?)
    p101.59 ±2 ms2.61 ±3 ms+1.03 ms (+64.7%)NO
    p251.73 ±2 ms3.00 ±3 ms+1.27 ms (+73.1%)NO
    p501.95 ±2 ms3.46 ±4 ms+1.51 ms (+77.1%)NO
    p752.26 ±2 ms4.24 ±5 ms+1.98 ms (+87.5%)NO
    p902.98 ±3 ms5.46 ±6 ms+2.49 ms (+83.5%)NO

    20 test runs in comparison
    CommitTest Runs
    52ca562
    • 2023-07-06_15:58:33.434899_Tjrs
    • 2023-07-06_15:58:33.437661_zIJk
    • 2023-07-06_15:58:33.437673_cRhv
    • 2023-07-06_15:58:33.437679_ecox
    • 2023-07-06_15:58:33.437684_ENCk
    • 2023-07-06_15:58:33.437690_zchx
    • 2023-07-06_15:58:33.437698_djhD
    • 2023-07-06_15:58:33.437704_ekcG
    • 2023-07-06_15:58:33.437709_Jeyx
    • 2023-07-06_15:58:33.437714_khbm
    f4c3c31
    • 2023-07-06_16:14:01.865046_BRCm
    • 2023-07-06_16:14:01.868904_uoTz
    • 2023-07-06_16:14:01.868940_LjgY
    • 2023-07-06_16:14:01.868951_uaGZ
    • 2023-07-06_16:14:01.868959_eQRG
    • 2023-07-06_16:14:01.868966_QkCA
    • 2023-07-06_16:14:01.868980_AmrY
    • 2023-07-06_16:14:01.868987_PnYC
    • 2023-07-06_16:14:01.868993_TfYV
    • 2023-07-06_16:14:01.869000_sTns
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile52ca562f4c3c31DiffSignificant (?)
    p10200 ±3 ms206 ±5 ms+6.74 ms (+3.4%)NO
    p25206 ±3 ms213 ±6 ms+7.54 ms (+3.7%)NO
    p50212 ±4 ms222 ±7 ms+9.62 ms (+4.5%)NO
    p75221 ±5 ms231 ±8 ms+10.2 ms (+4.6%)NO
    p90228 ±4 ms242 ±9 ms+14.1 ms (+6.2%)NO

    20 test runs in comparison
    CommitTest Runs
    52ca562
    • 2023-07-06_15:58:33.434899_Tjrs
    • 2023-07-06_15:58:33.437661_zIJk
    • 2023-07-06_15:58:33.437673_cRhv
    • 2023-07-06_15:58:33.437679_ecox
    • 2023-07-06_15:58:33.437684_ENCk
    • 2023-07-06_15:58:33.437690_zchx
    • 2023-07-06_15:58:33.437698_djhD
    • 2023-07-06_15:58:33.437704_ekcG
    • 2023-07-06_15:58:33.437709_Jeyx
    • 2023-07-06_15:58:33.437714_khbm
    f4c3c31
    • 2023-07-06_16:14:01.865046_BRCm
    • 2023-07-06_16:14:01.868904_uoTz
    • 2023-07-06_16:14:01.868940_LjgY
    • 2023-07-06_16:14:01.868951_uaGZ
    • 2023-07-06_16:14:01.868959_eQRG
    • 2023-07-06_16:14:01.868966_QkCA
    • 2023-07-06_16:14:01.868980_AmrY
    • 2023-07-06_16:14:01.868987_PnYC
    • 2023-07-06_16:14:01.868993_TfYV
    • 2023-07-06_16:14:01.869000_sTns
    redfin-30
    Percentile52ca562f4c3c31DiffSignificant (?)
    p10243 ±3 ms265 ±4 ms+22.0 ms (+9.0%)YES
    p25248 ±3 ms271 ±4 ms+22.4 ms (+9.0%)YES
    p50256 ±3 ms279 ±5 ms+23.0 ms (+9.0%)YES
    p75264 ±4 ms288 ±6 ms+24.0 ms (+9.1%)MAYBE
    p90274 ±6 ms301 ±9 ms+27.2 ms (+9.9%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    52ca562
    • 2023-07-06_15:58:33.434899_Tjrs
    • 2023-07-06_15:58:33.437661_zIJk
    • 2023-07-06_15:58:33.437673_cRhv
    • 2023-07-06_15:58:33.437679_ecox
    • 2023-07-06_15:58:33.437684_ENCk
    • 2023-07-06_15:58:33.437690_zchx
    • 2023-07-06_15:58:33.437698_djhD
    • 2023-07-06_15:58:33.437704_ekcG
    • 2023-07-06_15:58:33.437709_Jeyx
    • 2023-07-06_15:58:33.437714_khbm
    f4c3c31
    • 2023-07-06_16:14:01.865046_BRCm
    • 2023-07-06_16:14:01.868904_uoTz
    • 2023-07-06_16:14:01.868940_LjgY
    • 2023-07-06_16:14:01.868951_uaGZ
    • 2023-07-06_16:14:01.868959_eQRG
    • 2023-07-06_16:14:01.868966_QkCA
    • 2023-07-06_16:14:01.868980_AmrY
    • 2023-07-06_16:14:01.868987_PnYC
    • 2023-07-06_16:14:01.868993_TfYV
    • 2023-07-06_16:14:01.869000_sTns

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ROy0QroP4F/index.html

@gsakakihara gsakakihara merged commit bf8cb54 into master Jul 6, 2023
@gsakakihara gsakakihara deleted the gsakakihara/javadoc_link branch July 6, 2023 16:57
@firebase firebase locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants