Skip to content

Fail Firestore client if we can't establish SSL connection #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 19, 2019
Merged

Fail Firestore client if we can't establish SSL connection #508

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
393bbd5
Fail Firestore client if we can't establish SSL connection
schmidt-sebastian Jun 10, 2019
48363ca
Crash UI Thread instead
schmidt-sebastian Jun 11, 2019
de30749
Unused import
schmidt-sebastian Jun 11, 2019
a4ff139
Merge
schmidt-sebastian Jun 11, 2019
4535883
Add API Level check
schmidt-sebastian Jun 11, 2019
b863ed2
Update CHANGELOG.md
schmidt-sebastian Jun 19, 2019
b188eae
Remove empty line
schmidt-sebastian Jun 19, 2019
288ec66
Merge branch 'master' into mrschmidt-sslerror
schmidt-sebastian Jun 19, 2019
d355738
Using AndroidX
schmidt-sebastian Jun 19, 2019
080792b
Fix typo
schmidt-sebastian Jun 19, 2019
da32187
Update CHANGELOG.md
schmidt-sebastian Jun 19, 2019
fc58b41
Update CHANGELOG.md
schmidt-sebastian Jun 19, 2019
b096ac4
Merge branch 'master' into mrschmidt-sslerror
schmidt-sebastian Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions firebase-firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
- [feature] Added `clearPersistence()`, which clears the persistent storage
including pending writes and cached documents. This is intended to help
write reliable tests (https://github.com/firebase/firebase-js-sdk/issues/449).
- [changed] Firestore now provides a clear error message when it fails to load
SSL Ciphers during a connection attempt.
- [changed] Instead of failing silently, Firestore now crahses the client app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: crahses -> crashes

Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian Jun 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks :)

if it fails to load SSL Ciphers. To avoid these crashes, you must bundle
Conscrupt if you support non-GMSCore devices on Android KitKat or JellyBean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another typo: Conscrypt. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already fixed: 080792b

(see https://github.com/grpc/grpc-java/blob/master/SECURITY.md#tls-on-android).

# 19.0.1
- [fixed] Fixed an issue that prevented schema migrations for clients with
Expand Down