Migrate from is(Not)SameAs to is(Not)SameInstanceAs.

[cpovirk]

They behave identically, and the old names are being removed.

This requires updating to Truth 0.44 or higher, so I've gone straight to 0.45.

[google-oss-bot]

Hi @cpovirk. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wilhuff]

/ok-to-test

[wilhuff]

This failed because there were references to isSame in Kotlin?

e.g.

e: /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-firestore/ktx/src/test/kotlin/com/google/firebase/firestore/ktx/FirestoreTests.kt: (78, 40): Unresolved reference: isSameAs
e: /home/prow/go/src/github.com/firebase/firebase-android-sdk/firebase-firestore/ktx/src/test/kotlin/com/google/firebase/firestore/ktx/FirestoreTests.kt: (84, 45): Unresolved reference: isSameAs

[cpovirk]

Almost certainly -- thanks! I'd been waiting for https://android-ci.firebaseopensource.com/view/gcs/android-ci/pr-logs/pull/firebase_firebase-android-sdk/505/check-changed/1137094697949335553/ to load.

/test check-changed

[cpovirk]

Oh, I found the "Raw build-log.txt" link. And yes, if you were in any doubt, you're correct :)

[cpovirk]

...and I didn't search for all Kotlin references, so I missed some... in fact, the exact ones you pointed out. Fixed now, I hope.

[cpovirk]

/test check-changed

[cpovirk]

Phew, passed this time :)

[cpovirk]

Resolved merge conflict. (d9ed980 had also updated Truth, though only to 0.44. I can use 0.44 in my PR if you prefer.)

[vkryachko]

/test all

[vkryachko]

I've re-scheduled presubmits once again as our repo has just migrated to androidx so I just want to make sure your PR still builds fine. Please wait for them to succeed before merging.

[cpovirk]

Thanks. Looks like all is well. I don't have write access, so I can't do any damage, but someone else can merge when desired :)