Skip to content

Include auto-value-annotations as compileOnly #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dlew
Copy link

@dlew dlew commented Jun 6, 2019

auto-value-annotations are only needed at compile-time,
and including them as part of the api can mess up other
builds that only include the annotations at compile-time.

Also bumped it up to the latest vesion (1.6.5)

Fixes #317

auto-value-annotations are only needed at compile-time,
and including them as part of the api can mess up other
builds that only include the annotations at compile-time.

Also bumped it up to the latest vesion (1.6.5)
@google-oss-bot
Copy link
Contributor

Hi @dlew. Thanks for your PR.

I'm waiting for a firebase member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlew
Copy link
Author

dlew commented Apr 7, 2020

We no longer use auto-value anymore, so this is sort of a moot point and I'm not going to bother getting this working again.

@dlew dlew closed this Apr 7, 2020
@dlew dlew deleted the dlew/fix-auto-value-annotations branch April 7, 2020 19:04
@firebase firebase locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase-common: version conflict with auto-value-annotations
4 participants