Skip to content

Refactor PomValidator #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Refactor PomValidator #4924

merged 4 commits into from
Apr 24, 2023

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Apr 21, 2023

Per b/279212956,

This takes advantage of the new extension methods provided in the recently merged #4879, and refactors the PomValidator task to take advantage of them.

Additionally, this fixes b/279212781 - providing documentation for the PomValidator task.

@daymxn daymxn requested review from rlazo and VinayGuthal April 21, 2023 21:33
@daymxn daymxn self-assigned this Apr 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

buildSrc Test Results

26 tests   26 ✔️  1m 37s ⏱️
  5 suites    0 💤
  5 files      0

Results for commit 925ad77.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023

Unit Test Results

   763 files  +   735     763 suites  +735   32m 14s ⏱️ + 31m 42s
4 865 tests +4 754  4 843 ✔️ +4 732  21 💤 +21  1 +1 
9 168 runs  +8 946  9 125 ✔️ +8 903  42 💤 +42  1 +1 

For more details on these failures, see this check.

Results for commit 925ad77. ± Comparison against base commit 7509feb.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 21, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 21, 2023

Startup Time Report 1

The report is too large (117,075 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/bCJiTdyUKU/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 21, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.19% (7509feb) to 50.18% (a0c0cc3) by -0.01%.

    FilenameBase (7509feb)Merge (a0c0cc3)Diff
    DefaultPersistenceManager.java75.73%74.76%-0.97%
  • firebase-firestore

    Overall coverage changed from 44.14% (7509feb) to 44.14% (a0c0cc3) by -0.00%.

    FilenameBase (7509feb)Merge (a0c0cc3)Diff
    DeleteMutation.java95.24%90.48%-4.76%
  • firebase-messaging

    Overall coverage changed from 85.18% (7509feb) to 85.22% (a0c0cc3) by +0.04%.

    FilenameBase (7509feb)Merge (a0c0cc3)Diff
    FirebaseMessaging.java77.09%76.21%-0.88%
    MessagingAnalytics.java81.38%81.78%+0.40%
    RequestDeduplicator.java80.00%90.00%+10.00%
  • firebase-storage

    Overall coverage changed from 85.90% (7509feb) to 86.21% (a0c0cc3) by +0.30%.

    FilenameBase (7509feb)Merge (a0c0cc3)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.69%83.99%+0.30%
    UploadTask.java81.79%83.11%+1.32%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/oJ0v57UdjL.html

@daymxn daymxn requested a review from rlazo April 24, 2023 19:20
@daymxn daymxn enabled auto-merge (squash) April 24, 2023 19:56
@daymxn daymxn disabled auto-merge April 24, 2023 22:57
@daymxn daymxn merged commit dfad414 into master Apr 24, 2023
@daymxn daymxn deleted the daymon-refactor-pomvalidator branch April 24, 2023 22:57
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants