Skip to content

Backporting reviewer suggested comments from cl/214509458 #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions firebase-firestore/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
# 17.1.1
- [fixed] Fixed an issue where the first `get()` call made after being offline
could incorrectly return cached data without attempting to reach the backend.
- [changed] Changed `get()` to only make 1 attempt to reach the backend before
returning cached data, potentially reducing delays while offline. Previously
it would make 2 attempts, to work around a backend bug.
- [fixed] Fixed an issue that caused us to drop empty objects from calls to
`set(..., SetOptions.merge())`.
- [fixed] Ensure printf style templates are compile time constants. Previously,
some were influenced by error messages. When those error messages contained
'%p' (amongst other possibilities), String.format() would throw an exception.
- [changed] Some SDK errors that represent common mistakes (such as permission
denied or a missing index) will automatically be logged as a warning in
addition to being surfaced via the API.
- [changed] Changed `get()` to only make one attempt to reach the backend before
returning cached data, potentially reducing delays while offline.
- [fixed] Fixed an issue that caused Firebase to drop empty objects from calls
to `set(..., SetOptions.merge())`.
- [fixed] Updated printf-style templates to ensure that they're compile time
constants. Previously, some were influenced by error messages. When those
error messages contained `%p` or other, related tokens, `String.format()`
would throw an exception.
- [changed] Some SDK errors that represent common mistakes, like permission
errors or missing indexes, are automatically be logged as warnings in addition
to being surfaced via the API.

# 17.1.0
- [feature] Added `FieldValue.arrayUnion()` and `FieldValue.arrayRemove()` to
Expand Down