Skip to content

Use >API30 for crashlytics ndk device testing #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

Use >API30 for crashlytics ndk device testing #4814

merged 1 commit into from
Mar 23, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 23, 2023 •
edited
Loading

Fixes instrumentation tests for crashlytics-ndk

@rlazo rlazo requested review from daymxn and emilypgoogle March 23, 2023 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (c51a44f) and merge commit (91071f5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hg6NICvpoM.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (c51a44f) and merge commit (91071f5).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2fm8QKAqJ2.html

@github-actions
Copy link
Contributor

Unit Test Results

0 files   -   6  0 suites   - 6   0s ⏱️ -17s
0 tests  - 18  0 ✔️  - 18  0 💤 ±0  0 ❌ ±0 
0 runs   - 36  0 ✔️  - 36  0 💤 ±0  0 ❌ ±0 

Results for commit b1174a7. ± Comparison against base commit c51a44f.

daymxn
daymxn approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentilec51a44f91071f5DiffSignificant (?)
    p1012.4 ±4 ms11.4 ±4 ms-990 μs (-8.0%)NO
    p2513.3 ±5 ms12.1 ±4 ms-1.16 ms (-8.7%)NO
    p5014.6 ±5 ms13.2 ±4 ms-1.42 ms (-9.7%)NO
    p7516.2 ±6 ms14.7 ±4 ms-1.52 ms (-9.4%)NO
    p9018.1 ±6 ms16.7 ±4 ms-1.46 ms (-8.0%)NO

    20 test runs in comparison
    CommitTest Runs
    c51a44f
    • 2023-03-22_19:34:13.464868_uxiY
    • 2023-03-22_19:34:13.467829_lLeL
    • 2023-03-22_19:34:13.467839_SXYW
    • 2023-03-22_19:34:13.467845_dLRb
    • 2023-03-22_19:34:13.467851_scBj
    • 2023-03-22_19:34:13.467856_ScJQ
    • 2023-03-22_19:34:13.467862_Lfsj
    • 2023-03-22_19:34:13.467868_EuUV
    • 2023-03-22_19:34:13.467873_BMXE
    • 2023-03-22_19:34:13.467878_svwx
    91071f5
    • 2023-03-23_15:56:07.593786_HKjw
    • 2023-03-23_15:56:07.603061_EOYZ
    • 2023-03-23_15:56:07.603075_PjRU
    • 2023-03-23_15:56:07.603218_zGQn
    • 2023-03-23_15:56:07.603225_AspF
    • 2023-03-23_15:56:07.603236_bFIN
    • 2023-03-23_15:56:07.603242_BKVj
    • 2023-03-23_15:56:07.603247_IPwX
    • 2023-03-23_15:56:07.603253_wejN
    • 2023-03-23_15:56:07.603258_gMJh
    redfin-30
    Percentilec51a44f91071f5DiffSignificant (?)
    p1011.6 ±3 ms12.8 ±5 ms+1.20 ms (+10.3%)NO
    p2512.3 ±4 ms13.6 ±6 ms+1.34 ms (+10.9%)NO
    p5013.3 ±4 ms14.8 ±7 ms+1.41 ms (+10.6%)NO
    p7514.7 ±5 ms16.5 ±8 ms+1.84 ms (+12.5%)NO
    p9016.7 ±7 ms19.4 ±9 ms+2.76 ms (+16.6%)NO

    20 test runs in comparison
    CommitTest Runs
    c51a44f
    • 2023-03-22_19:34:13.464868_uxiY
    • 2023-03-22_19:34:13.467829_lLeL
    • 2023-03-22_19:34:13.467839_SXYW
    • 2023-03-22_19:34:13.467845_dLRb
    • 2023-03-22_19:34:13.467851_scBj
    • 2023-03-22_19:34:13.467856_ScJQ
    • 2023-03-22_19:34:13.467862_Lfsj
    • 2023-03-22_19:34:13.467868_EuUV
    • 2023-03-22_19:34:13.467873_BMXE
    • 2023-03-22_19:34:13.467878_svwx
    91071f5
    • 2023-03-23_15:56:07.593786_HKjw
    • 2023-03-23_15:56:07.603061_EOYZ
    • 2023-03-23_15:56:07.603075_PjRU
    • 2023-03-23_15:56:07.603218_zGQn
    • 2023-03-23_15:56:07.603225_AspF
    • 2023-03-23_15:56:07.603236_bFIN
    • 2023-03-23_15:56:07.603242_BKVj
    • 2023-03-23_15:56:07.603247_IPwX
    • 2023-03-23_15:56:07.603253_wejN
    • 2023-03-23_15:56:07.603258_gMJh

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilec51a44f91071f5DiffSignificant (?)
    p10197 ±8 ms198 ±5 ms+1.10 ms (+0.6%)NO
    p25204 ±9 ms205 ±6 ms+165 μs (+0.1%)NO
    p50216 ±19 ms213 ±6 ms-3.26 ms (-1.5%)NO
    p75229 ±29 ms223 ±10 ms-6.47 ms (-2.8%)NO
    p90239 ±32 ms237 ±16 ms-2.95 ms (-1.2%)NO

    20 test runs in comparison
    CommitTest Runs
    c51a44f
    • 2023-03-22_19:34:13.464868_uxiY
    • 2023-03-22_19:34:13.467829_lLeL
    • 2023-03-22_19:34:13.467839_SXYW
    • 2023-03-22_19:34:13.467845_dLRb
    • 2023-03-22_19:34:13.467851_scBj
    • 2023-03-22_19:34:13.467856_ScJQ
    • 2023-03-22_19:34:13.467862_Lfsj
    • 2023-03-22_19:34:13.467868_EuUV
    • 2023-03-22_19:34:13.467873_BMXE
    • 2023-03-22_19:34:13.467878_svwx
    91071f5
    • 2023-03-23_15:56:07.593786_HKjw
    • 2023-03-23_15:56:07.603061_EOYZ
    • 2023-03-23_15:56:07.603075_PjRU
    • 2023-03-23_15:56:07.603218_zGQn
    • 2023-03-23_15:56:07.603225_AspF
    • 2023-03-23_15:56:07.603236_bFIN
    • 2023-03-23_15:56:07.603242_BKVj
    • 2023-03-23_15:56:07.603247_IPwX
    • 2023-03-23_15:56:07.603253_wejN
    • 2023-03-23_15:56:07.603258_gMJh
    redfin-30
    Percentilec51a44f91071f5DiffSignificant (?)
    p10231 ±4 ms253 ±5 ms+21.9 ms (+9.5%)MAYBE
    p25237 ±4 ms260 ±5 ms+22.9 ms (+9.7%)MAYBE
    p50244 ±4 ms267 ±5 ms+22.7 ms (+9.3%)MAYBE
    p75252 ±5 ms277 ±6 ms+25.0 ms (+9.9%)MAYBE
    p90261 ±5 ms290 ±7 ms+29.2 ms (+11.2%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    c51a44f
    • 2023-03-22_19:34:13.464868_uxiY
    • 2023-03-22_19:34:13.467829_lLeL
    • 2023-03-22_19:34:13.467839_SXYW
    • 2023-03-22_19:34:13.467845_dLRb
    • 2023-03-22_19:34:13.467851_scBj
    • 2023-03-22_19:34:13.467856_ScJQ
    • 2023-03-22_19:34:13.467862_Lfsj
    • 2023-03-22_19:34:13.467868_EuUV
    • 2023-03-22_19:34:13.467873_BMXE
    • 2023-03-22_19:34:13.467878_svwx
    91071f5
    • 2023-03-23_15:56:07.593786_HKjw
    • 2023-03-23_15:56:07.603061_EOYZ
    • 2023-03-23_15:56:07.603075_PjRU
    • 2023-03-23_15:56:07.603218_zGQn
    • 2023-03-23_15:56:07.603225_AspF
    • 2023-03-23_15:56:07.603236_bFIN
    • 2023-03-23_15:56:07.603242_BKVj
    • 2023-03-23_15:56:07.603247_IPwX
    • 2023-03-23_15:56:07.603253_wejN
    • 2023-03-23_15:56:07.603258_gMJh

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0ZJwYM20Jl/index.html

@rlazo rlazo merged commit 687e079 into master Mar 23, 2023
@rlazo rlazo deleted the rl.ndk87871 branch March 23, 2023 16:23
emilypgoogle pushed a commit that referenced this pull request Mar 23, 2023
@rlazo @emilypgoogle
Use >API30 for crashlytics ndk device testing (#4814)
a16bfd4
@firebase firebase locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daymxn daymxn daymxn approved these changes

@emilypgoogle emilypgoogle emilypgoogle approved these changes

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rlazo @google-oss-bot @daymxn @emilypgoogle