Skip to content

Add GWP-ASan blurb to changelog #4809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add GWP-ASan blurb to changelog #4809

merged 1 commit into from
Mar 22, 2023

Conversation

kmandrika
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@kmandrika kmandrika requested a review from themiswang March 22, 2023 12:52
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (1057863) and merge commit (5f6f81f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/5ofmZhONsd.html

@github-actions
Copy link
Contributor

Unit Test Results

  6 files   -   22    6 suites   - 22   21s ⏱️ - 1m 3s
18 tests  - 258  18 ✔️  - 258  0 💤 ±0  0 ❌ ±0 
36 runs   - 516  36 ✔️  - 516  0 💤 ±0  0 ❌ ±0 

Results for commit c430176. ± Comparison against base commit 1057863.

This pull request removes 276 and adds 18 tests. Note that renamed tests count towards both. 
com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fileWriteFails_doesNotClearFetchedAndReturnsFalse
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fireperfNamespace_freshFetchedConfigs_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fireperfNamespace_noFetchedConfigs_returnsFalse
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_freshFetchedConfigs_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_getActivatedFailed_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_getFetchedFailed_returnsFalse
…

com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (1057863) and merge commit (5f6f81f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/malr42yOwv.html

@kmandrika kmandrika merged commit cad784b into master Mar 22, 2023
@kmandrika kmandrika deleted the kmandrika-patch-1 branch March 22, 2023 13:10
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentile10578635f6f81fDiffSignificant (?)
    p1010.3 ±2 ms9.57 ±3 ms-693 μs (-6.8%)NO
    p2511.3 ±3 ms10.3 ±3 ms-965 μs (-8.5%)NO
    p5012.7 ±3 ms11.4 ±3 ms-1.26 ms (-10.0%)NO
    p7514.2 ±4 ms12.8 ±3 ms-1.35 ms (-9.5%)NO
    p9015.9 ±4 ms14.5 ±3 ms-1.36 ms (-8.6%)NO

    20 test runs in comparison
    CommitTest Runs
    1057863
    • 2023-03-22_01:02:04.783574_gONU
    • 2023-03-22_01:02:04.785762_psJl
    • 2023-03-22_01:02:04.785772_HoxS
    • 2023-03-22_01:02:04.785778_bVnO
    • 2023-03-22_01:02:04.785783_LZeD
    • 2023-03-22_01:02:04.785789_olVF
    • 2023-03-22_01:02:04.785795_idZl
    • 2023-03-22_01:02:04.785800_UXJl
    • 2023-03-22_01:02:04.785805_tuXI
    • 2023-03-22_01:02:04.785810_tlBC
    5f6f81f
    • 2023-03-22_13:08:15.283193_TdNT
    • 2023-03-22_13:08:15.288542_Dkvv
    • 2023-03-22_13:08:15.288554_AjjV
    • 2023-03-22_13:08:15.288686_RGQg
    • 2023-03-22_13:08:15.288692_OoWF
    • 2023-03-22_13:08:15.288698_noDh
    • 2023-03-22_13:08:15.288704_gQDM
    • 2023-03-22_13:08:15.288709_FxZE
    • 2023-03-22_13:08:15.288715_XjHB
    • 2023-03-22_13:08:15.288720_Tump
    redfin-30
    Percentile10578635f6f81fDiffSignificant (?)
    p1016.3 ±8 ms15.9 ±6 ms-427 μs (-2.6%)NO
    p2517.2 ±8 ms17.3 ±7 ms+105 μs (+0.6%)NO
    p5018.5 ±9 ms19.0 ±8 ms+490 μs (+2.6%)NO
    p7520.6 ±10 ms21.7 ±9 ms+1.14 ms (+5.5%)NO
    p9023.0 ±11 ms25.0 ±10 ms+1.98 ms (+8.6%)NO

    20 test runs in comparison
    CommitTest Runs
    1057863
    • 2023-03-22_01:02:04.783574_gONU
    • 2023-03-22_01:02:04.785762_psJl
    • 2023-03-22_01:02:04.785772_HoxS
    • 2023-03-22_01:02:04.785778_bVnO
    • 2023-03-22_01:02:04.785783_LZeD
    • 2023-03-22_01:02:04.785789_olVF
    • 2023-03-22_01:02:04.785795_idZl
    • 2023-03-22_01:02:04.785800_UXJl
    • 2023-03-22_01:02:04.785805_tuXI
    • 2023-03-22_01:02:04.785810_tlBC
    5f6f81f
    • 2023-03-22_13:08:15.283193_TdNT
    • 2023-03-22_13:08:15.288542_Dkvv
    • 2023-03-22_13:08:15.288554_AjjV
    • 2023-03-22_13:08:15.288686_RGQg
    • 2023-03-22_13:08:15.288692_OoWF
    • 2023-03-22_13:08:15.288698_noDh
    • 2023-03-22_13:08:15.288704_gQDM
    • 2023-03-22_13:08:15.288709_FxZE
    • 2023-03-22_13:08:15.288715_XjHB
    • 2023-03-22_13:08:15.288720_Tump

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile10578635f6f81fDiffSignificant (?)
    p10200 ±23 ms197 ±7 ms-2.84 ms (-1.4%)NO
    p25213 ±38 ms204 ±8 ms-8.94 ms (-4.2%)NO
    p50226 ±46 ms212 ±8 ms-13.7 ms (-6.1%)NO
    p75239 ±55 ms221 ±9 ms-17.6 ms (-7.4%)NO
    p90252 ±67 ms233 ±11 ms-18.6 ms (-7.4%)NO

    20 test runs in comparison
    CommitTest Runs
    1057863
    • 2023-03-22_01:02:04.783574_gONU
    • 2023-03-22_01:02:04.785762_psJl
    • 2023-03-22_01:02:04.785772_HoxS
    • 2023-03-22_01:02:04.785778_bVnO
    • 2023-03-22_01:02:04.785783_LZeD
    • 2023-03-22_01:02:04.785789_olVF
    • 2023-03-22_01:02:04.785795_idZl
    • 2023-03-22_01:02:04.785800_UXJl
    • 2023-03-22_01:02:04.785805_tuXI
    • 2023-03-22_01:02:04.785810_tlBC
    5f6f81f
    • 2023-03-22_13:08:15.283193_TdNT
    • 2023-03-22_13:08:15.288542_Dkvv
    • 2023-03-22_13:08:15.288554_AjjV
    • 2023-03-22_13:08:15.288686_RGQg
    • 2023-03-22_13:08:15.288692_OoWF
    • 2023-03-22_13:08:15.288698_noDh
    • 2023-03-22_13:08:15.288704_gQDM
    • 2023-03-22_13:08:15.288709_FxZE
    • 2023-03-22_13:08:15.288715_XjHB
    • 2023-03-22_13:08:15.288720_Tump
    redfin-30
    Percentile10578635f6f81fDiffSignificant (?)
    p10231 ±4 ms255 ±5 ms+24.3 ms (+10.5%)YES
    p25237 ±4 ms262 ±4 ms+25.2 ms (+10.6%)YES
    p50244 ±4 ms270 ±5 ms+25.8 ms (+10.6%)YES
    p75252 ±4 ms279 ±4 ms+27.2 ms (+10.8%)YES
    p90260 ±5 ms292 ±4 ms+32.0 ms (+12.3%)YES

    20 test runs in comparison
    CommitTest Runs
    1057863
    • 2023-03-22_01:02:04.783574_gONU
    • 2023-03-22_01:02:04.785762_psJl
    • 2023-03-22_01:02:04.785772_HoxS
    • 2023-03-22_01:02:04.785778_bVnO
    • 2023-03-22_01:02:04.785783_LZeD
    • 2023-03-22_01:02:04.785789_olVF
    • 2023-03-22_01:02:04.785795_idZl
    • 2023-03-22_01:02:04.785800_UXJl
    • 2023-03-22_01:02:04.785805_tuXI
    • 2023-03-22_01:02:04.785810_tlBC
    5f6f81f
    • 2023-03-22_13:08:15.283193_TdNT
    • 2023-03-22_13:08:15.288542_Dkvv
    • 2023-03-22_13:08:15.288554_AjjV
    • 2023-03-22_13:08:15.288686_RGQg
    • 2023-03-22_13:08:15.288692_OoWF
    • 2023-03-22_13:08:15.288698_noDh
    • 2023-03-22_13:08:15.288704_gQDM
    • 2023-03-22_13:08:15.288709_FxZE
    • 2023-03-22_13:08:15.288715_XjHB
    • 2023-03-22_13:08:15.288720_Tump

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iK1mWnmwzI/index.html

@firebase firebase locked and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themiswang themiswang themiswang approved these changes

Assignees
No one assigned
Labels
main-merge-ack size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmandrika @google-oss-bot @themiswang