Skip to content

Update app-distribution-api gradle.properties and CHANGELOG #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2023
Merged

Update app-distribution-api gradle.properties and CHANGELOG #4795

merged 1 commit into from
Mar 16, 2023

Conversation

lfkellogg
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (8ad3c7c) and merge commit (ee4232c).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/z9U3nU4hC0.html

@github-actions
Copy link
Contributor

Unit Test Results

  36 files  +    8    36 suites  +8   1m 47s ⏱️ +27s
191 tests  -   85  191 ✔️  -   84  0 💤 ±0  0 ❌  - 1 
382 runs   - 170  382 ✔️  - 169  0 💤 ±0  0 ❌  - 1 

Results for commit d6bc5db. ± Comparison against base commit 8ad3c7c.

This pull request removes 276 and adds 191 tests. Note that renamed tests count towards both. 
com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fileWriteFails_doesNotClearFetchedAndReturnsFalse
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fireperfNamespace_freshFetchedConfigs_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fireperfNamespace_noFetchedConfigs_returnsFalse
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_freshFetchedConfigs_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_getActivatedFailed_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_getFetchedFailed_returnsFalse
…

com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_emptyLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_isNotRedirectResponse_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_missingLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_onAppResume_setsUpdateCancelled
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenAabReleaseAvailable_redirectsToPlay
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenOpenConnectionFails_setsNetworkFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateApp_whenCalledMultipleTimesWithAAB_onlyMakesOneRequest
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installActivityDestroyed_setsInstallError
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ installApk_currentActivityNotNull_InstallIntentOnCurrentActivity
com.google.firebase.appdistribution.impl.ApkInstallerTests ‑ whenCalledMultipleTimes_onlyEmitsOneIntent
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution-api

    TypeBase (8ad3c7c)Merge (ee4232c)Diff
    aar16.0 kB16.0 kB-2 B (-0.0%)
    apk (release)1.27 MB1.27 MB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NAaF67y15Z.html

@lfkellogg lfkellogg merged commit 0173e6f into master Mar 16, 2023
@lfkellogg lfkellogg deleted the lk/update-api branch March 16, 2023 20:29
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-appdistribution

    DeviceStatisticsDistributions
    oriole-32
    Percentile8ad3c7cee4232cDiffSignificant (?)
    p10619 ±442 μs1.19 ±0.8 ms+573 μs (+92.6%)NO
    p25671 ±448 μs1.24 ±0.9 ms+569 μs (+84.9%)NO
    p50753 ±488 μs1.31 ±0.9 ms+560 μs (+74.4%)NO
    p75931 ±762 μs1.48 ±0.9 ms+549 μs (+58.9%)NO
    p901.28 ±1 ms1.78 ±1 ms+498 μs (+38.8%)NO

    20 test runs in comparison
    CommitTest Runs
    8ad3c7c
    • 2023-03-15_17:20:47.357802_KmEN
    • 2023-03-15_17:20:47.360795_IClw
    • 2023-03-15_17:20:47.360914_qFvV
    • 2023-03-15_17:20:47.360925_xsyt
    • 2023-03-15_17:20:47.360930_OCBr
    • 2023-03-15_17:20:47.360936_XOkt
    • 2023-03-15_17:20:47.360941_kjTh
    • 2023-03-15_17:20:47.360947_UvuP
    • 2023-03-15_17:20:47.360952_MfEB
    • 2023-03-15_17:20:47.360958_yUWE
    ee4232c
    • 2023-03-16_20:20:00.482202_axWB
    • 2023-03-16_20:20:00.483660_ZdIE
    • 2023-03-16_20:20:00.483671_ytxO
    • 2023-03-16_20:20:00.483677_CHqo
    • 2023-03-16_20:20:00.483682_nnIM
    • 2023-03-16_20:20:00.483689_mHgV
    • 2023-03-16_20:20:00.483694_OcXt
    • 2023-03-16_20:20:00.483699_OGTF
    • 2023-03-16_20:20:00.483704_gGwS
    • 2023-03-16_20:20:00.483709_OWby
    redfin-30
    Percentile8ad3c7cee4232cDiffSignificant (?)
    p103.06 ±2 ms2.57 ±2 ms-492 μs (-16.1%)NO
    p253.49 ±2 ms2.68 ±2 ms-809 μs (-23.2%)NO
    p503.80 ±2 ms2.84 ±2 ms-953 μs (-25.1%)NO
    p754.32 ±3 ms3.08 ±3 ms-1.24 ms (-28.7%)NO
    p905.08 ±4 ms3.80 ±3 ms-1.28 ms (-25.2%)NO

    20 test runs in comparison
    CommitTest Runs
    8ad3c7c
    • 2023-03-15_17:20:47.357802_KmEN
    • 2023-03-15_17:20:47.360795_IClw
    • 2023-03-15_17:20:47.360914_qFvV
    • 2023-03-15_17:20:47.360925_xsyt
    • 2023-03-15_17:20:47.360930_OCBr
    • 2023-03-15_17:20:47.360936_XOkt
    • 2023-03-15_17:20:47.360941_kjTh
    • 2023-03-15_17:20:47.360947_UvuP
    • 2023-03-15_17:20:47.360952_MfEB
    • 2023-03-15_17:20:47.360958_yUWE
    ee4232c
    • 2023-03-16_20:20:00.482202_axWB
    • 2023-03-16_20:20:00.483660_ZdIE
    • 2023-03-16_20:20:00.483671_ytxO
    • 2023-03-16_20:20:00.483677_CHqo
    • 2023-03-16_20:20:00.483682_nnIM
    • 2023-03-16_20:20:00.483689_mHgV
    • 2023-03-16_20:20:00.483694_OcXt
    • 2023-03-16_20:20:00.483699_OGTF
    • 2023-03-16_20:20:00.483704_gGwS
    • 2023-03-16_20:20:00.483709_OWby

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile8ad3c7cee4232cDiffSignificant (?)
    p10205 ±32 ms196 ±4 ms-9.01 ms (-4.4%)NO
    p25214 ±35 ms202 ±5 ms-12.4 ms (-5.8%)NO
    p50231 ±46 ms210 ±6 ms-21.1 ms (-9.1%)NO
    p75248 ±60 ms220 ±6 ms-27.7 ms (-11.2%)NO
    p90261 ±65 ms233 ±9 ms-28.1 ms (-10.7%)NO

    20 test runs in comparison
    CommitTest Runs
    8ad3c7c
    • 2023-03-15_17:20:47.357802_KmEN
    • 2023-03-15_17:20:47.360795_IClw
    • 2023-03-15_17:20:47.360914_qFvV
    • 2023-03-15_17:20:47.360925_xsyt
    • 2023-03-15_17:20:47.360930_OCBr
    • 2023-03-15_17:20:47.360936_XOkt
    • 2023-03-15_17:20:47.360941_kjTh
    • 2023-03-15_17:20:47.360947_UvuP
    • 2023-03-15_17:20:47.360952_MfEB
    • 2023-03-15_17:20:47.360958_yUWE
    ee4232c
    • 2023-03-16_20:20:00.482202_axWB
    • 2023-03-16_20:20:00.483660_ZdIE
    • 2023-03-16_20:20:00.483671_ytxO
    • 2023-03-16_20:20:00.483677_CHqo
    • 2023-03-16_20:20:00.483682_nnIM
    • 2023-03-16_20:20:00.483689_mHgV
    • 2023-03-16_20:20:00.483694_OcXt
    • 2023-03-16_20:20:00.483699_OGTF
    • 2023-03-16_20:20:00.483704_gGwS
    • 2023-03-16_20:20:00.483709_OWby
    redfin-30
    Percentile8ad3c7cee4232cDiffSignificant (?)
    p10230 ±3 ms254 ±5 ms+24.0 ms (+10.4%)YES
    p25236 ±3 ms259 ±5 ms+22.8 ms (+9.7%)MAYBE
    p50243 ±3 ms267 ±6 ms+24.0 ms (+9.9%)MAYBE
    p75250 ±4 ms275 ±5 ms+24.8 ms (+9.9%)YES
    p90260 ±4 ms289 ±7 ms+29.2 ms (+11.2%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    8ad3c7c
    • 2023-03-15_17:20:47.357802_KmEN
    • 2023-03-15_17:20:47.360795_IClw
    • 2023-03-15_17:20:47.360914_qFvV
    • 2023-03-15_17:20:47.360925_xsyt
    • 2023-03-15_17:20:47.360930_OCBr
    • 2023-03-15_17:20:47.360936_XOkt
    • 2023-03-15_17:20:47.360941_kjTh
    • 2023-03-15_17:20:47.360947_UvuP
    • 2023-03-15_17:20:47.360952_MfEB
    • 2023-03-15_17:20:47.360958_yUWE
    ee4232c
    • 2023-03-16_20:20:00.482202_axWB
    • 2023-03-16_20:20:00.483660_ZdIE
    • 2023-03-16_20:20:00.483671_ytxO
    • 2023-03-16_20:20:00.483677_CHqo
    • 2023-03-16_20:20:00.483682_nnIM
    • 2023-03-16_20:20:00.483689_mHgV
    • 2023-03-16_20:20:00.483694_OcXt
    • 2023-03-16_20:20:00.483699_OGTF
    • 2023-03-16_20:20:00.483704_gGwS
    • 2023-03-16_20:20:00.483709_OWby

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2S8DXfAbAv/index.html

emilypgoogle pushed a commit that referenced this pull request Mar 16, 2023
@lfkellogg @emilypgoogle
Update app-distribution-api gradle.properties and CHANGELOG (#4795)
784250c
@firebase firebase locked and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tejasd tejasd tejasd approved these changes

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

@tagboola tagboola Awaiting requested review from tagboola

Assignees
No one assigned
Labels
main-merge-ack size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lfkellogg @google-oss-bot @tejasd