Skip to content

Ignore non-firebase libraries from release configuration #4793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2023
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 16, 2023

No description provided.

@rlazo rlazo requested review from daymxn and emilypgoogle March 16, 2023 05:17
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

buildSrc Test Results

28 tests   28 ✔️  1m 21s ⏱️
  5 suites    0 💤
  5 files      0

Results for commit 6d98c8b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

Unit Test Results

   774 files     774 suites   32m 4s ⏱️
4 852 tests 4 831 ✔️ 21 💤 0
9 501 runs  9 459 ✔️ 42 💤 0

Results for commit 6d98c8b.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023

Size Report 1

Affected Products

  • base

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-abt

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?13.8 kB? (?)
    apk (aggressive)?116 kB? (?)
    apk (release)?1.27 MB? (?)
  • firebase-annotations

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)
  • firebase-appcheck

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?36.6 kB? (?)
    apk (aggressive)?362 kB? (?)
    apk (release)?1.56 MB? (?)
  • firebase-appcheck-debug

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?11.1 kB? (?)
    apk (aggressive)?363 kB? (?)
    apk (release)?1.56 MB? (?)
  • firebase-appcheck-debug-testing

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?7.26 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?1.60 MB? (?)
  • firebase-appcheck-interop

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.02 kB? (?)
    apk (aggressive)?358 kB? (?)
    apk (release)?1.54 MB? (?)
  • firebase-appcheck-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.98 kB? (?)
    apk (aggressive)?370 kB? (?)
    apk (release)?1.94 MB? (?)
  • firebase-appcheck-playintegrity

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?11.0 kB? (?)
    apk (aggressive)?365 kB? (?)
    apk (release)?1.57 MB? (?)
  • firebase-appcheck-safetynet

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?10.4 kB? (?)
    apk (aggressive)?364 kB? (?)
    apk (release)?1.57 MB? (?)
  • firebase-appdistribution

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?245 kB? (?)
    apk (aggressive)?904 kB? (?)
    apk (release)?2.64 MB? (?)
  • firebase-appdistribution-api

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?112 kB? (?)
    apk (release)?1.27 MB? (?)
  • firebase-appdistribution-api-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.85 kB? (?)
    apk (aggressive)?124 kB? (?)
    apk (release)?1.65 MB? (?)
  • firebase-common

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?75.3 kB? (?)
    apk (aggressive)?112 kB? (?)
    apk (release)?1.26 MB? (?)
  • firebase-common-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?13.2 kB? (?)
    apk (aggressive)?123 kB? (?)
    apk (release)?1.64 MB? (?)
  • firebase-components

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?23.3 kB? (?)
    apk (release)?596 kB? (?)
  • firebase-config

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?88.8 kB? (?)
    apk (aggressive)?151 kB? (?)
    apk (release)?1.32 MB? (?)
  • firebase-config-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.58 kB? (?)
    apk (aggressive)?160 kB? (?)
    apk (release)?1.70 MB? (?)
  • firebase-crashlytics

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?350 kB? (?)
    apk (aggressive)?246 kB? (?)
    apk (release)?1.48 MB? (?)
  • firebase-crashlytics-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?6.58 kB? (?)
    apk (aggressive)?254 kB? (?)
    apk (release)?1.86 MB? (?)
  • firebase-crashlytics-ndk

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?1.66 MB? (?)
    apk (aggressive / arm64-v8a)?1.41 MB? (?)
    apk (aggressive / armeabi-v7a)?890 kB? (?)
    apk (aggressive / x86)?1.40 MB? (?)
    apk (aggressive / x86_64)?1.46 MB? (?)
    apk (release / arm64-v8a)?2.64 MB? (?)
    apk (release / armeabi-v7a)?2.12 MB? (?)
    apk (release / x86)?2.62 MB? (?)
    apk (release / x86_64)?2.68 MB? (?)
  • firebase-database

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?488 kB? (?)
    apk (aggressive)?360 kB? (?)
    apk (release)?1.72 MB? (?)
  • firebase-database-collection

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?33.6 kB? (?)
    apk (aggressive)?312 kB? (?)
    apk (release)?941 kB? (?)
  • firebase-database-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?22.6 kB? (?)
    apk (aggressive)?368 kB? (?)
    apk (release)?2.10 MB? (?)
  • firebase-datatransport

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?4.94 kB? (?)
    apk (aggressive)?161 kB? (?)
    apk (release)?1.35 MB? (?)
  • firebase-decoders-json

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?7.67 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)
  • firebase-dynamic-links

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?54.6 kB? (?)
    apk (aggressive)?360 kB? (?)
    apk (release)?1.56 MB? (?)
  • firebase-dynamic-links-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?8.28 kB? (?)
    apk (aggressive)?368 kB? (?)
    apk (release)?1.94 MB? (?)
  • firebase-dynamic-module-support

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.67 kB? (?)
    apk (aggressive)?124 kB? (?)
    apk (release)?1.31 MB? (?)
  • firebase-encoders

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)
  • firebase-encoders-json

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?11.3 kB? (?)
    apk (aggressive)?24.0 kB? (?)
    apk (release)?596 kB? (?)
  • firebase-encoders-proto

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    apk (aggressive)?8.86 kB? (?)
    apk (release)?21.7 kB? (?)
  • firebase-encoders-reflective

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?7.80 kB? (?)
    apk (aggressive)?9.06 kB? (?)
    apk (release)?22.5 kB? (?)
  • firebase-firestore

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?1.32 MB? (?)
    apk (aggressive)?518 kB? (?)
    apk (release)?3.93 MB? (?)
  • firebase-firestore-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?13.5 kB? (?)
    apk (aggressive)?527 kB? (?)
    apk (release)?4.32 MB? (?)
  • firebase-functions

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?45.3 kB? (?)
    apk (aggressive)?400 kB? (?)
    apk (release)?1.81 MB? (?)
  • firebase-functions-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.69 kB? (?)
    apk (aggressive)?409 kB? (?)
    apk (release)?2.19 MB? (?)
  • firebase-inappmessaging

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?454 kB? (?)
    apk (aggressive)?698 kB? (?)
    apk (release)?3.95 MB? (?)
  • firebase-inappmessaging-display

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?180 kB? (?)
    apk (aggressive)?1.53 MB? (?)
    apk (release)?5.21 MB? (?)
  • firebase-inappmessaging-display-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?17.6 kB? (?)
    apk (aggressive)?1.54 MB? (?)
    apk (release)?5.59 MB? (?)
  • firebase-inappmessaging-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.03 kB? (?)
    apk (aggressive)?706 kB? (?)
    apk (release)?4.33 MB? (?)
  • firebase-installations

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?55.2 kB? (?)
    apk (aggressive)?114 kB? (?)
    apk (release)?1.28 MB? (?)
  • firebase-installations-interop

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.2 kB? (?)
    apk (release)?652 kB? (?)
  • firebase-installations-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.01 kB? (?)
    apk (aggressive)?127 kB? (?)
    apk (release)?1.67 MB? (?)
  • firebase-messaging

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?142 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)
  • firebase-messaging-directboot

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?5.12 kB? (?)
    apk (aggressive)?465 kB? (?)
    apk (release)?1.72 MB? (?)
  • firebase-messaging-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?6.10 kB? (?)
    apk (aggressive)?472 kB? (?)
    apk (release)?2.10 MB? (?)
  • firebase-ml-modeldownloader

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?118 kB? (?)
    apk (aggressive)?168 kB? (?)
    apk (release)?1.41 MB? (?)
  • firebase-ml-modeldownloader-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?6.10 kB? (?)
    apk (aggressive)?176 kB? (?)
    apk (release)?1.79 MB? (?)
  • firebase-perf

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?315 kB? (?)
    apk (aggressive)?957 kB? (?)
    apk (release)?2.95 MB? (?)
  • firebase-perf-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?16.0 kB? (?)
    apk (aggressive)?965 kB? (?)
    apk (release)?3.34 MB? (?)
  • firebase-storage

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?116 kB? (?)
    apk (aggressive)?359 kB? (?)
    apk (release)?1.59 MB? (?)
  • firebase-storage-ktx

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?13.1 kB? (?)
    apk (aggressive)?367 kB? (?)
    apk (release)?1.97 MB? (?)
  • protolite-well-known-types

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?999 kB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?666 kB? (?)
  • transport-api

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?6.74 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?14.9 kB? (?)
  • transport-backend-cct

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?53.6 kB? (?)
    apk (aggressive)?57.6 kB? (?)
    apk (release)?105 kB? (?)
  • transport-runtime

    TypeBase (04bbfd7)Merge (3afe0c9)Diff
    aar?180 kB? (?)
    apk (aggressive)?44.6 kB? (?)
    apk (release)?84.0 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MVa5Uyp6tV.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023

Startup Time Report 1

The report is too large (117,078 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4xLUIsuiO2/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023

@rlazo rlazo merged commit 8929123 into master Mar 17, 2023
@rlazo rlazo deleted the rl/javaextfix branch March 17, 2023 18:07
@firebase firebase locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants