Skip to content

Ensure Java 11 is used in macos runners #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2023
Merged

Ensure Java 11 is used in macos runners #4792

merged 2 commits into from
Mar 17, 2023

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Mar 16, 2023

No description provided.

@rlazo rlazo requested review from daymxn and emilypgoogle March 16, 2023 05:01
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023 •
edited
Loading

Unit Test Results

   774 files  +   738     774 suites  +738   33m 9s ⏱️ + 31m 5s
4 852 tests +4 661  4 830 ✔️ +4 639  21 💤 +21  1 ❌ +1 
9 501 runs  +9 119  9 458 ✔️ +9 076  42 💤 +42  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 4a9642f. ± Comparison against base commit 0173e6f.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0173e6f) and merge commit (830ea20).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pKyaIHBcVg.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (0173e6f) to 50.16% (830ea20) by -0.01%.

    FilenameBase (0173e6f)Merge (830ea20)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    DoubleNode.java100.00%88.24%-11.76%
    QueryParams.java89.76%90.36%+0.60%
    WebsocketConnection.java35.03%32.77%-2.26%

  • firebase-firestore

    Overall coverage changed from 44.16% (0173e6f) to 44.16% (830ea20) by +0.00%.

    FilenameBase (0173e6f)Merge (830ea20)Diff
    DeleteMutation.java90.48%95.24%+4.76%

  • firebase-inappmessaging

    Overall coverage changed from ? (0173e6f) to 0.00% (830ea20) by ?.

    148 individual files with coverage change

    FilenameBase (0173e6f)Merge (830ea20)Diff
    AbtIntegrationHelper.java?0.00%?
    AbtIntegrationHelper_Factory.java?0.00%?
    AbtIntegrationHelper_MembersInjector.java?0.00%?
    Action.java?0.00%?
    Analytics.java?0.00%?
    AnalyticsConstants.java?0.00%?
    AnalyticsEventsManager.java?0.00%?
    AnalyticsEventsModule.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsConnectorEventsFactory.java?0.00%?
    AnalyticsEventsModule_ProvidesAnalyticsEventsManagerFactory.java?0.00%?
    AnalyticsListener.java?0.00%?
    ApiClient.java?0.00%?
    ApiClientModule.java?0.00%?
    ApiClientModule_ProvidesApiClientFactory.java?0.00%?
    ApiClientModule_ProvidesDataCollectionHelperFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseAppFactory.java?0.00%?
    ApiClientModule_ProvidesFirebaseInstallationsFactory.java?0.00%?
    ApiClientModule_ProvidesSharedPreferencesUtilsFactory.java?0.00%?
    ApiClientModule_ProvidesTestDeviceHelperFactory.java?0.00%?
    AppComponent.java?0.00%?
    AppForeground.java?0.00%?
    ApplicationModule.java?0.00%?
    ApplicationModule_DeveloperListenerManagerFactory.java?0.00%?
    ApplicationModule_ProvidesApplicationFactory.java?0.00%?
    AppMeasurementModule.java?0.00%?
    AppMeasurementModule_ProvidesAnalyticsConnectorFactory.java?0.00%?
    AppMeasurementModule_ProvidesSubsriberFactory.java?0.00%?
    AutoValue_InstallationIdResult.java?0.00%?
    AutoValue_RateLimit.java?0.00%?
    BannerMessage.java?0.00%?
    Button.java?0.00%?
    CampaignAnalytics.java?0.00%?
    CampaignAnalyticsOrBuilder.java?0.00%?
    CampaignCache.java?0.00%?
    CampaignCacheClient.java?0.00%?
    CampaignCacheClient_Factory.java?0.00%?
    CampaignImpression.java?0.00%?
    CampaignImpressionList.java?0.00%?
    CampaignImpressionListOrBuilder.java?0.00%?
    CampaignImpressionOrBuilder.java?0.00%?
    CampaignMetadata.java?0.00%?
    CampaignProto.java?0.00%?
    CardMessage.java?0.00%?
    ClientAppInfo.java?0.00%?
    ClientAppInfoOrBuilder.java?0.00%?
    Clock.java?0.00%?
    CommonTypesProto.java?0.00%?
    DaggerAppComponent.java?0.00%?
    DaggerUniversalComponent.java?0.00%?
    DataCollectionHelper.java?0.00%?
    DataCollectionHelper_Factory.java?0.00%?
    DeveloperListenerManager.java?0.00%?
    DismissType.java?0.00%?
    DisplayCallbacksFactory.java?0.00%?
    DisplayCallbacksFactory_Factory.java?0.00%?
    DisplayCallbacksImpl.java?0.00%?
    EventType.java?0.00%?
    ExecutorsModule.java?0.00%?
    ExecutorsModule_ProvidesBackgroundExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesBlockingExecutorFactory.java?0.00%?
    ExecutorsModule_ProvidesLightWeightExecutorFactory.java?0.00%?
    ExperimentPayloadProto.java?0.00%?
    FetchEligibleCampaignsRequest.java?0.00%?
    FetchEligibleCampaignsRequestOrBuilder.java?0.00%?
    FetchEligibleCampaignsResponse.java?0.00%?
    FetchEligibleCampaignsResponseOrBuilder.java?0.00%?
    FetchErrorReason.java?0.00%?
    FiamAnalyticsConnectorListener.java?0.00%?
    FiamFetchService.java?0.00%?
    FirebaseAppScope.java?0.00%?
    FirebaseInAppMessaging.java?0.00%?
    FirebaseInAppMessagingCampaignAnalyticsProto.java?0.00%?
    FirebaseInAppMessagingClickListener.java?0.00%?
    FirebaseInAppMessagingContextualTrigger.java?0.00%?
    FirebaseInAppMessagingDismissListener.java?0.00%?
    FirebaseInAppMessagingDisplay.java?0.00%?
    FirebaseInAppMessagingDisplayCallbacks.java?0.00%?
    FirebaseInAppMessagingDisplayErrorListener.java?0.00%?
    FirebaseInAppMessagingImpressionListener.java?0.00%?
    FirebaseInAppMessagingRegistrar.java?0.00%?
    FirebaseInAppMessaging_Factory.java?0.00%?
    ForegroundFlowableModule.java?0.00%?
    ForegroundFlowableModule_ProvidesAppForegroundEventStreamFactory.java?0.00%?
    ForegroundNotifier.java?0.00%?
    GrpcChannelModule.java?0.00%?
    GrpcChannelModule_ProvidesGrpcChannelFactory.java?0.00%?
    GrpcChannelModule_ProvidesServiceHostFactory.java?0.00%?
    GrpcClient.java?0.00%?
    GrpcClientModule.java?0.00%?
    GrpcClientModule_ProvidesApiKeyHeadersFactory.java?0.00%?
    GrpcClientModule_ProvidesInAppMessagingSdkServingStubFactory.java?0.00%?
    GrpcClient_Factory.java?0.00%?
    ImageData.java?0.00%?
    ImageOnlyMessage.java?0.00%?
    ImpressionStorageClient.java?0.00%?
    ImpressionStorageClient_Factory.java?0.00%?
    ImpressionStore.java?0.00%?
    InAppMessage.java?0.00%?
    InAppMessageStreamManager.java?0.00%?
    InAppMessageStreamManager_Factory.java?0.00%?
    InAppMessagingSdkServingGrpc.java?0.00%?
    InstallationIdResult.java?0.00%?
    Logging.java?0.00%?
    MessagesProto.java?0.00%?
    MessageType.java?0.00%?
    MetricsLoggerClient.java?0.00%?
    ModalMessage.java?0.00%?
    ProgramaticContextualTriggers.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggersFactory.java?0.00%?
    ProgrammaticContextualTriggerFlowableModule_ProvidesProgramaticContextualTriggerStreamFactory.java?0.00%?
    ProgrammaticTrigger.java?0.00%?
    ProtoMarshallerClient.java?0.00%?
    ProtoMarshallerClient_Factory.java?0.00%?
    ProtoStorageClient.java?0.00%?
    ProtoStorageClientModule.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForCampaignFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForImpressionStoreFactory.java?0.00%?
    ProtoStorageClientModule_ProvidesProtoStorageClientForLimiterStoreFactory.java?0.00%?
    ProviderInstaller.java?0.00%?
    ProviderInstaller_Factory.java?0.00%?
    ProxyAnalyticsConnector.java?0.00%?
    RateLimit.java?0.00%?
    RateLimiterClient.java?0.00%?
    RateLimiterClient_Factory.java?0.00%?
    RateLimitModule.java?0.00%?
    RateLimitModule_ProvidesAppForegroundRateLimitFactory.java?0.00%?
    RateLimitProto.java?0.00%?
    RenderErrorReason.java?0.00%?
    SchedulerModule.java?0.00%?
    SchedulerModule_ProvidesComputeSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesIOSchedulerFactory.java?0.00%?
    SchedulerModule_ProvidesMainThreadSchedulerFactory.java?0.00%?
    Schedulers.java?0.00%?
    Schedulers_Factory.java?0.00%?
    SharedPreferencesUtils.java?0.00%?
    SharedPreferencesUtils_Factory.java?0.00%?
    SystemClock.java?0.00%?
    SystemClockModule.java?0.00%?
    SystemClockModule_ProvidesSystemClockModuleFactory.java?0.00%?
    SystemClock_Factory.java?0.00%?
    TestDeviceHelper.java?0.00%?
    TestDeviceHelper_Factory.java?0.00%?
    Text.java?0.00%?
    TransportClientModule.java?0.00%?
    TransportClientModule_ProvidesMetricsLoggerClientFactory.java?0.00%?
    TriggeredInAppMessage.java?0.00%?
    UniversalComponent.java?0.00%?

  • firebase-messaging

    Overall coverage changed from ? (0173e6f) to 85.22% (830ea20) by ?.

    41 individual files with coverage change

    FilenameBase (0173e6f)Merge (830ea20)Diff
    AutoProtoEncoderDoNotUseEncoder.java?98.17%?
    ByteStreams.java?59.72%?
    CommonNotificationBuilder.java?90.78%?
    Constants.java?92.86%?
    DisplayNotification.java?91.38%?
    EnhancedIntentService.java?76.60%?
    ExecutorFactory.java?0.00%?
    FcmBroadcastProcessor.java?93.33%?
    FcmExecutors.java?80.00%?
    FcmLifecycleCallbacks.java?89.29%?
    FirebaseInstanceIdReceiver.java?72.73%?
    FirebaseMessaging.java?76.21%?
    FirebaseMessagingRegistrar.java?100.00%?
    FirebaseMessagingService.java?94.03%?
    GmsRpc.java?83.15%?
    ImageDownload.java?93.33%?
    MessagingAnalytics.java?81.78%?
    MessagingClientEvent.java?93.58%?
    MessagingClientEventExtension.java?76.47%?
    Metadata.java?57.14%?
    NotificationParams.java?98.71%?
    PoolableExecutors.java?29.17%?
    ProtoEncoderDoNotUse.java?50.00%?
    ProxyNotificationInitializer.java?93.75%?
    ProxyNotificationPreferences.java?88.89%?
    RemoteMessage.java?95.48%?
    RemoteMessageCreator.java?88.89%?
    RequestDeduplicator.java?90.00%?
    SendException.java?100.00%?
    ServiceStarter.java?87.50%?
    SharedPreferencesQueue.java?98.65%?
    Store.java?74.19%?
    SyncTask.java?70.83%?
    ThreadPriority.java?100.00%?
    TopicOperation.java?90.00%?
    TopicsStore.java?100.00%?
    TopicsSubscriber.java?89.47%?
    TopicsSyncTask.java?53.33%?
    WakeLockHolder.java?95.92%?
    WithinAppServiceBinder.java?90.91%?
    WithinAppServiceConnection.java?84.15%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DoTIIFwm9H.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 16, 2023 •
edited
Loading

Startup Time Report 1

The report is too large (117,030 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FrfPHtMg24/index.html

@rlazo rlazo merged commit 04bbfd7 into master Mar 17, 2023
@rlazo rlazo deleted the rl/macos11 branch March 17, 2023 15:38
emilypgoogle pushed a commit that referenced this pull request Mar 17, 2023
@rlazo @emilypgoogle
Ensure Java 11 is used in macos runners (#4792)
afb0d46
@firebase firebase locked and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emilypgoogle emilypgoogle emilypgoogle approved these changes

@daymxn daymxn Awaiting requested review from daymxn

Assignees
No one assigned
Labels
main-merge-ack size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlazo @google-oss-bot @emilypgoogle