Skip to content

Update next firebase-config version to 21.3.0 #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2023
Merged

Update next firebase-config version to 21.3.0 #4789

merged 1 commit into from
Mar 15, 2023

Conversation

danasilver
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

1 similar comment
@github-actions
Copy link
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@danasilver danasilver requested a review from emilypgoogle March 15, 2023 16:53
@danasilver danasilver marked this pull request as ready for review March 15, 2023 16:53
@danasilver danasilver requested a review from qdpham13 March 15, 2023 16:54
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (6154d89) and merge commit (bf7024a).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/dzZI6qD1Ma.html

qdpham13
qdpham13 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@qdpham13 qdpham13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Unit Test Results

  28 files  +  22    28 suites  +22   1m 28s ⏱️ + 1m 10s
276 tests +258  276 ✔️ +258  0 💤 ±0  0 ❌ ±0 
552 runs  +516  552 ✔️ +516  0 💤 ±0  0 ❌ ±0 

Results for commit 120e72d. ± Comparison against base commit 6154d89.

This pull request removes 18 and adds 276 tests. Note that renamed tests count towards both. 
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fileWriteFails_doesNotClearFetchedAndReturnsFalse
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fireperfNamespace_freshFetchedConfigs_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_fireperfNamespace_noFetchedConfigs_returnsFalse
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_freshFetchedConfigs_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_getActivatedFailed_activatesAndClearsFetched
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_getFetchedFailed_returnsFalse
…

@danasilver danasilver merged commit 8ad3c7c into master Mar 15, 2023
@danasilver danasilver deleted the danasilver-rc-version branch March 15, 2023 17:04
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-config

    TypeBase (6154d89)Merge (bf7024a)Diff
    aar88.8 kB88.8 kB-4 B (-0.0%)
    apk (aggressive)151 kB151 kB+4 B (+0.0%)
    apk (release)1.32 MB1.32 MB-4 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/fveg2S7gun.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentile6154d89bf7024aDiffSignificant (?)
    p1093.3 ±36 μs183 ±238 μs+90.1 μs (+96.6%)NO
    p25107 ±47 μs192 ±247 μs+85.0 μs (+79.5%)NO
    p50138 ±106 μs209 ±264 μs+70.3 μs (+50.8%)NO
    p75161 ±118 μs241 ±300 μs+79.6 μs (+49.4%)NO
    p90218 ±169 μs319 ±385 μs+101 μs (+46.2%)NO

    20 test runs in comparison
    CommitTest Runs
    6154d89
    • 2023-03-15_15:42:07.051684_jahe
    • 2023-03-15_15:42:07.054084_UlPB
    • 2023-03-15_15:42:07.054095_ogsy
    • 2023-03-15_15:42:07.054102_hOrk
    • 2023-03-15_15:42:07.054107_Wlhy
    • 2023-03-15_15:42:07.054113_PawF
    • 2023-03-15_15:42:07.054119_Dqem
    • 2023-03-15_15:42:07.054124_Zhpm
    • 2023-03-15_15:42:07.054130_oQoN
    • 2023-03-15_15:42:07.054136_nOAF
    bf7024a
    • 2023-03-15_17:09:36.142611_hucZ
    • 2023-03-15_17:09:36.148686_xAGU
    • 2023-03-15_17:09:36.148848_HHpy
    • 2023-03-15_17:09:36.148854_xlzE
    • 2023-03-15_17:09:36.148860_QvbY
    • 2023-03-15_17:09:36.148866_JDkg
    • 2023-03-15_17:09:36.148873_UTPC
    • 2023-03-15_17:09:36.148878_FKmI
    • 2023-03-15_17:09:36.149016_tLmr
    • 2023-03-15_17:09:36.149022_lKfQ
    redfin-30
    Percentile6154d89bf7024aDiffSignificant (?)
    p10538 ±541 μs138 ±21 μs-401 μs (-74.4%)NO
    p25625 ±620 μs168 ±87 μs-458 μs (-73.2%)NO
    p50810 ±781 μs179 ±90 μs-631 μs (-77.9%)NO
    p751.05 ±1 ms199 ±90 μs-854 μs (-81.1%)NO
    p901.48 ±1 ms234 ±107 μs-1.25 ms (-84.2%)NO

    20 test runs in comparison
    CommitTest Runs
    6154d89
    • 2023-03-15_15:42:07.051684_jahe
    • 2023-03-15_15:42:07.054084_UlPB
    • 2023-03-15_15:42:07.054095_ogsy
    • 2023-03-15_15:42:07.054102_hOrk
    • 2023-03-15_15:42:07.054107_Wlhy
    • 2023-03-15_15:42:07.054113_PawF
    • 2023-03-15_15:42:07.054119_Dqem
    • 2023-03-15_15:42:07.054124_Zhpm
    • 2023-03-15_15:42:07.054130_oQoN
    • 2023-03-15_15:42:07.054136_nOAF
    bf7024a
    • 2023-03-15_17:09:36.142611_hucZ
    • 2023-03-15_17:09:36.148686_xAGU
    • 2023-03-15_17:09:36.148848_HHpy
    • 2023-03-15_17:09:36.148854_xlzE
    • 2023-03-15_17:09:36.148860_QvbY
    • 2023-03-15_17:09:36.148866_JDkg
    • 2023-03-15_17:09:36.148873_UTPC
    • 2023-03-15_17:09:36.148878_FKmI
    • 2023-03-15_17:09:36.149016_tLmr
    • 2023-03-15_17:09:36.149022_lKfQ

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile6154d89bf7024aDiffSignificant (?)
    p10205 ±35 ms196 ±11 ms-9.60 ms (-4.7%)NO
    p25212 ±36 ms201 ±12 ms-10.4 ms (-4.9%)NO
    p50221 ±41 ms210 ±15 ms-11.4 ms (-5.2%)NO
    p75234 ±48 ms220 ±17 ms-14.7 ms (-6.3%)NO
    p90247 ±57 ms233 ±18 ms-14.6 ms (-5.9%)NO

    20 test runs in comparison
    CommitTest Runs
    6154d89
    • 2023-03-15_15:42:07.051684_jahe
    • 2023-03-15_15:42:07.054084_UlPB
    • 2023-03-15_15:42:07.054095_ogsy
    • 2023-03-15_15:42:07.054102_hOrk
    • 2023-03-15_15:42:07.054107_Wlhy
    • 2023-03-15_15:42:07.054113_PawF
    • 2023-03-15_15:42:07.054119_Dqem
    • 2023-03-15_15:42:07.054124_Zhpm
    • 2023-03-15_15:42:07.054130_oQoN
    • 2023-03-15_15:42:07.054136_nOAF
    bf7024a
    • 2023-03-15_17:09:36.142611_hucZ
    • 2023-03-15_17:09:36.148686_xAGU
    • 2023-03-15_17:09:36.148848_HHpy
    • 2023-03-15_17:09:36.148854_xlzE
    • 2023-03-15_17:09:36.148860_QvbY
    • 2023-03-15_17:09:36.148866_JDkg
    • 2023-03-15_17:09:36.148873_UTPC
    • 2023-03-15_17:09:36.148878_FKmI
    • 2023-03-15_17:09:36.149016_tLmr
    • 2023-03-15_17:09:36.149022_lKfQ
    redfin-30
    Percentile6154d89bf7024aDiffSignificant (?)
    p10231 ±3 ms253 ±4 ms+21.8 ms (+9.4%)YES
    p25237 ±3 ms258 ±4 ms+21.2 ms (+9.0%)YES
    p50244 ±3 ms265 ±4 ms+20.9 ms (+8.5%)YES
    p75252 ±4 ms275 ±5 ms+23.2 ms (+9.2%)YES
    p90261 ±5 ms289 ±8 ms+27.6 ms (+10.6%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    6154d89
    • 2023-03-15_15:42:07.051684_jahe
    • 2023-03-15_15:42:07.054084_UlPB
    • 2023-03-15_15:42:07.054095_ogsy
    • 2023-03-15_15:42:07.054102_hOrk
    • 2023-03-15_15:42:07.054107_Wlhy
    • 2023-03-15_15:42:07.054113_PawF
    • 2023-03-15_15:42:07.054119_Dqem
    • 2023-03-15_15:42:07.054124_Zhpm
    • 2023-03-15_15:42:07.054130_oQoN
    • 2023-03-15_15:42:07.054136_nOAF
    bf7024a
    • 2023-03-15_17:09:36.142611_hucZ
    • 2023-03-15_17:09:36.148686_xAGU
    • 2023-03-15_17:09:36.148848_HHpy
    • 2023-03-15_17:09:36.148854_xlzE
    • 2023-03-15_17:09:36.148860_QvbY
    • 2023-03-15_17:09:36.148866_JDkg
    • 2023-03-15_17:09:36.148873_UTPC
    • 2023-03-15_17:09:36.148878_FKmI
    • 2023-03-15_17:09:36.149016_tLmr
    • 2023-03-15_17:09:36.149022_lKfQ

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KDrHPHfVHO/index.html

emilypgoogle pushed a commit that referenced this pull request Mar 16, 2023
@danasilver @emilypgoogle
Update next firebase-config version to 21.3.0 (#4789)
e21211c
@firebase firebase locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@qdpham13 qdpham13 qdpham13 approved these changes

@emilypgoogle emilypgoogle Awaiting requested review from emilypgoogle

Assignees
No one assigned
Labels
main-merge-ack no-changelog size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danasilver @google-oss-bot @qdpham13