Skip to content

Fix StackOverflowError by deeply nested server-timestamps. #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2023
Merged

Fix StackOverflowError by deeply nested server-timestamps. #4715

merged 5 commits into from
Mar 8, 2023

Conversation

sk-takahiro-kurebayashi
Copy link
Contributor

Summary

This PR fixes app crash by StackOverflowError while saving the document overlay cache into SQLite database inside of Firestore library.

See: #4702

Notes

This PR cannot fix StackOverflowError raised while loading the document overlay cache from SQLite database.
To avoid this crash, we can clear persistent storage by FirebaseFirestore#clearPersistence when right after the app launch.

@google-cla
Copy link

google-cla bot commented Feb 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sk-takahiro-kurebayashi
Copy link
Contributor Author

Hi @ehsannas, let me know how to resolve pr-message check failure. Which feature-branch should I change base-branch to?

@ehsannas ehsannas merged commit 5318bd9 into firebase:master Mar 8, 2023
@ehsannas
Copy link
Contributor

ehsannas commented Mar 8, 2023

@sk-takahiro-kurebayashi Thanks for your contribution! 🎉

@ehsannas
Copy link
Contributor

ehsannas commented Mar 9, 2023

Looks like I need to roll back this change as there were a few integration test failures that were skipped by the CI in this PR.

@ehsannas
Copy link
Contributor

ehsannas commented Mar 9, 2023

I'll look into the failures and fix them as needed.

@ehsannas
Copy link
Contributor

ehsannas commented Mar 9, 2023

For now, rolling this PR back via #4761

@firebase firebase locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants