Skip to content

Properly handle pom dependencies. #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2019
Merged

Properly handle pom dependencies. #461

merged 3 commits into from
May 24, 2019

Conversation

vkryachko
Copy link
Member

Namely:

  • Exclude multidex from POMs
  • Set dependency scope to compile
  • Properly set dependency type(jar, aar) based on resolved artifact name

@vkryachko
Properly handle pom dependencies.
5bdabbe 
Namely:
* Exclude multidex from POMs
* Set dependency scope to compile
* Properly set dependency type(jar, aar) based on resolved artifact name
@vkryachko vkryachko requested review from ashwinraghav and rlazo May 24, 2019 13:39
@googlebot googlebot added the cla: yes Override cla label May 24, 2019
@vkryachko vkryachko requested a review from rlazo May 24, 2019 14:32
@vkryachko vkryachko merged commit ccdf2da into master May 24, 2019
schmidt-sebastian pushed a commit that referenced this pull request May 28, 2019
@vkryachko @schmidt-sebastian
Properly handle pom dependencies. (#461)
ba498ee 
* Properly handle pom dependencies.

Namely:
* Exclude multidex from POMs
* Set dependency scope to compile
* Properly set dependency type(jar, aar) based on resolved artifact name

* Address review comments, fix test

* Fix
ghost pushed a commit that referenced this pull request Jun 3, 2019
@vkryachko @wu-hui
Properly handle pom dependencies. (#461)
88dd68a 
* Properly handle pom dependencies.

Namely:
* Exclude multidex from POMs
* Set dependency scope to compile
* Properly set dependency type(jar, aar) based on resolved artifact name

* Address review comments, fix test

* Fix
@vkryachko vkryachko deleted the vk.pom_adjustments branch June 3, 2019 14:44
@firebase firebase locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

Assignees
No one assigned
Labels
cla: yes Override cla size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vkryachko @rlazo @googlebot @google-oss-bot