Skip to content

Port app.get() check from errorprone to lint #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Port app.get() check from errorprone to lint #4434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
291eedb
Port app.get() check from errorprone to lint
vkryachko Dec 8, 2022
8104bc7
Add copyrights
vkryachko Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseJavaLibraryPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,6 @@ private static void setupStaticAnalysis(Project project, FirebaseLibraryExtensio
.getConfigurations()
.all(
c -> {
if ("annotationProcessor".equals(c.getName())) {
for (String checkProject : library.staticAnalysis.errorproneCheckProjects) {
project
.getDependencies()
.add("annotationProcessor", project.project(checkProject));
}
}
if ("lintChecks".equals(c.getName())) {
for (String checkProject :
library.staticAnalysis.androidLintCheckProjects) {
Expand Down
1 change: 0 additions & 1 deletion buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ public FirebaseLibraryExtension(Project project, LibraryType type) {

private FirebaseStaticAnalysis initializeStaticAnalysis(Project project) {
return new FirebaseStaticAnalysis(
projectsFromProperty(project, "firebase.checks.errorproneProjects"),
projectsFromProperty(project, "firebase.checks.lintProjects"));
}

Expand Down
7 changes: 0 additions & 7 deletions buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseLibraryPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,6 @@ private static void setupStaticAnalysis(Project project, FirebaseLibraryExtensio
.getConfigurations()
.all(
c -> {
if ("annotationProcessor".equals(c.getName())) {
for (String checkProject : library.staticAnalysis.errorproneCheckProjects) {
project
.getDependencies()
.add("annotationProcessor", project.project(checkProject));
}
}
if ("lintChecks".equals(c.getName())) {
for (String checkProject :
library.staticAnalysis.androidLintCheckProjects) {
Expand Down
5 changes: 1 addition & 4 deletions buildSrc/src/main/java/com/google/firebase/gradle/plugins/FirebaseStaticAnalysis.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@
import java.util.Set;

public class FirebaseStaticAnalysis {
public Set<String> errorproneCheckProjects;
public Set<String> androidLintCheckProjects;

public FirebaseStaticAnalysis(
Set<String> errorproneCheckProjects, Set<String> androidLintCheckProjects) {
this.errorproneCheckProjects = errorproneCheckProjects;
public FirebaseStaticAnalysis(Set<String> androidLintCheckProjects) {
this.androidLintCheckProjects = androidLintCheckProjects;
}
}
1 change: 0 additions & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ org.gradle.jvmargs=-Xmx8g -XX:MaxPermSize=8g
org.gradle.parallel=true
org.gradle.caching=true

firebase.checks.errorproneProjects=:tools:errorprone
firebase.checks.lintProjects=:tools:lint

systemProp.illegal-access=warn
Expand Down
1 change: 0 additions & 1 deletion subprojects.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ encoders:protoc-gen-firebase-encoders:tests

integ-testing

tools:errorprone
tools:lint

transport
Expand Down
26 changes: 0 additions & 26 deletions tools/errorprone/errorprone.gradle
View file
Open in desktop

This file was deleted.

146 changes: 0 additions & 146 deletions tools/errorprone/src/main/java/com/google/firebase/errorprone/ComponentsAppGetCheck.java
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions tools/errorprone/src/test/java/com/google/firebase/FirebaseApp.java
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions tools/errorprone/src/test/java/com/google/firebase/errorprone/ComponentsAppGetCheckTest.java
View file
Open in desktop

This file was deleted.

74 changes: 0 additions & 74 deletions ...esources/com/google/firebase/errorprone/FirebaseUseExplicitDependenciesNegativeCases.java
View file
Open in desktop

This file was deleted.

Loading