Removed preguarding of the SDKs. #44
Conversation
| @@ -126,7 +126,7 @@ configure(subprojects) { | |||
| // Apply the retrolambda plugin | |||
| sub.apply plugin: 'me.tatarka.retrolambda' | |||
|
|
|||
| boolean skipPreguard = sub.getProperties().getOrDefault('firebaseSkipPreguard', 'false').toBoolean() | |||
| boolean skipPreguard = sub.getProperties().getOrDefault('firebaseSkipPreguard', 'true').toBoolean() | |||
|
I think it is in scope to
|
There was a problem hiding this comment.
@ashwinraghav I would vote against removing @PublicApi annotations, as @bjornick mentions in the readme update we can use it to perform extra release validation and inform our semver checks.
But I agree that we should remove preguard configs to avoid confusion, we can always retrieve them from git history if need be
|
We want to keep the @publicapi annotation around. If nothing else, it documents in our repo clearly what our supported API is and what is subject to our semver versions. The added tooling is a bonus. Remove the preguard.txt files. PTAL |
|
/retest |
|
/test smoke-tests-release |
|
/test smoke-tests-debug |
|
@bjornick: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #45