Replace Doclava with Dackka #4324

daymxn · 2022-11-14T21:00:16Z

Per b/255992607, this replaces our old Javadoc generation through Doclava with our new implementation with Dackka- so that our release process now generates Javadocs through the DackkaPlugin.

For the sake of brevity (and ensuring everything works), this does not change any task names or even the general format of our release plugins. Especially since some of these plugins are very inter-tangled. This will be addressed in a future PR (probably in relation with my firebase-library refactor work coming up).

github-actions · 2022-11-14T21:04:25Z

buildSrc Test Results

18 tests 18 ✔️ 1m 22s ⏱️
  4 suites   0 💤
  4 files   0 ❌

Results for commit 1d4137b.

github-actions · 2022-11-14T21:22:43Z

Unit Test Results

  395 files ±0   395 suites ±0 19m 30s ⏱️ - 1m 6s
4 730 tests ±0 4 708 ✔️ ±0 22 💤 ±0 0 ❌ ±0
4 746 runs ±0 4 724 ✔️ ±0 22 💤 ±0 0 ❌ ±0

Results for commit 1d4137b. ± Comparison against base commit c1adf5b.

google-oss-bot · 2022-11-14T21:25:18Z

Size Report ¹

Affected Products

base
Type Base (c1adf5b) Merge (2235b8c) Diff
apk (aggressive) ? 8.39 kB ? (?)
apk (release) ? 8.65 kB ? (?)
firebase-abt
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 13.8 kB ? (?)
apk (aggressive) ? 85.8 kB ? (?)
apk (release) ? 688 kB ? (?)
firebase-annotations
Type Base (c1adf5b) Merge (2235b8c) Diff
apk (aggressive) ? 8.39 kB ? (?)
apk (release) ? 8.89 kB ? (?)
firebase-appcheck
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 37.6 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 978 kB ? (?)
firebase-appcheck-debug
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 11.6 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 980 kB ? (?)
firebase-appcheck-debug-testing
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 6.26 kB ? (?)
apk (aggressive) ? 334 kB ? (?)
apk (release) ? 1.02 MB ? (?)
firebase-appcheck-interop
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.02 kB ? (?)
apk (aggressive) ? 329 kB ? (?)
apk (release) ? 966 kB ? (?)
firebase-appcheck-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.98 kB ? (?)
apk (aggressive) ? 356 kB ? (?)
apk (release) ? 1.92 MB ? (?)
firebase-appcheck-playintegrity
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 10.1 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 991 kB ? (?)
firebase-appcheck-safetynet
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 12.1 kB ? (?)
apk (aggressive) ? 332 kB ? (?)
apk (release) ? 992 kB ? (?)
firebase-appdistribution
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 140 kB ? (?)
apk (aggressive) ? 777 kB ? (?)
apk (release) ? 2.00 MB ? (?)
firebase-appdistribution-api
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 14.2 kB ? (?)
apk (aggressive) ? 85.8 kB ? (?)
apk (release) ? 689 kB ? (?)
firebase-appdistribution-api-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.83 kB ? (?)
apk (aggressive) ? 110 kB ? (?)
apk (release) ? 1.63 MB ? (?)
firebase-common
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 50.1 kB ? (?)
apk (aggressive) ? 85.1 kB ? (?)
apk (release) ? 683 kB ? (?)
firebase-common-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 6.02 kB ? (?)
apk (aggressive) ? 109 kB ? (?)
apk (release) ? 1.62 MB ? (?)
firebase-components
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 42.8 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 31.9 kB ? (?)
firebase-config
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 63.0 kB ? (?)
apk (aggressive) ? 94.4 kB ? (?)
apk (release) ? 736 kB ? (?)
firebase-config-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.58 kB ? (?)
apk (aggressive) ? 119 kB ? (?)
apk (release) ? 1.67 MB ? (?)
firebase-crashlytics
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 341 kB ? (?)
apk (aggressive) ? 217 kB ? (?)
apk (release) ? 896 kB ? (?)
firebase-crashlytics-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 6.57 kB ? (?)
apk (aggressive) ? 237 kB ? (?)
apk (release) ? 1.83 MB ? (?)

`firebase-crashlytics-ndk`

Type	Base (`c1adf5b`)	Merge (`2235b8c`)	Diff
aar	?	1.68 MB	? (?)
apk (aggressive / arm64-v8a)	?	1.34 MB	? (?)
apk (aggressive / armeabi-v7a)	?	846 kB	? (?)
apk (aggressive / x86)	?	1.38 MB	? (?)
apk (aggressive / x86_64)	?	1.45 MB	? (?)
apk (release / arm64-v8a)	?	2.02 MB	? (?)
apk (release / armeabi-v7a)	?	1.52 MB	? (?)
apk (release / x86)	?	2.06 MB	? (?)
apk (release / x86_64)	?	2.12 MB	? (?)

firebase-database
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 488 kB ? (?)
apk (aggressive) ? 330 kB ? (?)
apk (release) ? 1.14 MB ? (?)
firebase-database-collection
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 33.6 kB ? (?)
apk (aggressive) ? 312 kB ? (?)
apk (release) ? 941 kB ? (?)
firebase-database-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 22.5 kB ? (?)
apk (aggressive) ? 354 kB ? (?)
apk (release) ? 2.08 MB ? (?)
firebase-datatransport
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 4.94 kB ? (?)
apk (aggressive) ? 136 kB ? (?)
apk (release) ? 771 kB ? (?)
firebase-decoders-json
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 7.67 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 15.3 kB ? (?)
firebase-dynamic-links
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 54.6 kB ? (?)
apk (aggressive) ? 331 kB ? (?)
apk (release) ? 979 kB ? (?)
firebase-dynamic-links-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 8.28 kB ? (?)
apk (aggressive) ? 355 kB ? (?)
apk (release) ? 1.92 MB ? (?)
firebase-dynamic-module-support
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.67 kB ? (?)
apk (aggressive) ? 94.3 kB ? (?)
apk (release) ? 735 kB ? (?)
firebase-encoders
Type Base (c1adf5b) Merge (2235b8c) Diff
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 15.3 kB ? (?)
firebase-encoders-json
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 10.7 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 20.1 kB ? (?)
firebase-encoders-proto
Type Base (c1adf5b) Merge (2235b8c) Diff
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 21.6 kB ? (?)
firebase-encoders-reflective
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 7.80 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 22.2 kB ? (?)
firebase-firestore
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 1.31 MB ? (?)
apk (aggressive) ? 492 kB ? (?)
apk (release) ? 3.35 MB ? (?)
firebase-firestore-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 13.5 kB ? (?)
apk (aggressive) ? 512 kB ? (?)
apk (release) ? 4.29 MB ? (?)
firebase-functions
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 25.8 kB ? (?)
apk (aggressive) ? 375 kB ? (?)
apk (release) ? 1.23 MB ? (?)
firebase-functions-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.69 kB ? (?)
apk (aggressive) ? 395 kB ? (?)
apk (release) ? 2.17 MB ? (?)
firebase-inappmessaging
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 470 kB ? (?)
apk (aggressive) ? 673 kB ? (?)
apk (release) ? 3.38 MB ? (?)
firebase-inappmessaging-display
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 201 kB ? (?)
apk (aggressive) ? 1.51 MB ? (?)
apk (release) ? 4.64 MB ? (?)
firebase-inappmessaging-display-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 17.6 kB ? (?)
apk (aggressive) ? 1.53 MB ? (?)
apk (release) ? 5.58 MB ? (?)
firebase-inappmessaging-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.03 kB ? (?)
apk (aggressive) ? 694 kB ? (?)
apk (release) ? 4.31 MB ? (?)
firebase-installations
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 54.9 kB ? (?)
apk (aggressive) ? 86.5 kB ? (?)
apk (release) ? 706 kB ? (?)
firebase-installations-interop
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 8.05 kB ? (?)
apk (aggressive) ? 65.0 kB ? (?)
apk (release) ? 651 kB ? (?)
firebase-installations-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 5.00 kB ? (?)
apk (aggressive) ? 111 kB ? (?)
apk (release) ? 1.64 MB ? (?)
firebase-messaging
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 142 kB ? (?)
apk (aggressive) ? 440 kB ? (?)
apk (release) ? 1.14 MB ? (?)
firebase-messaging-directboot
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 8.75 kB ? (?)
apk (aggressive) ? 440 kB ? (?)
apk (release) ? 1.14 MB ? (?)
firebase-messaging-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 6.10 kB ? (?)
apk (aggressive) ? 460 kB ? (?)
apk (release) ? 2.08 MB ? (?)
firebase-ml-modeldownloader
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 87.5 kB ? (?)
apk (aggressive) ? 143 kB ? (?)
apk (release) ? 823 kB ? (?)
firebase-ml-modeldownloader-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 6.10 kB ? (?)
apk (aggressive) ? 163 kB ? (?)
apk (release) ? 1.76 MB ? (?)
firebase-perf
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 313 kB ? (?)
apk (aggressive) ? 1.03 MB ? (?)
apk (release) ? 2.48 MB ? (?)
firebase-perf-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 16.0 kB ? (?)
apk (aggressive) ? 1.05 MB ? (?)
apk (release) ? 3.41 MB ? (?)
firebase-segmentation
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 20.0 kB ? (?)
apk (aggressive) ? 87.1 kB ? (?)
apk (release) ? 712 kB ? (?)
firebase-storage
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 116 kB ? (?)
apk (aggressive) ? 330 kB ? (?)
apk (release) ? 1.01 MB ? (?)
firebase-storage-ktx
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 13.1 kB ? (?)
apk (aggressive) ? 354 kB ? (?)
apk (release) ? 1.95 MB ? (?)
protolite-well-known-types
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 999 kB ? (?)
apk (aggressive) ? 134 kB ? (?)
apk (release) ? 663 kB ? (?)
transport-api
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 6.74 kB ? (?)
apk (aggressive) ? 8.68 kB ? (?)
apk (release) ? 14.9 kB ? (?)
transport-backend-cct
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 53.6 kB ? (?)
apk (aggressive) ? 58.2 kB ? (?)
apk (release) ? 105 kB ? (?)
transport-runtime
Type Base (c1adf5b) Merge (2235b8c) Diff
aar ? 180 kB ? (?)
apk (aggressive) ? 44.0 kB ? (?)
apk (release) ? 83.5 kB ? (?)

Test Logs

Merge (2235b8c): https://github.com/firebase/firebase-android-sdk/actions/runs/3465130525

https://storage.googleapis.com/firebase-sdk-metric-reports/W9FAMHHLLB.html

* Remove restriction on Dackka's Javadoc * Refactor release plugin to use dackka

daymxn added 2 commits November 14, 2022 14:54

Remove restriction on Dackka's Javadoc

f43a0ee

Refactor release plugin to use dackka

1d4137b

daymxn added the no-changelog label Nov 14, 2022

daymxn requested review from vkryachko and rlazo November 14, 2022 21:00

daymxn self-assigned this Nov 14, 2022

google-oss-bot added the size/L label Nov 14, 2022

vkryachko approved these changes Nov 15, 2022

View reviewed changes

rlazo approved these changes Nov 15, 2022

View reviewed changes

daymxn merged commit e75d370 into master Nov 15, 2022

daymxn deleted the daymon-use-new-docs-in-release-ci branch November 15, 2022 18:52

davidmotson pushed a commit that referenced this pull request Nov 28, 2022

Replace Doclava with Dackka (#4324)

bbfa826

* Remove restriction on Dackka's Javadoc * Refactor release plugin to use dackka

firebase locked and limited conversation to collaborators Dec 16, 2022

Replace Doclava with Dackka #4324

Replace Doclava with Dackka #4324

Uh oh!

Conversation

daymxn commented Nov 14, 2022

Uh oh!

github-actions bot commented Nov 14, 2022

buildSrc Test Results

Uh oh!

github-actions bot commented Nov 14, 2022

Unit Test Results

Uh oh!

google-oss-bot commented Nov 14, 2022

Size Report 1

Affected Products

base

firebase-abt

firebase-annotations

firebase-appcheck

firebase-appcheck-debug

firebase-appcheck-debug-testing

firebase-appcheck-interop

firebase-appcheck-ktx

firebase-appcheck-playintegrity

firebase-appcheck-safetynet

firebase-appdistribution

firebase-appdistribution-api

firebase-appdistribution-api-ktx

firebase-common

firebase-common-ktx

firebase-components

firebase-config

firebase-config-ktx

firebase-crashlytics

firebase-crashlytics-ktx

firebase-crashlytics-ndk

firebase-database

firebase-database-collection

firebase-database-ktx

firebase-datatransport

firebase-decoders-json

firebase-dynamic-links

firebase-dynamic-links-ktx

firebase-dynamic-module-support

firebase-encoders

firebase-encoders-json

firebase-encoders-proto

firebase-encoders-reflective

firebase-firestore

firebase-firestore-ktx

firebase-functions

firebase-functions-ktx

firebase-inappmessaging

firebase-inappmessaging-display

firebase-inappmessaging-display-ktx

firebase-inappmessaging-ktx

firebase-installations

firebase-installations-interop

firebase-installations-ktx

firebase-messaging

firebase-messaging-directboot

firebase-messaging-ktx

firebase-ml-modeldownloader

firebase-ml-modeldownloader-ktx

firebase-perf

firebase-perf-ktx

firebase-segmentation

firebase-storage

firebase-storage-ktx

protolite-well-known-types

transport-api

transport-backend-cct

transport-runtime

Test Logs

Uh oh!

Uh oh!

Size Report ¹

`base`

`firebase-abt`

`firebase-annotations`

`firebase-appcheck`

`firebase-appcheck-debug`

`firebase-appcheck-debug-testing`

`firebase-appcheck-interop`

`firebase-appcheck-ktx`

`firebase-appcheck-playintegrity`

`firebase-appcheck-safetynet`

`firebase-appdistribution`

`firebase-appdistribution-api`

`firebase-appdistribution-api-ktx`

`firebase-common`

`firebase-common-ktx`

`firebase-components`

`firebase-config`

`firebase-config-ktx`

`firebase-crashlytics`

`firebase-crashlytics-ktx`

`firebase-crashlytics-ndk`

`firebase-database`

`firebase-database-collection`

`firebase-database-ktx`

`firebase-datatransport`

`firebase-decoders-json`

`firebase-dynamic-links`

`firebase-dynamic-links-ktx`

`firebase-dynamic-module-support`

`firebase-encoders`

`firebase-encoders-json`

`firebase-encoders-proto`

`firebase-encoders-reflective`

`firebase-firestore`

`firebase-firestore-ktx`

`firebase-functions`

`firebase-functions-ktx`

`firebase-inappmessaging`

`firebase-inappmessaging-display`

`firebase-inappmessaging-display-ktx`

`firebase-inappmessaging-ktx`

`firebase-installations`

`firebase-installations-interop`

`firebase-installations-ktx`

`firebase-messaging`

`firebase-messaging-directboot`

`firebase-messaging-ktx`

`firebase-ml-modeldownloader`

`firebase-ml-modeldownloader-ktx`

`firebase-perf`

`firebase-perf-ktx`

`firebase-segmentation`

`firebase-storage`

`firebase-storage-ktx`

`protolite-well-known-types`

`transport-api`

`transport-backend-cct`

`transport-runtime`