Skip to content

Enable strict mode for executors. #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,38 @@

package com.google.firebase.concurrent;

import android.os.Process;
import android.os.StrictMode;
import java.util.Locale;
import java.util.concurrent.Executors;
import java.util.concurrent.ThreadFactory;
import java.util.concurrent.atomic.AtomicLong;
import javax.annotation.Nullable;

class CustomThreadFactory implements ThreadFactory {
private static final ThreadFactory DEFAULT = Executors.defaultThreadFactory();
private final AtomicLong threadCount = new AtomicLong();
private final String namePrefix;
private final int priority;
private final StrictMode.ThreadPolicy policy;

CustomThreadFactory(String namePrefix, int priority) {
CustomThreadFactory(String namePrefix, int priority, @Nullable StrictMode.ThreadPolicy policy) {
this.namePrefix = namePrefix;
this.priority = priority;
this.policy = policy;
}

@Override
public Thread newThread(Runnable r) {
Thread thread = DEFAULT.newThread(r);
thread.setPriority(priority);
Thread thread =
DEFAULT.newThread(
() -> {
Process.setThreadPriority(priority);
if (policy != null) {
StrictMode.setThreadPolicy(policy);
}
r.run();
});
thread.setName(
String.format(Locale.ROOT, "%s Thread #%d", namePrefix, threadCount.getAndIncrement()));
return thread;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@
package com.google.firebase.concurrent;

import android.annotation.SuppressLint;
import android.os.Build;
import android.os.Process;
import android.os.StrictMode;
import com.google.firebase.BuildConfig;
import com.google.firebase.annotations.concurrent.Background;
import com.google.firebase.annotations.concurrent.Blocking;
import com.google.firebase.annotations.concurrent.Lightweight;
Expand All @@ -40,15 +43,17 @@ public class ExecutorsRegistrar implements ComponentRegistrar {
() ->
scheduled(
Executors.newFixedThreadPool(
4, factory("Firebase Background", Process.THREAD_PRIORITY_BACKGROUND))));
4,
factory(
"Firebase Background", Process.THREAD_PRIORITY_BACKGROUND, bgPolicy()))));

private static final Lazy<ScheduledExecutorService> LITE_EXECUTOR =
new Lazy<>(
() ->
scheduled(
Executors.newFixedThreadPool(
Math.max(2, Runtime.getRuntime().availableProcessors()),
factory("Firebase Lite", Process.THREAD_PRIORITY_DEFAULT))));
factory("Firebase Lite", Process.THREAD_PRIORITY_DEFAULT, litePolicy()))));

private static final Lazy<ScheduledExecutorService> BLOCKING_EXECUTOR =
new Lazy<>(
Expand Down Expand Up @@ -97,6 +102,33 @@ private static ScheduledExecutorService scheduled(ExecutorService delegate) {
}

private static ThreadFactory factory(String threadPrefix, int priority) {
return new CustomThreadFactory(threadPrefix, priority);
return new CustomThreadFactory(threadPrefix, priority, null);
}

private static ThreadFactory factory(
String threadPrefix, int priority, StrictMode.ThreadPolicy policy) {
return new CustomThreadFactory(threadPrefix, priority, policy);
}

private static StrictMode.ThreadPolicy bgPolicy() {
StrictMode.ThreadPolicy.Builder builder = new StrictMode.ThreadPolicy.Builder().detectNetwork();
if (Build.VERSION.SDK_INT >= 23) {
builder.detectResourceMismatches();
if (Build.VERSION.SDK_INT >= 26) {
builder.detectUnbufferedIo();
}
}
if (BuildConfig.DEBUG) {
builder.penaltyDeath();
}
return builder.penaltyLog().build();
}

private static StrictMode.ThreadPolicy litePolicy() {
StrictMode.ThreadPolicy.Builder builder = new StrictMode.ThreadPolicy.Builder().detectAll();
if (BuildConfig.DEBUG) {
builder.penaltyDeath();
}
return builder.penaltyLog().build();
}
}