Skip to content

Upgrade GRPC tp 1.50.2 #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2022
Merged

Upgrade GRPC tp 1.50.2 #4277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13c65c7
Upgrade GRPC tp 1.50.2
tom-andersen Nov 3, 2022
e49acfd
Add changelog for Upgrade GRPC tp 1.50.2
tom-andersen Nov 3, 2022
51f5920
Add links to changelog
tom-andersen Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ ext {
playServicesVersion = '16.0.1'
supportAnnotationsVersion = '28.0.0'
googleTruthVersion = '1.1.2'
grpcVersion = '1.48.1'
grpcVersion = '1.50.2'
robolectricVersion = '4.9'
protocVersion = '3.17.3'
javaliteVersion = '3.17.3'
Expand Down
9 changes: 5 additions & 4 deletions firebase-firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
# Unreleased
- [fixed] Fix FAILED_PRECONDITION when writing to a deleted document in a transaction.
(#5871).

- [fixed] Fixed Firestore failing to raise initial snapshot from empty local cache result.
- [fixed] Removed invalid suggestions to use `GenericTypeIndicator` from error messages.
([Issue #5871](//github.com/firebase/firebase-android-sdk/issues/5871))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just leave the issue/PR links in this format: (#5871). No need to make them hyperlinks. At least, that's what's done elsewhere in this file. When you create the CL with the release notes that get published on the web, those should be clickable hyperlinks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are examples in changelog where issues have a complete hyperlink. That is where I picked up style by copy/paste. So given the inconsistency, what is best? Making the link takes a little bit more effort, but not much. I would be happy to raise the bar to this level.

When I make the CL, I do so by copying the changelog directly. So having them be the same is easiest in my opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Copypasteability is great so I support "raising the bar". Plus, it makes the links clickable when you look at the rendered markdown in the GitHub Web UI.

- [fixed] Fixed Firestore failing to raise initial snapshot from empty local cache result. ([PR](https://github.com/firebase/firebase-android-sdk/pull/4207))
- [fixed] Removed invalid suggestions to use `GenericTypeIndicator` from error messages. ([Issue 222](https://github.com/firebase/firebase-android-sdk/issues/222))
- [changed] Updated dependency of `io.grpc.*` to its latest
version (v1.50.2).

# 24.4.0
* [feature] Added
Expand Down