Skip to content

Remove smoke test for app indexing #4219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Remove smoke test for app indexing #4219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3132c93
Remove smoke test for app indexing
yifanyang Oct 18, 2022
61367ca
fix
yifanyang Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion smoke-tests/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ dependencies {
implementation "com.google.firebase:firebase-annotations"
implementation "com.google.firebase:firebase-appdistribution:16.0.0-beta03"
implementation "com.google.firebase:firebase-appdistribution-api:16.0.0-beta03"
implementation "com.google.firebase:firebase-appindexing"
implementation "com.google.firebase:firebase-auth"
implementation "com.google.firebase:firebase-common"
implementation "com.google.firebase:firebase-config"
Expand All @@ -84,6 +83,10 @@ dependencies {
implementation "com.google.firebase:firebase-perf"
implementation "com.google.firebase:firebase-storage"

// TODO(yifany): remove after the issue is fixed
// https://github.com/firebase/firebase-android-sdk/issues/4206
implementation "com.google.firebase:firebase-iid:21.1.0"

// Common utilities (application side)
implementation "androidx.test:rules:1.4.0"
implementation "androidx.test:runner:1.4.0"
Expand Down
6 changes: 0 additions & 6 deletions smoke-tests/src/main/java/com/google/firebase/testing/BuildOnlyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

import static com.google.common.truth.Truth.assertThat;

import com.google.firebase.appindexing.FirebaseAppIndex;
import com.google.firebase.inappmessaging.FirebaseInAppMessaging;
import com.google.firebase.messaging.FirebaseMessaging;
import com.google.firebase.ml.modeldownloader.FirebaseModelDownloader;
Expand All @@ -32,11 +31,6 @@
@RunWith(JUnit4.class)
public final class BuildOnlyTest {

@Test
public void appindexing_IsNotNull() {
assertThat(FirebaseAppIndex.getInstance(getApplicationContext())).isNotNull();
}

@Test
public void inappmessaging_IsNotNull() {
assertThat(FirebaseInAppMessaging.getInstance()).isNotNull();
Expand Down