Remove local references from reference delegate #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoltis
suggested changes
Sep 24, 2018
| @@ -558,7 +558,13 @@ public void releaseQuery(Query query) { | |||
| queryCache.updateQueryData(queryData); | |||
| } | |||
|
|
|||
| localViewReferences.removeReferencesForId(queryData.getTargetId()); | |||
| // We remove both locally edited documents and documents that are associated via the query | |||
| // cache. | |||
There was a problem hiding this comment.
I would add more to this comment. Something like: "We may have determined that a document is associated with a target, but if that hasn't been confirmed by the backend, the query cache won't know to remove the reference for those documents. Make sure we remove them here."
Or some variation on that.
There was a problem hiding this comment.
Updated the comment to:
// References for documents sent via Watch are automatically removed when we delete a
// query's target data from the reference delegate. Since this does not remove references
// for locally mutated documents, we have to remove the target associations for these
// documents manually.
schmidt-sebastian
force-pushed
the
mrschmidt-fixlru
branch
from
c7d7a95 to
5e1f03c
Compare
gsoltis
approved these changes
Sep 24, 2018
|
FYI: I also added a unit test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with GC that prevented local document removal for documents that had pending mutations.
Also renames applyBatchResult to applyWriteToRemoteDocuments to match Web.