Skip to content

Add names to all Firebase components #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2022
Merged

Add names to all Firebase components #4117

merged 5 commits into from
Sep 23, 2022

Conversation

yifanyang
Copy link
Contributor

No description provided.

@yifanyang yifanyang requested a review from vkryachko September 20, 2022 00:06
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (6caf590)Merge (49e1249)Diff
    aar13.7 kB13.8 kB+62 B (+0.5%)
    apk (aggressive)85.8 kB85.8 kB+64 B (+0.1%)
    apk (release)687 kB688 kB+108 B (+0.0%)

  • firebase-appcheck

    TypeBase (6caf590)Merge (49e1249)Diff
    aar37.1 kB37.1 kB+68 B (+0.2%)
    apk (aggressive)332 kB332 kB+4 B (+0.0%)
    apk (release)977 kB977 kB-32 B (-0.0%)

  • firebase-appcheck-debug

    TypeBase (6caf590)Merge (49e1249)Diff
    aar11.5 kB11.6 kB+27 B (+0.2%)
    apk (aggressive)332 kB332 kB+4 B (+0.0%)
    apk (release)980 kB980 kB-32 B (-0.0%)

  • firebase-appcheck-playintegrity

    TypeBase (6caf590)Merge (49e1249)Diff
    aar10.1 kB10.1 kB+25 B (+0.2%)
    apk (aggressive)332 kB332 kB-16 B (-0.0%)
    apk (release)990 kB990 kB+196 B (+0.0%)

  • firebase-appcheck-safetynet

    TypeBase (6caf590)Merge (49e1249)Diff
    aar12.0 kB12.1 kB+23 B (+0.2%)
    apk (aggressive)332 kB332 kB-28 B (-0.0%)
    apk (release)991 kB991 kB-4 B (-0.0%)

  • firebase-appdistribution

    TypeBase (6caf590)Merge (49e1249)Diff
    aar140 kB140 kB+60 B (+0.0%)
    apk (aggressive)777 kB777 kB+132 B (+0.0%)
    apk (release)2.00 MB2.00 MB+272 B (+0.0%)

  • firebase-appdistribution-api

    TypeBase (6caf590)Merge (49e1249)Diff
    aar14.1 kB14.2 kB+65 B (+0.5%)
    apk (aggressive)85.7 kB85.8 kB+64 B (+0.1%)
    apk (release)689 kB689 kB+124 B (+0.0%)

  • firebase-config

    TypeBase (6caf590)Merge (49e1249)Diff
    aar62.9 kB63.0 kB+69 B (+0.1%)
    apk (aggressive)94.3 kB94.4 kB+92 B (+0.1%)
    apk (release)736 kB736 kB+308 B (+0.0%)

  • firebase-crashlytics

    TypeBase (6caf590)Merge (49e1249)Diff
    aar340 kB340 kB+65 B (+0.0%)
    apk (aggressive)217 kB217 kB+60 B (+0.0%)
    apk (release)894 kB894 kB+48 B (+0.0%)

  • firebase-crashlytics-ndk

    TypeBase (6caf590)Merge (49e1249)Diff
    aar1.67 MB1.67 MB+65 B (+0.0%)

  • firebase-database

    TypeBase (6caf590)Merge (49e1249)Diff
    aar488 kB488 kB+66 B (+0.0%)
    apk (aggressive)330 kB330 kB+60 B (+0.0%)
    apk (release)1.14 MB1.14 MB+84 B (+0.0%)

  • firebase-datatransport

    TypeBase (6caf590)Merge (49e1249)Diff
    aar4.88 kB4.94 kB+57 B (+1.2%)
    apk (aggressive)131 kB132 kB+56 B (+0.0%)
    apk (release)770 kB770 kB+12 B (+0.0%)

  • firebase-dynamic-links

    TypeBase (6caf590)Merge (49e1249)Diff
    aar54.5 kB54.6 kB+66 B (+0.1%)
    apk (aggressive)331 kB331 kB+44 B (+0.0%)
    apk (release)979 kB979 kB+32 B (+0.0%)

  • firebase-dynamic-module-support

    TypeBase (6caf590)Merge (49e1249)Diff
    aar5.61 kB5.67 kB+65 B (+1.2%)
    apk (aggressive)94.3 kB94.3 kB+12 B (+0.0%)
    apk (release)735 kB735 kB+100 B (+0.0%)

  • firebase-firestore

    TypeBase (6caf590)Merge (49e1249)Diff
    aar1.30 MB1.30 MB+71 B (+0.0%)
    apk (aggressive)492 kB492 kB+40 B (+0.0%)
    apk (release)3.32 MB3.32 MB-192 B (-0.0%)

  • firebase-functions

    TypeBase (6caf590)Merge (49e1249)Diff
    aar25.7 kB25.8 kB+64 B (+0.2%)
    apk (aggressive)398 kB399 kB+60 B (+0.0%)
    apk (release)1.21 MB1.21 MB+176 B (+0.0%)

  • firebase-inappmessaging

    TypeBase (6caf590)Merge (49e1249)Diff
    aar470 kB470 kB+71 B (+0.0%)
    apk (aggressive)665 kB665 kB+140 B (+0.0%)
    apk (release)3.36 MB3.36 MB+176 B (+0.0%)

  • firebase-inappmessaging-display

    TypeBase (6caf590)Merge (49e1249)Diff
    aar201 kB201 kB+78 B (+0.0%)
    apk (aggressive)1.50 MB1.50 MB+240 B (+0.0%)
    apk (release)4.61 MB4.61 MB+96 B (+0.0%)

  • firebase-installations

    TypeBase (6caf590)Merge (49e1249)Diff
    aar54.9 kB54.9 kB+63 B (+0.1%)
    apk (aggressive)86.4 kB86.5 kB+76 B (+0.1%)
    apk (release)706 kB706 kB+40 B (+0.0%)

  • firebase-messaging

    TypeBase (6caf590)Merge (49e1249)Diff
    aar142 kB142 kB+64 B (+0.0%)
    apk (aggressive)440 kB440 kB+88 B (+0.0%)
    apk (release)1.14 MB1.14 MB+40 B (+0.0%)

  • firebase-ml-modeldownloader

    TypeBase (6caf590)Merge (49e1249)Diff
    aar87.3 kB87.4 kB+85 B (+0.1%)
    apk (aggressive)143 kB143 kB+56 B (+0.0%)
    apk (release)822 kB822 kB+220 B (+0.0%)

  • firebase-perf

    TypeBase (6caf590)Merge (49e1249)Diff
    aar309 kB309 kB+59 B (+0.0%)
    apk (aggressive)1.03 MB1.03 MB+152 B (+0.0%)
    apk (release)2.47 MB2.47 MB+56 B (+0.0%)

  • firebase-segmentation

    TypeBase (6caf590)Merge (49e1249)Diff
    aar19.9 kB20.0 kB+62 B (+0.3%)
    apk (aggressive)87.0 kB87.1 kB+80 B (+0.1%)
    apk (release)712 kB712 kB-4 B (-0.0%)

  • firebase-storage

    TypeBase (6caf590)Merge (49e1249)Diff
    aar115 kB115 kB+53 B (+0.0%)
    apk (aggressive)330 kB330 kB+68 B (+0.0%)
    apk (release)1.01 MB1.01 MB+32 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NoIlUaGMPe.html

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022 •
edited
Loading

Unit Test Results

   333 files   -   61     333 suites   - 61   15m 34s ⏱️ - 2m 1s
4 270 tests  - 443  4 248 ✔️  - 442  22 💤 ±0  0 ❌  - 1 
4 274 runs   - 455  4 252 ✔️  - 454  22 💤 ±0  0 ❌  - 1 

Results for commit a5966d2. ± Comparison against base commit 65356d8.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-abt

    Overall coverage changed from 82.29% (6caf590) to 81.87% (49e1249) by -0.43%.

  • firebase-appcheck

    Overall coverage changed from 81.39% (6caf590) to 81.42% (49e1249) by +0.04%.

  • firebase-appcheck-debug

    Overall coverage changed from 77.46% (6caf590) to 78.57% (49e1249) by +1.11%.

  • firebase-appcheck-playintegrity

    Overall coverage changed from 87.50% (6caf590) to 88.89% (49e1249) by +1.39%.

  • firebase-appcheck-safetynet

    Overall coverage changed from 80.77% (6caf590) to 81.82% (49e1249) by +1.05%.

  • firebase-appdistribution

    Overall coverage changed from 79.31% (6caf590) to 79.33% (49e1249) by +0.01%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    FirebaseAppDistributionRegistrar.java92.59%92.86%+0.26%

  • firebase-appdistribution-api

    Overall coverage changed from 64.42% (6caf590) to 63.81% (49e1249) by -0.61%.

  • firebase-config

    Overall coverage changed from 88.93% (6caf590) to 88.94% (49e1249) by +0.01%.

  • firebase-crashlytics

    Overall coverage changed from 10.18% (6caf590) to 10.18% (49e1249) by -0.00%.

  • firebase-database

    Overall coverage changed from 50.17% (6caf590) to 50.22% (49e1249) by +0.05%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-dynamic-links

    Overall coverage changed from 69.01% (6caf590) to 69.06% (49e1249) by +0.05%.

  • firebase-firestore

    Overall coverage changed from 44.25% (6caf590) to 44.26% (49e1249) by +0.01%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    DeleteMutation.java90.48%95.24%+4.76%

  • firebase-functions

    Overall coverage changed from 3.43% (6caf590) to 3.65% (49e1249) by +0.22%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    FunctionsRegistrar.java65.22%66.67%+1.45%

  • firebase-installations

    Overall coverage changed from 58.52% (6caf590) to 58.56% (49e1249) by +0.04%.

  • firebase-messaging

    Overall coverage changed from 85.26% (6caf590) to 85.23% (49e1249) by -0.03%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    MessagingAnalytics.java82.19%81.78%-0.40%

  • firebase-ml-modeldownloader

    Overall coverage changed from 83.95% (6caf590) to 83.96% (49e1249) by +0.01%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    FirebaseModelDownloaderRegistrar.java94.87%95.00%+0.13%

  • firebase-perf

    Overall coverage changed from 71.21% (6caf590) to 71.22% (49e1249) by +0.00%.

  • firebase-segmentation

    Overall coverage changed from 53.07% (6caf590) to 53.24% (49e1249) by +0.17%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    FirebaseSegmentationRegistrar.java80.00%81.82%+1.82%

  • firebase-storage

    Overall coverage changed from 86.24% (6caf590) to 86.03% (49e1249) by -0.21%.

    FilenameBase (6caf590)Merge (49e1249)Diff
    NetworkRequest.java86.67%87.18%+0.51%
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java84.89%84.59%-0.30%
    StreamDownloadTask.java88.41%88.89%+0.48%
    UploadTask.java82.73%81.29%-1.44%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yzk715BIM5.html

vkryachko
vkryachko reviewed Sep 21, 2022
View reviewed changes
...k-debug/src/main/java/com/google/firebase/appcheck/debug/FirebaseAppCheckDebugRegistrar.java Outdated
@@ -29,10 +29,11 @@
*/
@KeepForSdk
public class FirebaseAppCheckDebugRegistrar implements ComponentRegistrar {
public static final String LIBRARY_NAME = "fire-app-check-debug";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, here and throughout

Suggested change
public static final String LIBRARY_NAME = "fire-app-check-debug";
private static final String LIBRARY_NAME = "fire-app-check-debug";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed all constants to be private. Can you help me take another look?

@yifanyang yifanyang merged commit 7273b29 into master Sep 23, 2022
@yifanyang yifanyang deleted the yifany/component-name branch September 23, 2022 19:25
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

Assignees
No one assigned
Labels
no-changelog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yifanyang @google-oss-bot @vkryachko