Skip to content

Add strict mode testing in firebase-messaging #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

emilypgoogle
Copy link
Collaborator

Part of a larger effort to resolve and prevent strict mode violations for eager components.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2022

Unit Test Results

  27 files   -    367    27 suites   - 367   3m 48s ⏱️ - 14m 28s
474 tests  - 4 243  474 ✔️  - 4 219  0 💤  - 22  0  - 2 
474 runs   - 4 259  474 ✔️  - 4 235  0 💤  - 22  0  - 2 

Results for commit 988669b. ± Comparison against base commit 0c11f12.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (0c11f12)Merge (21d995a)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-annotations

    TypeBase (0c11f12)Merge (21d995a)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.89 kB? (?)
  • firebase-common

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?50.1 kB? (?)
    apk (aggressive)?85.1 kB? (?)
    apk (release)?683 kB? (?)
  • firebase-components

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?42.8 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?31.9 kB? (?)
  • firebase-datatransport

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?4.88 kB? (?)
    apk (aggressive)?131 kB? (?)
    apk (release)?770 kB? (?)
  • firebase-encoders

    TypeBase (0c11f12)Merge (21d995a)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?15.3 kB? (?)
  • firebase-encoders-json

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?10.7 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?20.1 kB? (?)
  • firebase-encoders-proto

    TypeBase (0c11f12)Merge (21d995a)Diff
    apk (aggressive)?8.68 kB? (?)
    apk (release)?21.6 kB? (?)
  • firebase-installations

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?54.9 kB? (?)
    apk (aggressive)?86.4 kB? (?)
    apk (release)?706 kB? (?)
  • firebase-installations-interop

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?8.06 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)
  • firebase-messaging

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?142 kB? (?)
    apk (aggressive)?440 kB? (?)
    apk (release)?1.14 MB? (?)
  • transport-api

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?6.74 kB? (?)
    apk (aggressive)?8.68 kB? (?)
    apk (release)?14.9 kB? (?)
  • transport-backend-cct

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?53.6 kB? (?)
    apk (aggressive)?58.2 kB? (?)
    apk (release)?105 kB? (?)
  • transport-runtime

    TypeBase (0c11f12)Merge (21d995a)Diff
    aar?178 kB? (?)
    apk (aggressive)?44.0 kB? (?)
    apk (release)?83.0 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lvja4aGTzc.html

@gsakakihara
Copy link
Contributor

Just to clarify, this isn't actually resolving any strict mode violations, right? This appears to be adding a new test to prevent any new strict mode violations from being added in the future? If so, could you change the commit message to reflect that? I'm slightly concerned that someone just looking at the commit messages could think that there was a problem before and misdiagnose a strict mode issue, believing that it was caused by FCM and not identifying the actual cause.

@emilypgoogle emilypgoogle changed the title Resolve strict mode violations in firebase-messaging Add strict mode testing in firebase-messaging Sep 23, 2022
@emilypgoogle
Copy link
Collaborator Author

Firebase squashes commits so I changed the PR name and it'll use that instead of what I used for my branch

@emilypgoogle emilypgoogle merged commit fdb88d7 into master Sep 23, 2022
@emilypgoogle emilypgoogle deleted the ep/messaging-strict-mode branch September 23, 2022 21:08
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants