-
Notifications
You must be signed in to change notification settings - Fork 617
Add strict mode testing in firebase-messaging #4095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
Coverage Report 1Affected ProductsNo changes between base commit (0c11f12) and merge commit (21d995a).Test Logs |
Size Report 1Affected Products
Test Logs |
Just to clarify, this isn't actually resolving any strict mode violations, right? This appears to be adding a new test to prevent any new strict mode violations from being added in the future? If so, could you change the commit message to reflect that? I'm slightly concerned that someone just looking at the commit messages could think that there was a problem before and misdiagnose a strict mode issue, believing that it was caused by FCM and not identifying the actual cause. |
Firebase squashes commits so I changed the PR name and it'll use that instead of what I used for my branch |
Part of a larger effort to resolve and prevent strict mode violations for eager components.