Skip to content

Minor updates to the App Distribution test app. #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ import androidx.appcompat.app.AppCompatActivity
import androidx.appcompat.widget.AppCompatButton
import com.google.android.gms.tasks.Task
import com.google.firebase.appdistribution.AppDistributionRelease
import com.google.firebase.appdistribution.FirebaseAppDistribution
import com.google.firebase.appdistribution.UpdateProgress
import com.google.firebase.appdistribution.ktx.appDistribution
import com.google.firebase.ktx.Firebase
import java.util.concurrent.ExecutorService
import java.util.concurrent.Executors

class MainActivity : AppCompatActivity() {
var firebaseAppDistribution: FirebaseAppDistribution = FirebaseAppDistribution.getInstance()
var firebaseAppDistribution = Firebase.appDistribution
var updateTask: Task<Void>? = null
var release: AppDistributionRelease? = null
val executorService: ExecutorService = Executors.newFixedThreadPool(1)
Expand Down
22 changes: 13 additions & 9 deletions firebase-appdistribution/test-app/test-app.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,26 @@ plugins {
}

android {
compileSdkVersion 30
compileSdkVersion 31

defaultConfig {
applicationId "com.googletest.firebase.appdistribution.testapp"
minSdkVersion 19
targetSdkVersion 30
targetSdkVersion 31
versionName "1.0"
versionCode 1

testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
}

buildTypes {
// This is so we can build the "release" variant for the "dev-app" (and the SDK) without
// This is so we can build the "release" variant for the "test-app" (and the SDK) without
// needing to have the app signed.
release {
initWith debug
}
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Expand All @@ -50,15 +51,18 @@ dependencies {
// TODO(rachelprince): Add flag to build with public version of SDK
println("Building with HEAD version ':firebase-appdistribution' of SDK")

// Debug variant uses full SDK
debugImplementation project(':firebase-appdistribution-api') // TODO(lkellogg): why doesn't this get picked up transitively?
debugImplementation project(':firebase-appdistribution')

// Release variant just uses the API, as if publishing to Play
releaseImplementation project(':firebase-appdistribution-api')
// All variants use the API
implementation project(':firebase-appdistribution-api:ktx')

// In this test project we also need to explicitly declare these dependencies
implementation project(':firebase-appdistribution-api')
implementation project(':firebase-common:ktx')
implementation "com.google.android.gms:play-services-tasks:18.0.1"

// Debug uses the full implementation
debugImplementation project(':firebase-appdistribution')

// Other dependencies
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"
implementation 'androidx.core:core-ktx:1.5.0'
implementation "androidx.core:core:1.6.0"
Expand Down