Adjust a few READMEs to eliminate some redundancy #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build/publish/test commands are common across the projects, so we can just refer to them in the top level README rather than repeating them in the sub-READMEs.
ashwinraghav
reviewed
Sep 6, 2018
README.md
Outdated
| Building the Firebase SDKs can be performed by invoking the following on the | ||
| command line: | ||
| ```bash | ||
| ./gradlew :<firebase-project>:assemble` |
There was a problem hiding this comment.
I am wondering if assembling a stand along binary of the sdk is useful in practice, since the resulting binaries are not hermetic and require that its' dependencies be wired in.
wdyt?
There was a problem hiding this comment.
I think I agree. I included it here, because I removed it from the sub-project's readmes. I'm happy to simply remove it instead.
Done.
schmidt-sebastian
approved these changes
Sep 7, 2018
|
FYI : |
ashwinraghav
approved these changes
Sep 7, 2018
|
/retest |
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2019
ghost
pushed a commit
that referenced
this pull request
Aug 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build/publish/test commands are common across the projects, so we can
just refer to them in the top level README rather than repeating them in
the sub-READMEs.