Skip to content

Add workflow definition for smoke tests #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 4, 2022

Conversation

yifanyang
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Unit Test Results

   391 files  +   391     391 suites  +391   16m 7s ⏱️ + 16m 7s
4 697 tests +4 697  4 674 ✔️ +4 674  22 💤 +22  1 +1 
4 713 runs  +4 713  4 690 ✔️ +4 690  22 💤 +22  1 +1 

For more details on these failures, see this check.

Results for commit 3aacbea. ± Comparison against base commit 8cc5d4a.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.14% (381bf87) to 50.13% (1ffc87d) by -0.01%.

    FilenameBase (381bf87)Merge (1ffc87d)Diff
    BooleanNode.java100.00%92.31%-7.69%
  • firebase-firestore

    Overall coverage changed from 45.92% (381bf87) to 45.91% (1ffc87d) by -0.00%.

    FilenameBase (381bf87)Merge (1ffc87d)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.22%94.44%-2.78%
  • firebase-messaging

    Overall coverage changed from 85.15% (381bf87) to 85.03% (1ffc87d) by -0.12%.

    FilenameBase (381bf87)Merge (1ffc87d)Diff
    FirebaseMessaging.java75.33%74.89%-0.44%
    MessagingAnalytics.java82.19%81.38%-0.81%

Test Logs

Notes

  • Commit (1ffc87d) is created by Prow via merging PR base commit (381bf87) and head commit (2f1c276).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/azSLNvozwL.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 2, 2022

@yifanyang yifanyang force-pushed the yifany/gha-migration-smoke-tests branch from d660b0b to 24936f6 Compare August 2, 2022 23:06
@yifanyang yifanyang requested a review from vkryachko August 4, 2022 03:02
on: [ pull_request ]

jobs:
smoke-tests:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth adding a check to see if secrets are going to be available, similar to:

# only run on post submit or PRs not originating from forks.
if: (github.repository == 'Firebase/firebase-android-sdk' && github.event_name == 'push') || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The smoke tests were enabled only for presubmit on Prow, therefore it is set to trigger only on pull_request here, hence only github.event.pull_request.head.repo.full_name == github.repository.

@yifanyang yifanyang merged commit 5986e67 into master Aug 4, 2022
@yifanyang yifanyang deleted the yifany/gha-migration-smoke-tests branch August 4, 2022 17:20
@firebase firebase locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants