-
Notifications
You must be signed in to change notification settings - Fork 617
Add workflow definition for smoke tests #3960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test Results 391 files + 391 391 suites +391 16m 7s ⏱️ + 16m 7s For more details on these failures, see this check. Results for commit 3aacbea. ± Comparison against base commit 8cc5d4a. ♻️ This comment has been updated with latest results. |
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected ProductsNo changes between base commit (381bf87) and merge commit (1ffc87d).Test Logs
Notes |
d660b0b
to
24936f6
Compare
on: [ pull_request ] | ||
|
||
jobs: | ||
smoke-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth adding a check to see if secrets are going to be available, similar to:
firebase-android-sdk/.github/workflows/ci_tests_experimental.yml
Lines 106 to 107 in 381bf87
# only run on post submit or PRs not originating from forks. | |
if: (github.repository == 'Firebase/firebase-android-sdk' && github.event_name == 'push') || (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The smoke tests were enabled only for presubmit on Prow, therefore it is set to trigger only on pull_request
here, hence only github.event.pull_request.head.repo.full_name == github.repository
.
No description provided.