Skip to content

Changing condition statement API version < 26 for log limit #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2022
Merged

Changing condition statement API version < 26 for log limit #3822

merged 2 commits into from
Jun 17, 2022

Conversation

argzdev
Copy link
Contributor

@argzdev argzdev commented Jun 17, 2022 •
edited
Loading

Previously #3728 which fixes #3716.

Initially, condition checker was for version (API < 24), but now will change to (API < 26).

Android documentation:

IllegalArgumentException is thrown if the tag.length() > 23 for Nougat (7.0) and prior releases (API <= 25), there is no tag limit of concern after this API level.

@argzdev argzdev changed the title change proper version <=25 for log limit Changing condition statement API version <=25 for log limit Jun 17, 2022
@argzdev argzdev requested review from rlazo and vkryachko June 17, 2022 10:54
@argzdev argzdev changed the title Changing condition statement API version <=25 for log limit Changing condition statement API version < 26 for log limit Jun 17, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 17, 2022 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (4e566d9) and merge commit (c38d1b1).

Test Logs

Notes

  • Commit (c38d1b1) is created by Prow via merging PR base commit (4e566d9) and head commit (8cad52f).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EAPXdl2WyI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 17, 2022 •
edited
Loading

Size Report 1

Affected Products

  • transport-runtime

    TypeBase (4e566d9)Merge (c38d1b1)Diff
    aar178 kB178 kB+1 B (+0.0%)

Test Logs

Notes

  • Commit (c38d1b1) is created by Prow via merging PR base commit (4e566d9) and head commit (8cad52f).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KKEaefGRsU.html

@argzdev argzdev mentioned this pull request Jun 17, 2022
Closed
@rlazo rlazo merged commit 37f0fe7 into firebase:master Jun 17, 2022
@argzdev argzdev deleted the log_exceeds_limit branch June 17, 2022 17:15
@firebase firebase locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

@vkryachko vkryachko Awaiting requested review from vkryachko

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in datatransport com.google.android.datatransport.runtime.logging.Logging
3 participants
@argzdev @google-oss-bot @rlazo