Skip to content

Issue 3716 shorten logging #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Issue 3716 shorten logging #3727

wants to merge 3 commits into from

Conversation

argzdev
Copy link
Contributor

@argzdev argzdev commented May 16, 2022

Fixes #3716.

Android version 7.0 has a limit of 23 characters when using isLoggable. Since this limit cannot be bypassed or changed, the preferred solution is to shorten the prefix and cap the concatenated string.

The concatenated string with prefix would look like this. Limited at 23 chars.
e.g.

TRuntime.SQLiteEventSto
TRuntime.CctTransportBa
TRuntime.AlarmManagerSc
TRuntime.JobInfoSchedul
TRuntime.Uploader
TRuntime.Executor

@argzdev
Copy link
Contributor Author

argzdev commented May 16, 2022

I initially thought of shortening the LOG_TAGs in their respective classes, however this would be messy and multiple classes will be affected. As a result, I've added a method to concatenate the tags with limits instead.

@argzdev argzdev requested review from vkryachko and rlazo May 16, 2022 10:16
@google-oss-bot
Copy link
Contributor

@argzdev: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 50cec71 link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (b5de13f) and merge commit (c54abdf).

Test Logs

Notes

  • Commit (c54abdf) is created by Prow via merging PR base commit (b5de13f) and head commit (50cec71).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nKv87imIRm.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • transport-runtime

    TypeBase (b5de13f)Merge (c54abdf)Diff
    aar178 kB178 kB+313 B (+0.2%)
    apk (aggressive)43.9 kB43.9 kB+16 B (+0.0%)
    apk (release)82.7 kB82.8 kB+64 B (+0.1%)

Test Logs

Notes

  • Commit (c54abdf) is created by Prow via merging PR base commit (b5de13f) and head commit (50cec71).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/z90vZHfCNU.html

@argzdev argzdev closed this May 16, 2022
@firebase firebase locked and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in datatransport com.google.android.datatransport.runtime.logging.Logging
2 participants