Skip to content

Add better testing support for TransportRuntime. #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2022

Conversation

vkryachko
Copy link
Member

No description provided.

@vkryachko vkryachko requested a review from rlazo April 20, 2022 19:43
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.18% (14f26b8) to 50.23% (d2386f2) by +0.04%.

    FilenameBase (14f26b8)Merge (d2386f2)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-firestore

    Overall coverage changed from 46.11% (14f26b8) to 46.28% (d2386f2) by +0.17%.

    FilenameBase (14f26b8)Merge (d2386f2)Diff
    AsyncQueue.java78.11%78.61%+0.50%
    Datastore.java29.76%32.14%+2.38%
    DeleteMutation.java90.48%95.24%+4.76%
    FirestoreChannel.java16.38%18.10%+1.72%
    FirestoreClient.java31.11%38.52%+7.41%
    GrpcCallProvider.java62.35%69.41%+7.06%
    IndexBackfiller.java76.56%92.19%+15.63%
    LruGarbageCollector.java84.11%93.46%+9.35%
    PatchMutation.java100.00%98.39%-1.61%
  • firebase-perf

    Overall coverage changed from 71.38% (14f26b8) to 71.39% (d2386f2) by +0.02%.

    FilenameBase (14f26b8)Merge (d2386f2)Diff
    RateLimiter.java90.98%91.73%+0.75%
  • firebase-storage

    Overall coverage changed from 85.85% (14f26b8) to 85.94% (d2386f2) by +0.09%.

    FilenameBase (14f26b8)Merge (d2386f2)Diff
    UploadTask.java80.58%81.29%+0.72%
  • transport-runtime

    Overall coverage changed from 55.05% (14f26b8) to 55.08% (d2386f2) by +0.02%.

    FilenameBase (14f26b8)Merge (d2386f2)Diff
    Uploader.java94.95%95.00%+0.05%

Test Logs

Notes

  • Commit (d2386f2) is created by Prow via merging PR base commit (14f26b8) and head commit (ee3e5e1).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/muddv4ORCI.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)216 kB216 kB+64 B (+0.0%)
    apk (release)892 kB892 kB+4 B (+0.0%)
  • firebase-crashlytics-ktx

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)232 kB232 kB+36 B (+0.0%)
    apk (release)1.37 MB1.37 MB-120 B (-0.0%)
  • firebase-datatransport

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)131 kB131 kB+36 B (+0.0%)
    apk (release)767 kB767 kB+20 B (+0.0%)
  • firebase-inappmessaging

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)664 kB664 kB-12 B (-0.0%)
    apk (release)3.42 MB3.42 MB+276 B (+0.0%)
  • firebase-inappmessaging-display

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)1.50 MB1.50 MB+64 B (+0.0%)
    apk (release)4.68 MB4.68 MB+68 B (+0.0%)
  • firebase-inappmessaging-display-ktx

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)1.51 MB1.51 MB+4 B (+0.0%)
    apk (release)5.17 MB5.17 MB-92 B (-0.0%)
  • firebase-inappmessaging-ktx

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)680 kB680 kB+88 B (+0.0%)
    apk (release)3.90 MB3.90 MB-200 B (-0.0%)
  • firebase-messaging

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)432 kB432 kB+84 B (+0.0%)
    apk (release)1.14 MB1.14 MB+36 B (+0.0%)
  • firebase-messaging-directboot

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)409 kB409 kB+32 B (+0.0%)
    apk (release)1.10 MB1.10 MB+16 B (+0.0%)
  • firebase-messaging-ktx

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)448 kB448 kB-4 B (-0.0%)
    apk (release)1.62 MB1.62 MB-36 B (-0.0%)
  • firebase-ml-modeldownloader

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)143 kB143 kB+52 B (+0.0%)
    apk (release)819 kB819 kB+36 B (+0.0%)
  • firebase-ml-modeldownloader-ktx

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)159 kB159 kB+72 B (+0.0%)
    apk (release)1.30 MB1.30 MB-68 B (-0.0%)
  • firebase-perf

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)1.03 MB1.03 MB+60 B (+0.0%)
    apk (release)2.47 MB2.47 MB+20 B (+0.0%)
  • firebase-perf-ktx

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)1.04 MB1.04 MB+140 B (+0.0%)
    apk (release)2.95 MB2.95 MB+216 B (+0.0%)
  • transport-backend-cct

    TypeBase (14f26b8)Merge (d2386f2)Diff
    apk (aggressive)58.0 kB58.1 kB+24 B (+0.0%)
    apk (release)105 kB105 kB+92 B (+0.1%)
  • transport-runtime

    TypeBase (14f26b8)Merge (d2386f2)Diff
    aar178 kB178 kB+32 B (+0.0%)
    apk (aggressive)43.8 kB43.9 kB+28 B (+0.1%)
    apk (release)82.7 kB82.7 kB+32 B (+0.0%)

Test Logs

Notes

  • Commit (d2386f2) is created by Prow via merging PR base commit (14f26b8) and head commit (ee3e5e1).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/z7ADcRKE4F.html

@vkryachko
Copy link
Member Author

/retest

@vkryachko vkryachko merged commit 12cdd59 into master Apr 21, 2022
@vkryachko vkryachko deleted the vk.transport_testing branch April 21, 2022 16:24
@google-oss-bot
Copy link
Contributor

@vkryachko: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed dafe0b2 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants