Skip to content

Add user agents for fdl, appcheck debug, safetynet and play integrity #3669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2022
Merged

Add user agents for fdl, appcheck debug, safetynet and play integrity #3669

merged 4 commits into from
Apr 20, 2022

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appcheck-debug

    Overall coverage changed from 80.88% (2131b84) to 77.46% (86d9f37) by -3.42%.

    FilenameBase (2131b84)Merge (86d9f37)Diff
    FirebaseAppCheckDebugRegistrar.java?0.00%?

  • firebase-appcheck-playintegrity

    Overall coverage changed from 91.80% (2131b84) to 87.50% (86d9f37) by -4.30%.

    FilenameBase (2131b84)Merge (86d9f37)Diff
    FirebaseAppCheckPlayIntegrityRegistrar.java?0.00%?

  • firebase-appcheck-safetynet

    Overall coverage changed from 84.00% (2131b84) to 80.77% (86d9f37) by -3.23%.

    FilenameBase (2131b84)Merge (86d9f37)Diff
    FirebaseAppCheckSafetyNetRegistrar.java?0.00%?

  • firebase-dynamic-links

    Overall coverage changed from 72.67% (2131b84) to 72.71% (86d9f37) by +0.04%.

Test Logs

Notes

  • Commit (86d9f37) is created by Prow via merging PR base commit (2131b84) and head commit (55c491f).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C6zoF3OwPj.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appcheck-debug

    TypeBase (2131b84)Merge (86d9f37)Diff
    aar11.2 kB12.0 kB+741 B (+6.6%)
    apk (aggressive)325 kB325 kB+84 B (+0.0%)
    apk (release)976 kB976 kB+68 B (+0.0%)

  • firebase-appcheck-playintegrity

    TypeBase (2131b84)Merge (86d9f37)Diff
    aar9.76 kB10.5 kB+752 B (+7.7%)
    apk (aggressive)325 kB325 kB+80 B (+0.0%)
    apk (release)986 kB986 kB+268 B (+0.0%)

  • firebase-appcheck-safetynet

    TypeBase (2131b84)Merge (86d9f37)Diff
    aar11.7 kB12.5 kB+745 B (+6.3%)
    apk (aggressive)325 kB325 kB+96 B (+0.0%)
    apk (release)987 kB987 kB+132 B (+0.0%)

  • firebase-dynamic-links

    TypeBase (2131b84)Merge (86d9f37)Diff
    aar53.2 kB53.3 kB+106 B (+0.2%)
    apk (aggressive)323 kB323 kB-28 B (-0.0%)
    apk (release)976 kB976 kB-40 B (-0.0%)

Test Logs

Notes

  • Commit (86d9f37) is created by Prow via merging PR base commit (2131b84) and head commit (55c491f).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/s7cLnIzwA1.html

@VinayGuthal VinayGuthal merged commit 14f26b8 into master Apr 20, 2022
@VinayGuthal VinayGuthal deleted the appcheck_update branch April 20, 2022 20:18
@firebase firebase locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vkryachko vkryachko vkryachko approved these changes

@rosalyntan rosalyntan rosalyntan approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VinayGuthal @google-oss-bot @vkryachko @rosalyntan