Skip to content

Fix a bug with limitToLast and cursors #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix a bug with limitToLast and cursors #3668

merged 2 commits into from
Apr 20, 2022

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 20, 2022 •
edited
Loading

Fix for android for: firebase/firebase-js-sdk#6134

@wu-hui wu-hui requested a review from cherylEnkidu April 20, 2022 15:34
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.28% (aa75720) to 46.11% (b6e9905) by -0.17%.

    FilenameBase (aa75720)Merge (b6e9905)Diff
    AsyncQueue.java78.61%78.11%-0.50%
    Datastore.java32.14%29.76%-2.38%
    FirestoreChannel.java18.10%16.38%-1.72%
    FirestoreClient.java38.52%31.11%-7.41%
    GrpcCallProvider.java69.41%62.35%-7.06%
    IndexBackfiller.java92.19%76.56%-15.63%
    LruGarbageCollector.java93.46%84.11%-9.35%

Test Logs

Notes

  • Commit (b6e9905) is created by Prow via merging PR base commit (aa75720) and head commit (ec31d4a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PVHhW6Aio4.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 20, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (aa75720)Merge (b6e9905)Diff
    aar1.25 MB1.25 MB-40 B (-0.0%)
    apk (release)3.38 MB3.38 MB+44 B (+0.0%)

Test Logs

Notes

  • Commit (b6e9905) is created by Prow via merging PR base commit (aa75720) and head commit (ec31d4a).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/m2ovvtritz.html

cherylEnkidu
cherylEnkidu approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@cherylEnkidu cherylEnkidu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you :)

@cherylEnkidu cherylEnkidu assigned wu-hui and unassigned cherylEnkidu Apr 20, 2022
@wu-hui wu-hui merged commit 2131b84 into master Apr 20, 2022
@wu-hui wu-hui deleted the wuandy/LimitToLastWithCursor branch April 20, 2022 16:05
@firebase firebase locked and limited conversation to collaborators May 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cherylEnkidu cherylEnkidu cherylEnkidu approved these changes

Assignees

@wu-hui wu-hui

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wu-hui @google-oss-bot @cherylEnkidu