Skip to content

Add FirebaseFunctions.getHttpsCallableFromURL #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

inlined
Copy link
Member

@inlined inlined commented Apr 17, 2022

Sorry for a late-coming urgent change; AFAICT nobody on the SDK team could staff these changes, so I'm trying to write the change for the top 3 SDKs before I/O freeze.

For context, see go/cf3v2-crash-landing.
For API approval, see go/callable-functions-custom-urls

@inlined inlined requested a review from rlazo April 17, 2022 04:34
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2022

Coverage Report 1

Affected Products

  • firebase-functions

    Overall coverage changed from ? (2cbed1d) to 3.43% (9f58315) by ?.

    11 individual files with coverage change

    FilenameBase (2cbed1d)Merge (9f58315)Diff
    ContextProvider.java?0.00%?
    FirebaseContextProvider.java?0.00%?
    FirebaseFunctions.java?0.00%?
    FirebaseFunctionsException.java?0.00%?
    FunctionsMultiResourceComponent.java?0.00%?
    FunctionsRegistrar.java?65.22%?
    HttpsCallableContext.java?0.00%?
    HttpsCallableReference.java?0.00%?
    HttpsCallableResult.java?0.00%?
    HttpsCallOptions.java?0.00%?
    Serializer.java?0.00%?

Test Logs

Notes

  • Commit (9f58315) is created by Prow via merging PR base commit (2cbed1d) and head commit (4b173f8).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qJY0pQQmuz.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-functions:
error: Added method com.google.firebase.functions.FirebaseFunctions.getHttpsCallableFromUrl(String) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 17, 2022

Size Report 1

Affected Products

  • firebase-functions

    TypeBase (2cbed1d)Merge (9f58315)Diff
    aar25.8 kB26.1 kB+363 B (+1.4%)
    apk (release)1.21 MB1.21 MB+432 B (+0.0%)

Test Logs

Notes

  • Commit (9f58315) is created by Prow via merging PR base commit (2cbed1d) and head commit (4b173f8).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/MKB0wSSPYA.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-functions:
error: Removed method com.google.firebase.functions.FirebaseFunctions.getHttpsCallableFromUrl(URL) [RemovedMethod]
error: Added method com.google.firebase.functions.FirebaseFunctions.getHttpsCallableFromUrl(java.net.URL) [AddedMethod]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@inlined
Copy link
Member Author

inlined commented Apr 18, 2022

/test check-changed

@vkryachko vkryachko requested a review from davidmotson April 19, 2022 18:20
@inlined inlined merged commit 09b7445 into master Apr 19, 2022
@inlined inlined deleted the inlined.httpsCallableFromURL branch April 19, 2022 19:58
@firebase firebase locked and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants