Skip to content

Return the minimum index type from all targets #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2022
Merged

Return the minimum index type from all targets #3656

merged 1 commit into from
Apr 16, 2022

Conversation

schmidt-sebastian
Copy link
Contributor

We need to return the least restrictive index type and not the first one we find

@schmidt-sebastian
Returns the minimum index type from all targets
1da090f 
We need to return the least restrictive index type and not the first one we find
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.09% (5600426) to 46.11% (24a01c0) by +0.01%.

    FilenameBase (5600426)Merge (24a01c0)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    SetMutation.java94.44%97.22%+2.78%
    SQLiteIndexManager.java99.48%99.49%+0.00%

Test Logs

Notes

  • Commit (24a01c0) is created by Prow via merging PR base commit (5600426) and head commit (1da090f).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/H8iJLQC5a8.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (5600426)Merge (24a01c0)Diff
    aar1.25 MB1.25 MB+20 B (+0.0%)
    apk (release)3.38 MB3.38 MB-24 B (-0.0%)

Test Logs

Notes

  • Commit (24a01c0) is created by Prow via merging PR base commit (5600426) and head commit (1da090f).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tCqdwaBcrR.html

@schmidt-sebastian schmidt-sebastian changed the title Returns the minimum index type from all targets Return the minimum index type from all targets Apr 15, 2022
@ehsannas ehsannas merged commit 7f0bff1 into master Apr 16, 2022
@ehsannas ehsannas deleted the mrschmidt/fixindextype branch April 16, 2022 00:01
@firebase firebase locked and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@ehsannas ehsannas

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @ehsannas