Skip to content

Timeout when blocking tasks on any thread. #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Timeout when blocking tasks on any thread. #3645

merged 1 commit into from
Apr 13, 2022

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 13, 2022

This fixes a bug where the exception handler never times out while waiting for settings that never come.

@mrober mrober requested a review from mrichards April 13, 2022 17:37
Copy link
Contributor

@mrichards mrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on pairing together. :)

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022

Coverage Report 1

Affected Products

  • firebase-crashlytics

    FilenameBase (148cc77)Merge (0659665)Diff
    CrashlyticsController.java18.40%18.29%-0.11%

Test Logs

Notes

  • Commit (0659665) is created by Prow via merging PR base commit (148cc77) and head commit (b60bcb2).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/iovALr99Jv.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 13, 2022

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (148cc77)Merge (0659665)Diff
    aar340 kB340 kB+18 B (+0.0%)
    apk (aggressive)216 kB216 kB+4 B (+0.0%)
    apk (release)891 kB891 kB-16 B (-0.0%)

Test Logs

Notes

  • Commit (0659665) is created by Prow via merging PR base commit (148cc77) and head commit (b60bcb2).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XSlWX04qSg.html

@mrober mrober merged commit 5f7ac45 into master Apr 13, 2022
@mrober mrober deleted the crashlytics-dev branch April 13, 2022 17:53
@google-oss-bot
Copy link
Contributor

@mrober: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests b60bcb2 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@firebase firebase locked and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants