Skip to content

Check for a specific flutter asset file instead of listing the path #3631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

mrober
Copy link
Contributor

@mrober mrober commented Apr 8, 2022

Check for a specific flutter asset file instead of listing the path.

This should fix issue #3605 caused by the fact that listing an asset path may be slow in some cases.

@mrober mrober requested a review from mrichards April 8, 2022 15:54
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (26c905b) and merge commit (c086eb0).

Test Logs

Notes

  • Commit (c086eb0) is created by Prow via merging PR base commit (26c905b) and head commit (2926d63).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/14iqhRYuog.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (26c905b)Merge (c086eb0)Diff
    aar340 kB340 kB+156 B (+0.0%)
    apk (aggressive)215 kB216 kB+72 B (+0.0%)
    apk (release)891 kB891 kB-36 B (-0.0%)

Test Logs

Notes

  • Commit (c086eb0) is created by Prow via merging PR base commit (26c905b) and head commit (2926d63).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3PpYlULdbF.html

@argzdev
Copy link
Contributor

argzdev commented Apr 8, 2022

I think this is a good fix, since AssetManager.list() have been reported to have slow performance in a few cases. Hopefully checking the file directly will address the issue for Android 6.0 devices.

@mrober mrober merged commit 1f25801 into master Apr 8, 2022
@mrober mrober deleted the crashlytics-dev branch April 8, 2022 17:51
@firebase firebase locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants