Skip to content

Update App Check SDKs to use v1 API. #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Update App Check SDKs to use v1 API. #3627

merged 2 commits into from
Apr 18, 2022

Conversation

rosalyntan
Copy link
Member

Switch the App Check SDKs over to using the v1 App Check APIs.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 7, 2022

Coverage Report 1

Affected Products

  • firebase-appcheck

    Overall coverage changed from 81.05% (a751091) to 81.01% (f1ab503) by -0.04%.

    FilenameBase (a751091)Merge (f1ab503)Diff
    DefaultAppCheckToken.java88.00%87.76%-0.24%

Test Logs

Notes

  • Commit (f1ab503) is created by Prow via merging PR base commit (a751091) and head commit (ef8aba6).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sCDLHvWYVA.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 7, 2022

Size Report 1

Affected Products

  • firebase-appcheck

    TypeBase (a751091)Merge (f1ab503)Diff
    aar37.2 kB37.1 kB-71 B (-0.2%)
    apk (aggressive)330 kB330 kB+12 B (+0.0%)
    apk (release)973 kB973 kB-24 B (-0.0%)
  • firebase-appcheck-debug

    TypeBase (a751091)Merge (f1ab503)Diff
    aar11.2 kB11.2 kB-13 B (-0.1%)
    apk (aggressive)330 kB330 kB+12 B (+0.0%)
    apk (release)975 kB975 kB-16 B (-0.0%)
  • firebase-appcheck-debug-testing

    TypeBase (a751091)Merge (f1ab503)Diff
    aar6.69 kB6.67 kB-19 B (-0.3%)
    apk (aggressive)331 kB331 kB-16 B (-0.0%)
    apk (release)1.01 MB1.01 MB+76 B (+0.0%)
  • firebase-appcheck-interop

    TypeBase (a751091)Merge (f1ab503)Diff
    aar5.45 kB5.43 kB-14 B (-0.3%)
    apk (release)962 kB962 kB+28 B (+0.0%)
  • firebase-appcheck-safetynet

    TypeBase (a751091)Merge (f1ab503)Diff
    aar11.7 kB11.7 kB-14 B (-0.1%)
    apk (aggressive)330 kB330 kB+16 B (+0.0%)
    apk (release)986 kB986 kB+100 B (+0.0%)

Test Logs

Notes

  • Commit (f1ab503) is created by Prow via merging PR base commit (a751091) and head commit (ef8aba6).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HsiYN9WsIS.html

@rosalyntan
Copy link
Member Author

/retest

@rosalyntan rosalyntan requested a review from vkryachko April 14, 2022 22:52
@rosalyntan
Copy link
Member Author

/test device-check-changed

3 similar comments
@rosalyntan
Copy link
Member Author

/test device-check-changed

@rosalyntan
Copy link
Member Author

/test device-check-changed

@rosalyntan
Copy link
Member Author

/test device-check-changed

Copy link
Contributor

@malcolmdeck malcolmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rosalyntan rosalyntan merged commit a3f5d67 into master Apr 18, 2022
@rosalyntan rosalyntan deleted the rosalyntan.v1 branch April 18, 2022 23:56
@firebase firebase locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants