Simplify Crashlytics settings #3625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "app" portion of the settings response is no longer used by Crashlytics. This commit removes parsing of that section, which required refactoring how the Task API is used to wait for settings to return. WIP
Coverage Report 1Affected Products
Test Logs
Notes |
Size Report 1Affected Products
Test Logs
Notes |
mrober
approved these changes
Apr 7, 2022
| @Override | ||
| public FeaturesSettingsData getFeaturesData() { | ||
| return featuresData; | ||
| public FeatureFlagData getFeatureFlagData() { |
There was a problem hiding this comment.
Why do we need these getters when the fields are public already?
There was a problem hiding this comment.
The Settings class gets mocked in some of the tests. But taking a closer look at those tests, I think I can replace all the mocks with actual instances.
| TaskCompletionSource<AppSettingsData> fetchedAppSettings = | ||
| new TaskCompletionSource<>(); | ||
| fetchedAppSettings.trySetResult(fetchedSettings.getAppSettingsData()); | ||
| appSettingsData.set(fetchedAppSettings); |
There was a problem hiding this comment.
Did you verify that we don't need to do this?
There was a problem hiding this comment.
It works as expected in the happy path. I found a bug that can occur when there's no network access, but it predates this PR by at least several versions. So I'm fairly confident the above lines are fine, but I'll work it all out when I fix that bug.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "app" portion of the settings response is no longer used by
Crashlytics. This commit removes parsing of that section, which
required refactoring how the Task API is used to wait for settings
to return.
It also flattens the package hierarchy for the settings.* packages
and removes some unnecessary interfaces.