Skip to content

Fix validation bug for composite filters. #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 6, 2022
Merged

Fix validation bug for composite filters. #3609

merged 4 commits into from
Apr 6, 2022

Conversation

ehsannas
Copy link
Contributor

No description provided.

@ehsannas ehsannas force-pushed the ehsann/composite-filter-validation branch from be18970 to 7a59eed Compare April 1, 2022 19:56
@firebase firebase deleted a comment from google-oss-bot Apr 1, 2022
@ehsannas
Copy link
Contributor Author

ehsannas commented Apr 1, 2022

FYI @cherylEnkidu

schmidt-sebastian
schmidt-sebastian approved these changes Apr 4, 2022
View reviewed changes
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 46.05% (8193f13) to 46.05% (24c8ab9) by +0.00%.

    FilenameBase (8193f13)Merge (24c8ab9)Diff
    AsyncQueue.java77.11%78.11%+1.00%
    CompositeFilter.java88.33%85.48%-2.85%
    DeleteMutation.java95.00%90.00%-5.00%

Test Logs

Notes

  • Commit (24c8ab9) is created by Prow via merging PR base commit (8193f13) and head commit (d62a25a).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cxy97Ox3Se.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (8193f13)Merge (24c8ab9)Diff
    aar1.25 MB1.25 MB+36 B (+0.0%)
    apk (release)3.38 MB3.38 MB+164 B (+0.0%)

Test Logs

Notes

  • Commit (24c8ab9) is created by Prow via merging PR base commit (8193f13) and head commit (d62a25a).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AEQOY6DWNo.html

@ehsannas
Copy link
Contributor Author

ehsannas commented Apr 5, 2022

/retest

schmidt-sebastian
schmidt-sebastian approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and for adding the test message assertions.

@ehsannas ehsannas merged commit 21d351e into master Apr 6, 2022
@ehsannas ehsannas deleted the ehsann/composite-filter-validation branch April 6, 2022 04:41
@firebase firebase locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@ehsannas ehsannas

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @schmidt-sebastian