Splitting into pre and post proguard tests #36
Conversation
ashwinraghav
force-pushed
the
no_proguard_smoke
branch
from
0239d23 to
8265708
Compare
|
@vkryachko Just confirming that we are yet to introduce the maven cache proxy. |
…o no_proguard_smoke
|
The proxy is enabled, we have not yet disabled the local shared mount of modules-2, will do today |
|
/test copyright-check |
|
/test connected-check |
ci/fireci/fireci/commands.py
Outdated
| os.path.join(cwd, 'build', 'm2repository')), | ||
| workdir=os.path.join(cwd, 'test-apps'), | ||
| ) | ||
| def smoke_tests_proguarded_app(): |
There was a problem hiding this comment.
both tasks look almost identical, did you consider having a single parameterized smoke_tests command with a @click.option('--build-type')?
|
@ashwinraghav: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test smoke-tests-release |
|
/lgtm |
This change makes it possible to run the smoke tests on unproguarded versions of apps.
The goal is to have smoke tests that run on unproguarded apps and on proguarded apps.
Given the way the android plugin works, it seems hard to do this in the same gradle run, and may require that we have two separate gradle invocations for these tests.
and