Skip to content

Add createNotificationInfo() that takes a calling and an app Context. #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2022
Merged

Add createNotificationInfo() that takes a calling and an app Context. #3598

merged 1 commit into from
Mar 30, 2022

Conversation

gsakakihara
Copy link
Contributor

  • Added createNotificationInfo() variant that allows specifying a calling Context to be used for creating PendingIntents and one Context that the notification is intended for (resources, package name, manifest data, etc.).

@gsakakihara
Add createNotificationInfo() that takes a calling and an app Context.
4ad1302 
* Added createNotificationInfo() variant that allows specifying a calling Context to be used for creating PendingIntents and one Context that the notification is intended for (resources, package name, manifest data, etc.).
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.73% (93e4a4a) to 84.86% (ab42f64) by +0.13%.

    FilenameBase (93e4a4a)Merge (ab42f64)Diff
    CommonNotificationBuilder.java90.73%90.38%-0.35%
    MessagingAnalytics.java81.38%83.00%+1.62%

Test Logs

Notes

  • Commit (ab42f64) is created by Prow via merging PR base commit (93e4a4a) and head commit (4ad1302).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/vcE1IuX71X.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-messaging

    TypeBase (93e4a4a)Merge (ab42f64)Diff
    aar141 kB142 kB+210 B (+0.1%)
    apk (aggressive)437 kB437 kB-32 B (-0.0%)
    apk (release)1.14 MB1.14 MB+44 B (+0.0%)

Test Logs

Notes

  • Commit (ab42f64) is created by Prow via merging PR base commit (93e4a4a) and head commit (4ad1302).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/W40WrHRv3I.html

@gsakakihara
Copy link
Contributor Author

/retest

@gsakakihara gsakakihara merged commit 0472f6f into master Mar 30, 2022
@gsakakihara gsakakihara deleted the gsakakihara/notification_context branch March 30, 2022 19:42
@firebase firebase locked and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willxu-google willxu-google willxu-google approved these changes

@welishr welishr Awaiting requested review from welishr

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsakakihara @google-oss-bot @willxu-google